>- less than 80 - \epsilon chars per line. >- no tabs after the first non-tab on the line.
> - Two empty lines between function definitions. > - includes roughly from most-specific to least-specific. In any case > "ours" before "system" headers/. > - A .cpp must have #include <config.h> as first include. > - no "using" in headers. maybe these should be added to coding style. > - no "using" in headers. just to learn, why ? > - no unneeded includes, especially in headers (there was a spurious > #include <debug.h>. Apart from that "our" headers would use "...", > not <...> ugh, sorry. > - A .cpp must have #include <config.h> as first include. again, why ? > The patch as-is does not even link for me. hmm. it did for me before i posted. maybe something changed in trunk meanwhile, maybe you forget to add PDFOptions.h/cpp (you forget to commit them). > I'll commit a modified version of your patch shortly nevertheless. thanks. > Please check that everything still works as intended. not at all, quick scan of current trunk reveal that the patch was not correctly applied or/and commited. pavel
