> > More comments: > > > > > + } else if (token == "\\use_hyperref") { > > > + lex >> pdfoptions().use_hyperref; > > > + } else if (token == "\\pdf_title") { > > > + lex >> pdfoptions().title; > > > + } else if (token == "\\pdf_author") { > > > + lex >> pdfoptions().author; > > > > Just a suggestion: in order to keep everything in one place, what > > about doing > > > > } else if (prefixIs(token, "\\pdf_") > > pdfoptions().read(token, lex); > > > > and move the long string of tests to PDFOptions.cpp? > > in fact, i'll be more happy to have all the code inside PDFOptions, > but i have seen that all other tokens are done there, so didnt want > to disturb the logic. i move it now.
it seems nobody else has objections now, so please can anybody step up and commit it into trunk, so others can work on it too ? pavel