Re: [PATCH] LyX/Mac menu merging

2007-01-03 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> That works for both English, French, and German. (Accents are Bennett> working well.) OK, the patch is in now. Bennett> The only catch is that the LyX menu is in English for all Bennett> versions. (Other menus are in the correc

Re: [PATCH] LyX/Mac menu merging

2006-12-30 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> That works for both English, French, and German. (Accents are Bennett> working well.) Bennett> The only catch is that the LyX menu is in English for all Bennett> versions. (Other menus are in the correct language.) This was exp

Re: [PATCH] LyX/Mac menu merging

2006-12-29 Thread Bennett Helm
On Dec 29, 2006, at 6:59 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Jean-Marc> Try this one instead. It should additionally show correctly Jean-Marc> the menus when a dialog has focus. Bennett> In both English and French, I get only a LyX menu and no

Re: [PATCH] LyX/Mac menu merging

2006-12-29 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Jean-Marc> Try this one instead. It should additionally show correctly Jean-Marc> the menus when a dialog has focus. Bennett> In both English and French, I get only a LyX menu and nothing Bennett> else. In that menu, Preferences is graye

Re: [PATCH] LyX/Mac menu merging

2006-12-28 Thread Bennett Helm
On Dec 22, 2006, at 10:43 AM, Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Can you try the following patch? The outcome should be the Jean-Marc> same in english, and in f

Re: [PATCH] LyX/Mac menu merging

2006-12-22 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Can you try the following patch? The outcome should be the Jean-Marc> same in english, and in french it should work, except that Jean-Marc> the men

Re: [PATCH] LyX/Mac menu merging

2006-12-22 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Can you try the following patch? The outcome should be the Jean-Marc> same in english, and in french it should work, except that Jean-Marc> the menu entries in the LyX menu will be in english. Jean-Marc> BTW, Abdel,

Re: [PATCH] LyX/Mac menu merging

2006-12-22 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I checked with LANG=FR_fr. Accents appear correctly. But in Bennett> this case the LyX menu on the left does not have About LyX, Bennett> and the Preferences i

Re: [PATCH] LyX/Mac menu merging

2006-12-22 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I checked with LANG=FR_fr. Accents appear correctly. But in Bennett> this case the LyX menu on the left does not have About LyX, Bennett> and the Preferences item is grayed out (but note that in this Bennett> case no accents). Th

Re: [PATCH] LyX/Mac menu merging

2006-12-20 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> I just added a new 'LyX' menu with a Quit entry, because if it > Peter> doesn't exist, it will be created by Qt(?) and the generated > Peter> Quit bypasses our quit strategy which ends in a crash. >

Re: [PATCH] LyX/Mac menu merging

2006-12-20 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> Yes: everything seems to be where it belongs, and the extra Bennett> LyX menu has disappeared. OK, I'll commit then. Bennett> I did notice one thing, though. As I have reported before, Bennett> when a dialog is frontmost, most

Re: [PATCH] LyX/Mac menu merging

2006-12-20 Thread Bennett Helm
On Dec 20, 2006, at 8:39 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Final checks: - did you check that stuff like Document>Settings is not removed? Bennett> Yes: that is there. - what happens in non-english locale? Bennett> I checked with LANG

Re: [PATCH] LyX/Mac menu merging

2006-12-20 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> Final checks: >> >> - did you check that stuff like Document>Settings is not removed? Bennett> Yes: that is there. >> - what happens in non-english locale? Bennett> I checked with LANG=FR_fr. Accents appear correctly. But in Bennet

Re: [PATCH] LyX/Mac menu merging

2006-12-20 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> I just added a new 'LyX' menu with a Quit entry, because if it Peter> doesn't exist, it will be created by Qt(?) and the generated Peter> Quit bypasses our quit strategy which ends in a crash. Peter> http://www.lyx.org/trac/changese

Re: [PATCH] LyX/Mac menu merging

2006-12-19 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> OK, it was just a idea, because I've added the right 'LyX' menu > Peter> to fix the crash on exit. Seems 'Exit' is already renamed. > > I missed this a the time. Could you explain exactly what you di

Re: [PATCH] LyX/Mac menu merging

2006-12-19 Thread Bennett Helm
On Dec 19, 2006, at 1:30 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> It works well. Everything seems to be in the right place, and Bennett> all the menu options in the standard LyX menu work as Bennett> expected. Actually, the extra menu is n

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> OK, it was just a idea, because I've added the right 'LyX' menu Peter> to fix the crash on exit. Seems 'Exit' is already renamed. Jean-Marc> I missed this a the t

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> It works well. Everything seems to be in the right place, and Bennett> all the menu options in the standard LyX menu work as Bennett> expected. Actually, the extra menu is named "special" and it is added *before* File. I was try

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> OK, it was just a idea, because I've added the right 'LyX' menu Peter> to fix the crash on exit. Seems 'Exit' is already renamed. I missed this a the time. Could you explain exactly what you did? JMarc

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Peter Kümmel
Bennett Helm wrote: > On Dec 18, 2006, at 3:13 PM, Peter Kümmel wrote: > >> Bennett Helm wrote: >>> On Dec 18, 2006, at 5:35 AM, Jean-Marc Lasgouttes wrote: >>> > "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 2. Selecting either Preferences or About LyX (from eit

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Bennett Helm
On Dec 18, 2006, at 3:13 PM, Peter Kümmel wrote: Bennett Helm wrote: On Dec 18, 2006, at 5:35 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 2. Selecting either Preferences or About LyX (from either the Bennett> LyX or File menus) results in

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Peter Kümmel
Bennett Helm wrote: > On Dec 18, 2006, at 5:35 AM, Jean-Marc Lasgouttes wrote: > >>> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> >> Bennett> 2. Selecting either Preferences or About LyX (from either the >> Bennett> LyX or File menus) results in a crash. Here's the backtrace: >> >>

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Bennett Helm
On Dec 18, 2006, at 5:35 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 2. Selecting either Preferences or About LyX (from either the Bennett> LyX or File menus) results in a crash. Here's the backtrace: OK, here am I again with a new approach t

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Bennett Helm
On Dec 18, 2006, at 3:49 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I just updated to current svn, and accelerator keys are now Bennett> visible in menus. (And as you suspect, multi key accelerators Bennett> don't show up. Of courese, they ne

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 2. Selecting either Preferences or About LyX (from either the Bennett> LyX or File menus) results in a crash. Here's the backtrace: OK, here am I again with a new approach to the menu merging issue. With the patch below, everyth

Re: [PATCH] LyX/Mac menu merging

2006-12-18 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I just updated to current svn, and accelerator keys are now Bennett> visible in menus. (And as you suspect, multi key accelerators Bennett> don't show up. Of courese, they never showed up for 1.4.x or Bennett> 1.3.x either, and I

Re: [PATCH] LyX/Mac menu merging

2006-12-17 Thread Stefano Franchi
On 17 Dec, 2006, at 9:22 PM, Bennett Helm wrote: On Dec 17, 2006, at 10:13 PM, Stefano Franchi wrote: On 17 Dec, 2006, at 8:43 PM, Bennett Helm wrote: I just updated to current svn, and accelerator keys are now visible in menus. (And as you suspect, multi key accelerators don't show up.

Re: [PATCH] LyX/Mac menu merging

2006-12-17 Thread Bennett Helm
On Dec 17, 2006, at 10:13 PM, Stefano Franchi wrote: On 17 Dec, 2006, at 8:43 PM, Bennett Helm wrote: I just updated to current svn, and accelerator keys are now visible in menus. (And as you suspect, multi key accelerators don't show up. Of courese, they never showed up for 1.4.x or 1.3

Re: [PATCH] LyX/Mac menu merging

2006-12-17 Thread Stefano Franchi
On 17 Dec, 2006, at 8:43 PM, Bennett Helm wrote: I just updated to current svn, and accelerator keys are now visible in menus. (And as you suspect, multi key accelerators don't show up. Of courese, they never showed up for 1.4.x or 1.3.x either, and I can't think of any other Mac program th

Re: [PATCH] LyX/Mac menu merging

2006-12-17 Thread Bennett Helm
On Dec 13, 2006, at 9:13 AM, Jean-Marc Lasgouttes wrote: "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Tuesday 12 December 2006 2:29 pm, Jean-Marc Lasgouttes wrote: I did that. I think I should apply it without waiting for Bennett's testing, since it is rather straightforward. Qt

Re: [PATCH] LyX/Mac menu merging

2006-12-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdel, I think this means that QAction cannot be subclassed safely in Qt/Mac: the code there copies our QLAction objects as if they were QAction, and the part that contains the FuncRequest gets lost. It

Re: [PATCH] LyX/Mac menu merging

2006-12-15 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdel, I think this means that QAction cannot be subclassed safely >> in Qt/Mac: the code there copies our QLAction objects as if they >> were QAction, and the part that contains the FuncRequest gets lost. >> It seems to me th

Re: [PATCH] LyX/Mac menu merging

2006-12-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 2. Selecting either Preferences or About LyX (from either the Bennett> LyX or File menus) results in a crash. Here's the backtrace: Bennett> action: 236468448 is not known. Assertion triggered in bool Ben

Re: [PATCH] LyX/Mac menu merging

2006-12-14 Thread Andre Poenitz
On Tue, Dec 12, 2006 at 03:06:31PM +0100, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > > OK, here is the patch. Test it when you can. > > Some nitpicks: > > > -return fromqstr(qprint(mod)); > > +return from_utf8(fromqstr(QKeySequence(tmpkey).toString())); > > Please use >

Re: [PATCH] LyX/Mac menu merging

2006-12-13 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Tuesday 12 December 2006 2:29 pm, Jean-Marc Lasgouttes wrote: >> I did that. I think I should apply it without waiting for >> Bennett's testing, since it is rather straightforward. Qt/Mac is >> the only instance of having unicode cha

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread José Matos
On Tuesday 12 December 2006 2:29 pm, Jean-Marc Lasgouttes wrote: > > I did that. I think I should apply it without waiting for Bennett's > testing, since it is rather straightforward. Qt/Mac is the only > instance of having unicode characters AFAIK (the command and control > characters) so it shoul

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> OK, here is the patch. Test it when you can. Georg> Some nitpicks: I did that. I think I should apply it without waiting for Bennett's testing, since it is rather straightforward. Qt/Mac is the only ins

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > OK, here is the patch. Test it when you can. Some nitpicks: > -return fromqstr(qprint(mod)); > +return from_utf8(fromqstr(QKeySequence(tmpkey).toString())); Please use return qstring_to_ucs4(QKeySequence(tmpkey).toString()); > +do

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> It might help if there was a patch! Bennett> I'm going to be away for about a week starting today, so I'm Bennett> afraid testing will have to wait. OK, here is the patch. Test it when you can. JMarc Index: src/lyxfunc.C

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread Bennett Helm
On Dec 12, 2006, at 8:40 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 1. Accelerator keys are not displayed in menus. Hello Bennett, Let's start with easy things. Does the following patch restore display of accelerators in menus? Is the displ

Re: [PATCH] LyX/Mac menu merging

2006-12-12 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> 1. Accelerator keys are not displayed in menus. Hello Bennett, Let's start with easy things. Does the following patch restore display of accelerators in menus? Is the display in status bar correct? I suspect that multi key ac

Re: [PATCH] LyX/Mac menu merging

2006-12-09 Thread Peter Kümmel
Bennett Helm schrieb: On Dec 8, 2006, at 10:50 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> That doesn't crash on startup like before, but things aren't Bennett> as they should be. Here are 4 items, all of which I believe Bennett> are caused b

Re: [PATCH] LyX/Mac menu merging

2006-12-08 Thread Bennett Helm
On Dec 8, 2006, at 10:50 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> That doesn't crash on startup like before, but things aren't Bennett> as they should be. Here are 4 items, all of which I believe Bennett> are caused by this patch. (Note tha

Re: [PATCH] LyX/Mac menu merging

2006-12-08 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> That doesn't crash on startup like before, but things aren't Bennett> as they should be. Here are 4 items, all of which I believe Bennett> are caused by this patch. (Note that I have just upgraded to Bennett> Qt-4.2.2, but I don'

Re: [PATCH] LyX/Mac menu merging

2006-12-01 Thread Bennett Helm
On Dec 1, 2006, at 4:37 PM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> Well, it compiles now, but LyX on startup. Here's the Bennett> backtrace: Try this one instead. That doesn't crash on startup like before, but things aren't as they shoul

Re: [PATCH] LyX/Mac menu merging

2006-12-01 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> Well, it compiles now, but LyX on startup. Here's the Bennett> backtrace: Try this one instead. JMarc Index: src/frontends/qt4/qt_helpers.h === --- src/frontends/

Re: [PATCH] LyX/Mac menu merging

2006-12-01 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Let's try to be more ambitious. This patch tries to reimplement >> the feature. It is cleaner than the previous one because (1) the >> use of Action helps and (2) I think I got a better idea. The idea >> remains basically the

Re: [PATCH] LyX/Mac menu merging

2006-12-01 Thread Bennett Helm
On Dec 1, 2006, at 11:09 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> The patch won't compile: Sorry, typo. Try this one. JMarc PS: I have to go now. Well, it compiles now, but LyX on startup. Here's the backtrace: Program received sign

Re: [PATCH] LyX/Mac menu merging (was Re: [PATCH for mac] Re: Alpha 2 - Plan for action)

2006-12-01 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: I am beginning to wonder whether we should disable all menu merging, as Qt/Mac allows us to do. Abdelrazak> I think this is a sound solution, at least for 1.5.0.

Re: [PATCH] LyX/Mac menu merging

2006-12-01 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> The patch won't compile: Sorry, typo. Try this one. JMarc PS: I have to go now. Index: src/frontends/qt4/qt_helpers.h === --- src/frontends/qt4/qt_helpers.h (rev

Re: [PATCH] LyX/Mac menu merging (was Re: [PATCH for mac] Re: Alpha 2 - Plan for action)

2006-12-01 Thread Bennett Helm
On Dec 1, 2006, at 10:38 AM, Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: I am beginning to wonder whether we should disable all menu merging, as Qt/Mac allows us to do. Abdelrazak> I think this is a sound

[PATCH] LyX/Mac menu merging (was Re: [PATCH for mac] Re: Alpha 2 - Plan for action)

2006-12-01 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >> I am beginning to wonder whether we should disable all menu >> merging, as Qt/Mac allows us to do. Abdelrazak> I think this is a sound solution, at least for 1.5.0. Let's try to be mor