>>>>> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> That doesn't crash on startup like before, but things aren't Bennett> as they should be. Here are 4 items, all of which I believe Bennett> are caused by this patch. (Note that I have just upgraded to Bennett> Qt-4.2.2, but I don't notice any difference between 4.2.1 and Bennett> 4.2.2.) Bennett> 1. Accelerator keys are not displayed in menus. (I could Bennett> swear I saw them once, but I could never bring them back to Bennett> confirm.) I am 80% sure that this is a separate problem. Bennett> The Preferences and About LyX items start off under the LyX Bennett> menu (where they should be), but as soon as the File menu is Bennett> opened, they appear under the File menu, and under the LyX Bennett> menu Preferences appears but is grayed out and About LyX has Bennett> disappeared. Bennett> 2. Selecting either Preferences or About LyX (from either the Bennett> LyX or File menus) results in a crash. Here's the backtrace: Bennett> action: 236468448 is not known. Assertion triggered in bool Bennett> lyx::LyXAction::funcHasFlag (lyx::kb_action, Bennett> lyx::LyXAction::func_attrib) const by failing check "false" Bennett> in file LyXAction.C:424 Abdel, I think this means that QAction cannot be subclassed safely in Qt/Mac: the code there copies our QLAction objects as if they were QAction, and the part that contains the FuncRequest gets lost. It seems to me that your nifty scheme does not work :( What I read above is that the action triggers, but the QLAction object is not valid. Bennett> 3. Resizing the LyX window and then quitting results in a Bennett> crash. Here's the backtrace: Not sure this is related to the patch. Bennett> 4. Opening a new document, typing a few characters, and then Bennett> closing brings up the "Do you want to save" dialog. Clicking Bennett> on the "Discard" button causes a crash. Here's the backtrace: Not related to the patch IMO. Bennett, what happens if you comment out # define MERGE_MAC_MENUS in QLPopupMenu.h? JMarc
