Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread John Levon
On 23 Feb 2001, Lars Gullik Bjønnes wrote: > Juergen Vigna <[EMAIL PROTECTED]> writes: > > | As you know we also are pretty specialized f.ex. Jean-Marc does the configure > | stuff normally. So If I see a part which is in my campus I'm fast to review > | it, but if most of the patch is outside a

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | As you know we also are pretty specialized f.ex. Jean-Marc does the configure | stuff normally. So If I see a part which is in my campus I'm fast to review | it, but if most of the patch is outside and I don't know how to split it | up I probably will g

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread Juergen Vigna
On 23-Feb-2001 Angus Leeming wrote: > Alternatively, Lars will end up having to look at everything! Good old Lars ;) Well I had a (REALLY) fast look at the patch and now I'm more then before of the same opinion as Angus. There are too much different changes in that file, to chop with and I fea

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > For the same reason. It's too much for mere mortals to cope with! OK, I'll split it now. Thanks. > Well different people know different bits of the code to different levels. > For example, I feel able to comment on the FileDialog stuff which looks li

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 13:58, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > Come on, John! This is huge and monstrous! Can't you split it up into > > logically independent patches: > > > > * configure stuff > > * File dialog > > * External dialog > > * DO_USE_DEFAULT_L

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Juergen Vigna wrote: > > On 23-Feb-2001 John Levon wrote: > > > It was half the size last week when it got ignored. I *could* just split it up > > but I don't see how that helps, it just makes 10 or so ChangeLog .rej files > > the applier has to clean up. > > > > It all ha

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread Juergen Vigna
On 23-Feb-2001 John Levon wrote: > It was half the size last week when it got ignored. I *could* just split it up > but I don't see how that helps, it just makes 10 or so ChangeLog .rej files > the applier has to clean up. > > It all has to be reviewed by *someone*. How does splitting it up mak

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > Come on, John! This is huge and monstrous! Can't you split it up into > logically independent patches: > > * configure stuff > * File dialog > * External dialog > * DO_USE_DEFAULT_LANGUAGE > * etc etc > > You might get some feedback then! > > Angus

Re: [PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread Angus Leeming
Come on, John! This is huge and monstrous! Can't you split it up into logically independent patches: * configure stuff * File dialog * External dialog * DO_USE_DEFAULT_LANGUAGE * etc etc You might get some feedback then! Angus On Friday 23 February 2001 12:46, John Levon wrote: > The not-a

[PATCH] FileDialog, FormExternal, various fixes

2001-02-23 Thread John Levon
The not-attached patch fixes all sorts of stuff, and GUIIizes the External form and FileDialog. One thing of interest is a "fix" for the FL_TRANSIENT stuff. This *should* ensure that iconified dialogs are brought back up again - at least it seems a convention that XMapWindow() has this effect. A