On Friday 23 February 2001 13:58, John Levon wrote:
> On Fri, 23 Feb 2001, Angus Leeming wrote:
>
> > Come on, John! This is huge and monstrous! Can't you split it up into
> > logically independent patches:
> >
> > * configure stuff
> > * File dialog
> > * External dialog
> > * DO_USE_DEFAULT_LANGUAGE
> > * etc etc
> >
> > You might get some feedback then!
> >
> > Angus
>
> It was half the size last week when it got ignored.
For the same reason. It's too much for mere mortals to cope with!
> I *could* just split it up but I don't see how that helps, it just makes
> 10 or so ChangeLog .rej files the applier has to clean up.
>
> It all has to be reviewed by *someone*. How does splitting it up make it
easier ?
Well different people know different bits of the code to different levels.
For example, I feel able to comment on the FileDialog stuff which looks like
you've split it up into what I'd call a Controller and a View. Why don't you
port it over to the MVC branch and we can check it out there?
Alternatively, Lars will end up having to look at everything!
Angus
