Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 16:12:09, schrieb Vincent van Ravesteijn > > The other one, "${LYX_DEST_PO}/${_gmo}", is needed in the else() part > > > > of 'if(LYX_GITVERSION) and in ADD_CUSTOM_TARGET(update-po ...) > > > > > > > > Maybe we should make two lists? > > > > You can just put the o

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 4:05 PM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 15:44:16, schrieb Vincent van Ravesteijn > > > > > > > > > > > > > And the current solution does it always. > > > > > > > > > > Yes, but it doesn't hurt. > > > > > > If you wish you can commit your patch. I on

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 15:44:16, schrieb Vincent van Ravesteijn > > > > > > And the current solution does it always. > > > > Yes, but it doesn't hurt. > > If you wish you can commit your patch. I only don't understand why in your > patch for each po-file two entries are added to LYX_UP

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 3:34 PM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 15:29:16, schrieb Vincent van Ravesteijn > > > > > > $ touch src/Buffer.cpp > > > > > > > > > $ make update-gmo > > > > > > > > > > > > > > > > > > Result: all gmo files are processed. > > > > > > > > > > > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 15:29:16, schrieb Vincent van Ravesteijn > > > $ touch src/Buffer.cpp > > > > > $ make update-gmo > > > > > > > > > > Result: all gmo files are processed. > > > > > > > > And on next call? > > > > > > > > > Vincent > > > > > > > > Kornel > > > > No, not on the nex

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 3:13 PM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 15:07:09, schrieb Vincent van Ravesteijn > > > > > > > > > > That would mean that we would need to run when the *.po (DEPENDS) > file is > > > > > > > > > newer than the *.gmo.tobeupdated (OUTPUT) files. Howev

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 15:07:09, schrieb Vincent van Ravesteijn > > > > > That would mean that we would need to run when the *.po (DEPENDS) file is > > > > > newer than the *.gmo.tobeupdated (OUTPUT) files. However we should also > > > > > depend on the *.gmo files in the build dir becau

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
> > > That would mean that we would need to run when the *.po (DEPENDS) file is > > > newer than the *.gmo.tobeupdated (OUTPUT) files. However we should also > > > depend on the *.gmo files in the build dir because these need to be > > > regenerated. However, the *.gmo files in the build dir are re

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 14:27:58, schrieb Vincent van Ravesteijn > On Tue, Feb 4, 2014 at 2:09 PM, Kornel Benko wrote: > > > Am Dienstag, 4. Februar 2014 um 14:04:00, schrieb Vincent van Ravesteijn > > > > > > > > This is always the output: > > > > > > > > > > > > ... > > > > > > > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 2:09 PM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 14:04:00, schrieb Vincent van Ravesteijn > > > > > This is always the output: > > > > > > > > ... > > > > > > > > > > What is the misbehaviour then ? It needs to do the check to find out > > > whether the gmo

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 14:04:00, schrieb Vincent van Ravesteijn > > This is always the output: > > > > ... > > > > What is the misbehaviour then ? It needs to do the check to find out > whether the gmo needs to be recreated or not. The normal way would be to for make to check if the po

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 1:25 PM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 13:09:35, schrieb Kornel Benko < > kor...@lyx.org> > > > > Well, I would like to understand the problem before committing a fix. > The > > > > only way I could reproduce is to go back a few commits, and then I

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 13:09:35, schrieb Kornel Benko > > Well, I would like to understand the problem before committing a fix. The > > only way I could reproduce is to go back a few commits, and then I see the > > files deleted. Then, updating to the latest master introduces the same > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 12:45:12, schrieb Vincent van Ravesteijn > On Tue, Feb 4, 2014 at 11:58 AM, Kornel Benko wrote: > > > Am Dienstag, 4. Februar 2014 um 11:50:38, schrieb Vincent van Ravesteijn > > > > > > > > Last (hopefully) two remarks: > > > > > > > > > > > > 1.) If a user do

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 11:58 AM, Kornel Benko wrote: > Am Dienstag, 4. Februar 2014 um 11:50:38, schrieb Vincent van Ravesteijn > > > > > Last (hopefully) two remarks: > > > > > > > > 1.) If a user does not have git-program, then he is unlikely supposed > > > > > > > > to commit gmo-file. There

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Dienstag, 4. Februar 2014 um 11:50:38, schrieb Vincent van Ravesteijn > > Last (hopefully) two remarks: > > > > 1.) If a user does not have git-program, then he is unlikely supposed > > > > to commit gmo-file. Therefore > > > > ADD_CUSTOM_TARGET(update-gmo DEPENDS ${LYX_UPDATED_GMO_FILES}) > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Vincent van Ravesteijn
On Tue, Feb 4, 2014 at 11:06 AM, Kornel Benko wrote: > Am Montag, 3. Februar 2014 um 22:32:46, schrieb Kornel Benko < > kor...@lyx.org> > > > Am Montag, 3. Februar 2014 um 22:26:49, schrieb Vincent van Ravesteijn < > v...@lyx.org> > > > > Kornel Benko schreef op 3-2-2014 22:24: > > ... > > > > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-04 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 22:32:46, schrieb Kornel Benko > Am Montag, 3. Februar 2014 um 22:26:49, schrieb Vincent van Ravesteijn > > > Kornel Benko schreef op 3-2-2014 22:24: ... > > > > > > > How do you trigger this ? In other words, what exactly do you do to > > > > > > > reconfigure ? >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 22:26:49, schrieb Vincent van Ravesteijn > Kornel Benko schreef op 3-2-2014 22:24: > > > > Am Montag, 3. Februar 2014 um 22:19:35, schrieb Vincent van Ravesteijn > > > > > > > Kornel Benko schreef op 3-2-2014 21:39: > > > > ... > > > > > > > > Fix this one. > > > >

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Vincent van Ravesteijn
Kornel Benko schreef op 3-2-2014 22:24: Am Montag, 3. Februar 2014 um 22:19:35, schrieb Vincent van Ravesteijn > Kornel Benko schreef op 3-2-2014 21:39: ... > > > > Fix this one. > > > > > > > > > > > > Do you still see the other problem ? > > > > > > > > > > No, but there is this

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 22:19:35, schrieb Vincent van Ravesteijn > Kornel Benko schreef op 3-2-2014 21:39: ... > > > > Fix this one. > > > > > > > > > > > > Do you still see the other problem ? > > > > > > > > > > No, but there is this annoying removing of *all* gmo-files with > > reconfig

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Vincent van Ravesteijn
Kornel Benko schreef op 3-2-2014 21:39: Am Montag, 3. Februar 2014 um 21:27:27, schrieb Kornel Benko > Am Montag, 3. Februar 2014 um 21:21:06, schrieb Vincent van Ravesteijn > > Kornel Benko schreef op 3-2-2014 20:58: > > > > > > Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel B

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 21:27:27, schrieb Kornel Benko > Am Montag, 3. Februar 2014 um 21:21:06, schrieb Vincent van Ravesteijn > > > Kornel Benko schreef op 3-2-2014 20:58: > > > > > > Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel Benko > > > > > > > > > > Am Montag, 3. Februar

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 21:21:06, schrieb Vincent van Ravesteijn > Kornel Benko schreef op 3-2-2014 20:58: > > > > Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel Benko > > > > > > > Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van > > Ravesteijn > > > > > > commit f63

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Vincent van Ravesteijn
Kornel Benko schreef op 3-2-2014 20:58: Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel Benko > Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van Ravesteijn > > commit f63221aba469d7a39c4775ec358d4f817b323e3a > > Author: Vincent van Ravesteijn > > Date: Mon Feb 3 17:2

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel Benko > Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van Ravesteijn > > > commit f63221aba469d7a39c4775ec358d4f817b323e3a > > Author: Vincent van Ravesteijn > > Date: Mon Feb 3 17:27:07 2014 +0100 > > > > CMake: Add target

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Vincent van Ravesteijn
Kornel Benko schreef op 3-2-2014 20:40: Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van Ravesteijn > commit f63221aba469d7a39c4775ec358d4f817b323e3a > Author: Vincent van Ravesteijn > Date: Mon Feb 3 17:27:07 2014 +0100 > > CMake: Add target update-gmo > > This t

Re: [LyX/master] CMake: Add target update-gmo

2014-02-03 Thread Kornel Benko
Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van Ravesteijn > commit f63221aba469d7a39c4775ec358d4f817b323e3a > Author: Vincent van Ravesteijn > Date: Mon Feb 3 17:27:07 2014 +0100 > > CMake: Add target update-gmo > > This target will update the gmo files if and only i