Am Dienstag, 4. Februar 2014 um 12:45:12, schrieb Vincent van Ravesteijn
<v...@lyx.org>
> On Tue, Feb 4, 2014 at 11:58 AM, Kornel Benko <kor...@lyx.org> wrote:
>
> > Am Dienstag, 4. Februar 2014 um 11:50:38, schrieb Vincent van Ravesteijn
> > <v...@lyx.org>
> >
> > > > Last (hopefully) two remarks:
> >
> > > >
> >
> > > > 1.) If a user does not have git-program, then he is unlikely supposed
> >
> > > >
> >
> > > > to commit gmo-file. Therefore
> >
> > > >
> >
> > > > ADD_CUSTOM_TARGET(update-gmo DEPENDS ${LYX_UPDATED_GMO_FILES})
> >
> > > >
> >
> > > > belongs into if(LYX_GITVERSION)
> >
> > > >
> >
> > >
> >
> > > Well, you can't say that. Someone might be using TortoiseGit instead, and
> >
> > > then we won't find the git client. If that's the case I would like to
> > offer
> >
> > > the possibility to update all gmo's, so he can at least proceed.
> >
> > >
> >
> >
> >
> > Ah, yes. Valid point.
> >
> >
> >
> > > > 2.) Same is valid for update-po target
> >
> > > >
> >
> > >
> >
> > > Same as above.
> >
> > >
> >
> >
> >
> > True.
> >
> > Still, the problem of removed gmo files remains. I want to commit at least
> > this part.
> >
>
> Well, I would like to understand the problem before committing a fix. The
> only way I could reproduce is to go back a few commits, and then I see the
> files deleted. Then, updating to the latest master introduces the same
> problem.
You are right. Cannot reproduce with recent changes.
But the fix would also correct a .. misbehaviour?
edit some po-file
use update-gmo
-> new gmo in source produced. OK
use update-gmo
-> again! new gmo in source produced. Not so OK
The
OUTPUT "${LYX_DEST_PO}/${_gmo}"
does not look OK, because the python may 'exit 0' and still not produce the gmo.
OTOH
"${CMAKE_CURRENT_BINARY_DIR}/${_gmo}.tobeupdated"
will always be produced.
> Do you have any clue what was done wrong ? The update-po target looks a bit
> the same, but doesn't show the problem.
No.
> Vincent
Kornel
signature.asc
Description: This is a digitally signed message part.
