Re: [LyX/master] CMake: Add target update-gmo

[Kornel Benko]

Am Montag, 3. Februar 2014 um 21:27:27, schrieb Kornel Benko <kor...@lyx.org>
> Am Montag, 3. Februar 2014 um 21:21:06, schrieb Vincent van Ravesteijn 
> <v...@lyx.org>
> > Kornel Benko schreef op 3-2-2014 20:58:
> > >
> > > Am Montag, 3. Februar 2014 um 20:40:29, schrieb Kornel Benko 
> > > <kor...@lyx.org>
> > >
> > > > Am Montag, 3. Februar 2014 um 20:24:40, schrieb Vincent van 
> > > Ravesteijn <v...@lyx.org>
> > >
> > > > > commit f63221aba469d7a39c4775ec358d4f817b323e3a
> > >
> > > > > Author: Vincent van Ravesteijn <v...@lyx.org>
> > >
> > > > > Date: Mon Feb 3 17:27:07 2014 +0100
> > >
> > > > >
> > >
> > > > > CMake: Add target update-gmo
> > >
> > > > >
> > >
> > > > > This target will update the gmo files if and only if the associated
> > >
> > > > > po-file is modified. To determine whether a file is modified, 'git
> > >
> > > > > status --porcelain' is used.
> > >
> > > > >
> > >
> > > > > This follows up on commit 06782542.
> > >
> > > > >
> > >
> > > >
> > >
> > > > Adding or removing a comment in po-file should not create new gmo 
> > > file IMHO.
> > >
> > > > The same for rearranging of strings.
> > >
> > > >
> > >
> > > > Using make 'update-gmo' now removes all gmo files, this does not 
> > > look OK.
> > >
> > > >
> > >
> > > One more:
> > >
> > > Manual removing a gmo-file does not trigger the re-creation with 
> > > update-gmo.
> > >
> > Fix this one.
> > 
> > Do you still see the other problem ?
> 
> No, but there is this annoying removing of *all* gmo-files with reconfigure.
> I am searching for the cause ... probably the OUTPUT keyword but I'm not sure.
> 
> > Vincent
> 

OK, what about this solution (works here):
        ...
  if(LYX_GITVERSION)
    list(APPEND LYX_UPDATED_GMO_FILES 
"${CMAKE_CURRENT_BINARY_DIR}/${_gmo}.tobeupdated")
    add_custom_command(
      OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}.tobeupdated"
          COMMAND "${LYX_GITVERSION}" "status" "--porcelain" "${_gmo_base}.po" 
">"              "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}.tobeupdated"
          COMMAND ${LYX_PYTHON_EXECUTABLE} "${TOP_CMAKE_PATH}/po/update-gmo.py" 
                "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}.tobeupdated"
                "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}"
                "${LYX_DEST_PO}/${_gmo}"
          WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
      DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}" 
"${LYX_DEST_PO}/${_gmo_base}.po"
      )
        else()
                ...

        Kornel

signature.asc
Description: This is a digitally signed message part.