On Tue, Feb 4, 2014 at 4:05 PM, Kornel Benko <kor...@lyx.org> wrote:
> Am Dienstag, 4. Februar 2014 um 15:44:16, schrieb Vincent van Ravesteijn
> <v...@lyx.org>
>
> > >
>
> > >
>
> > > And the current solution does it always.
>
> > >
>
> >
>
> > Yes, but it doesn't hurt.
>
> >
>
> > If you wish you can commit your patch. I only don't understand why in
> your
>
> > patch for each po-file two entries are added to LYX_UPDATED_GMO_FILES.
>
> >
>
>
>
> You mean the extra ${_tobeupdated}?
>
> This is needed to trigger the OUTPUT key in add_custom_command() and in
> ADD_CUSTOM_TARGET(update-gmo ...)
>
>
>
> The other one, "${LYX_DEST_PO}/${_gmo}", is needed in the else() part
>
> of 'if(LYX_GITVERSION) and in ADD_CUSTOM_TARGET(update-po ...)
>
>
>
> Maybe we should make two lists?
>
You can just put the other one also in the else() part.
>
>
> Another catch: Since "${CMAKE_CURRENT_BINARY_DIR}/${_gmo}" already depends
> on "${LYX_DEST_PO}/${_gmo_base}.po"
>
> the second one is not needed for the DEPEND key.
>
>
>
>
Ok.
Vincent
