Re: Key board based horizontal scrolling

2013-09-30 Thread Hashini Senaratne
Hello Jean-Marc, > Hello Hashini, > > I think the problem is just SingleParUpdate vs FullScreenUpdate. Try the > attached patch. Really sorry for the late reply. I tried this but it seems like not working properly. Now the content that we are adding or deleting are not visible, while adding and

Re: Key board based horizontal scrolling

2013-09-22 Thread Hashini Senaratne
> Try using "git blame src/insets/InsetTabular.cpp" to know at what commit each line of code has been added/modified. Google can tell you how to play detective with that command > I am surprised though. What is the problem ? Thanks. I will try with that. As I see, void InsetTabular::cursorPos i

Re: Key board based horizontal scrolling

2013-09-21 Thread Hashini Senaratne
Hello Jean-Marc, > Your commit log is pretty good. See a few comments below. Thank you for reviewing it. Is there a way to get the full patch for half-back solution for insetTabular? I tried fing in the Bug Tracker, but could not. It seems like disabling resetPos(...) and scx_x is not completely

Re: Key board based horizontal scrolling

2013-09-21 Thread Hashini Senaratne
Dear Jean-Marc, > Here is as promised a patch concerning vertical scrolling. If it works > correctly, please remoce Cursor::bottomRow, which is not needed anymore. > > What the patch does is to test whether a row exists before reading it. > This avoid strange changes in rows that in turn confu

Re: Key board based horizontal scrolling

2013-09-20 Thread Hashini Senaratne
Hello Jean-Marc, > Fine. Do you know how to use "git commit --amend" (for updating commit) > and "git format-patch" (to send commit via e-mail)? Send it tomorrow if > you can, I cannot be sure I will have time this week end (family > pressure...). I have used git commit --amend but not git for

Re: Key board based horizontal scrolling

2013-09-19 Thread Hashini Senaratne
Hello Jean-Marc, > Yes, resetting all the changes that are there for now. In this commit: http://git.lyx.org/?p=gsoc.git;a=commitdiff;h=72ae4610ffabf6b8c974b3af3b8d19c39de9e6c6 I tried to resolve the differences compared to origin/master. Now the statistics are as follows. BufferView.cpp

Re: Key board based horizontal scrolling

2013-09-18 Thread Hashini Senaratne
Hello Jean-Marc, > - create a nice and tidy scroll/master repo with a few commits, or maybe > one for where we are now and one for removing insettabulat special code > once you got it right in testing. Did you mean deleting current scroll/master and recreate one? > I prefer the later option. T

Re: LyX unit testing

2013-09-18 Thread Hashini Senaratne
Hello Vincent, > But in general, I would like to introduce unit testing, yes. > Currently, is there any guide that I can follow, how the suggested testframe work can be set to the LyX environment? Thanks Hashini

Re: Key board based horizontal scrolling

2013-09-16 Thread Hashini Senaratne
Hello Jean-Marc, > Is it still the case with my latest patch? I checked and it seems not. So, I think I have to remove my temporal patch and rearrange the code according to your suggested patch in the other message. I will try testing with that. > We also have to think about how to prepare this

Re: Key board based horizontal scrolling

2013-09-16 Thread Hashini Senaratne
Hello Jean-Marc, > Have a look at the updated patch below that implements the new way of > identifying rows. It seems to work in my limited testing. I think this solves the problem. I will do more testing tomorrow. A little weird thing happened. When I go down in the document and coming back to

Re: Key board based horizontal scrolling

2013-09-15 Thread Hashini Senaratne
Hello Jean-Marc, > I checked the current implementation with too wide tables by commenting the > content in void InsetTabular::resetPos(Cursor & cur) const. It seems to work > with tables, but the proper behaviour seems to appearing with fullpaint updates. I think I am incorrect at the above ment

Re: Key board based horizontal scrolling

2013-09-15 Thread Hashini Senaratne
Hello Jean-Marc, > What may happen is that DecorationUpdate redraw is triggerred when > moving the mouse. In this case, the rows would be recretated and change > value. > > A way to avoid that would be to remember the position of the start of > the row (a cursor slice pointing at the first cha

Re: Key board based horizontal scrolling

2013-09-15 Thread Hashini Senaratne
Hi Scott, > I know nothing about this. Can you send an email to lyx-devel and > Vincent asking these questions? I would be interested to find out the > answer as well. Ok, I too followed this http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg180430.html. But could not find the correct proce

Re: Key board based horizontal scrolling

2013-09-15 Thread Hashini Senaratne
Hello Jean-Marc, > Thank you. I tried this. Even it solves above mentioned problem (unwanted > sliding when moving from the rightmost position of the math inset to the > below row, using right arrow), again it is not working for the mouse pointer > selections within the row. However it is good to

Re: Key board based horizontal scrolling

2013-09-14 Thread Hashini Senaratne
Hello Jean-Marc, > > Le 12/09/13 08:53, Hashini Senaratne a écrit : > > I tried with removing this. If you also try that, you will see that the it > > will introduce an abnormal behaviour when moving from the rightmost position > > of the math inset to the below row

Re: Key board based horizontal scrolling

2013-09-14 Thread Hashini Senaratne
Hi Scott, > This might not be relevant, but have you tested with a right-to-left > language? "moving away" might mean the opposite there. I have not check. But I think moving away from a row is independent from the language. I did not get your point. > This would be great. I'm very interested

Re: Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, > I think this behavior (of Cursor::bottomRow) is fixed in the attached > commit. I also reverted some of the workarounds that you introduced. > Please test and commit if it is satisfying. I test this patch and committed to the repository. Moreover I deleted the setLeftEdge(0)

Re: Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, > 1/ In checkCursorLeftEdge, you introduce a new bool row_need_slide that > in my mind is equivalent to the old test "left_edge != > cur.getLeftEdge()", since the goal is to know whether the row needs to > be repainted. Does the new form make a difference? > > I am OK with the

Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, Now it seems like most of the bugs are fixed with keyboard based solution. *Selecting a different position in an already slid row *Selecting a range of text in an already slid row *Behaviour related to Home and End keys Above features seems to work well in this commit: http://gi

Re: Reviews of commits

2013-09-10 Thread Hashini Senaratne
Hello Jean-Marc, > > 1) When moving from the left most position of a row to the above too wide > > row using left arrow, row does not get slide. (I think I found a fix for > > this, have to test more) > > Here is what I observe: > https://dl.dropboxusercontent.com/u/105510128/Bug_2.webm Did you

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > Identified another two bugs... > 1) When moving from the left most position of a row to the above too wide > row using left arrow, row does not get slide. (I think I found a fix for > this, have to test more) Here is what I observe: https://dl.dropboxusercontent.com/u/105510128

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > > RowPainter rp(pi, bv.buffer().text(), cur.bottom().pit(), row, bidi, 0, > > - rp.paintOnlyInsets(); > > + //rp.paintOnlyInsets(); > > + rp.paintText(); > > I think you are right. It might also be that we should use both. For now I put only rp.paint

Re: Why bv.getPos(cur).x_ not always giving correct x position of the text cursor?

2013-09-07 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > > What happens is, the above attribute resets to the left most cursor position > > of that row. And after few mouse movements, it gives the correct value. > > These mouse movements calls drawing method of TextMetrics.cpp. > > I think that mouse movement c

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > Le 06/09/13 13:07, Hashini Senaratne a écrit : I do not know whether this is a goo new or not. But with the following fix I could solve that problem. diff --git a/src/BufferView.cpp b/src/BufferView.cpp index c53fd1d..1dc8f51 100644 --- a/src/BufferView.cpp +++ b/

Why bv.getPos(cur).x_ not always giving correct x position of the text cursor?

2013-09-07 Thread Hashini Senaratne
Hi all, I am recently involved in horizontal scrolling of rows where I work with Math insets. There I found that bv.getPos(cur).x_ is not getting updated just after entering a Math inset from left or right corners. What happens is, the above attribute resets to the left most cursor position of t

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > * Recompute inset positions before checking row left edge, by > painting the row insets with drawing disabled. > > Corresponding change is: > > + // Force the recomputation of inset positions > + bool const drawing = pi.pain.isDrawingEnabled(); > + pi.p

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > > I tried both of the above patches that you have sent me. But nothing was > > able to solve the problem I mentioned. (When entering Math inset from right > > edge, row slides unexpectedly to the left most position.) However bellow > > code solved the above mentioned problem. >

Re: Reviews of commits

2013-09-06 Thread Hashini Senaratne
Hello Jean-Marc, > > Unfortunately, this code exists to avoid painting too much stuff, so we > > have to cope with it. We cannot afford to repaint the whole screen every > > time the user moves the cursor, it can be really horrible, especially on > > Mac OS X. I will try to post a patch tomorrow i

Re: Reviews of commits

2013-08-30 Thread Hashini Senaratne
Hello Jean-Marc, Hope you returned safely. > > It seems to me, I have not clearly understood this matter till now. I doubt > > how we can call rp.drawOnlyInsets(...); before left_edge computations, as we > > are only creating the RowPainter object after those calculations. > > See my other mess

Re: Row by Row sliding

2013-08-24 Thread Hashini Senaratne
Hello Jean-Marc, > I think I know why this happens: have a look at this comment taken from > coordCache.h: > > /** > * A BufferView dependent cache that allows us to come from an inset in > * a document to a position point and dimension on the screen. > * The individual points are added a

Re: Reviews of commits

2013-08-24 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > PainterInfo is defined in src/MetricsInfo.h. "git grep" is your friend > to find this kind of information. Thank you. Got it. > > Did you notice > > that the size of the vertical scroll bar changes when we come into the too > > wide math equation, from a

Re: Reviews of commits

2013-08-21 Thread Hashini Senaratne
Hello Jean-Marc, > I am now back from vacation for a week and took the time to review the > current code and change it according to the ideas that we have discussed > in July. It strikes me as a better way to state my ideas (and was also a > good way to understand what ideas do not work...). N

Re: Row by Row sliding (review of

2013-08-05 Thread Hashini Senaratne
Hello Jean-Marc, > +++ b/src/Cursor.cpp > -278,7 +278,7 CursorData::CursorData(DocIterator const & dit) > // bv functions are not yet available! > Cursor::Cursor(BufferView & bv) > : CursorData(&bv.buffer()), bv_(&bv), > - x_target_(-1), textTargetOffset_(0) > +

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-05 Thread Hashini Senaratne
Hello Jean-Marc, > > I continue my backwards visit of history. Although I posted some replies to mailing list last week, they do not seems to appear to the outside yet. So I am re-sending those replies. I carefully followed your reviews and modified the code accordingly. Your comments on them we

Re: Row by Row sliding (review of

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > +++ b/src/Cursor.cpp > -278,7 +278,7 CursorData::CursorData(DocIterator const & dit) > // bv functions are not yet available! > Cursor::Cursor(BufferView & bv) > : CursorData(&bv.buffer()), bv_(&bv), > - x_target_(-1), textTargetOffset_(0) > +

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > > I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. > I forgot a couple of remarks in this commit. > > - RowPainter rp(pi, *text_, pit, row, bidi, x, y); > +

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > > I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. > I forgot a couple of remarks in this commit. > > - RowPainter rp(pi, *text_, pit, row, bidi, x, y); > +

Re: Row by Row sliding

2013-07-22 Thread Hashini Senaratne
Hello Jean-Marc, > > When the row slid to a wrong position (say when entering from right corner > > leftedge is set to 10 pix unexpectedly); if I move the mouse pointer in to > > and out of the document window; without any key pressing position resets to > > the current position. So we only need t

Re: Row by Row sliding

2013-07-22 Thread Hashini Senaratne
Hello Jean-Marc, > I see it too, it is very strange. However, I think the problem is > different, because it does not require to go out of the equation. You do > not see it because (strangely) your test case contains a math equation > in a Title layout[1] and thus with large character. Now take

Re: Row by Row sliding

2013-07-22 Thread Hashini Senaratne
Hello Jean-Marc, > I tried to fix this and found that this happens because cur_x variable do > mot get updates as expected. I save bv.getPos(cur).x_ to cur_x, as I > discussed with you earlier. But my previous observation seems to be wrong > when compared to cur.targetX(). I tried with cur.targetX

Re: License Details for GSoC Project: Horizontal scrollbar for tables and math for LyX

2013-07-21 Thread Hashini Senaratne
Modification for Licensing: I hereby grant permission to license my contributions to LyX under the GNU General Public License, version 2 or later. Thank you Hashini Senaratne

Re: Row by Row sliding

2013-07-21 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > This works very well! A small nit: when cursor goes to rith right at the > end of the visible row, it goes backwards and the forwards. The &0px > correction should maybe be applied also to the cursor position when not > at the real end of the row. I tri

License Details for GSoC Project: Horizontal scrollbar for tables and math for LyX

2013-07-21 Thread Hashini Senaratne
My work will be released under open source license, GPL 3.0. as I agrees with Google Summer of Code 2013. So my contributions to LyX are licensed under GPL v3. *Thank you * *Hashini Senaratne *

Re: Row by Row sliding

2013-07-16 Thread Hashini Senaratne
Hello Jean-Marc, Lasgouttes lyx.org> writes: > >> What do you mean by "cursor positions"? > > > > The position where the text-cursor seems to be appear. I have to edit it as > > the next step. > > OK. > Tried to update the text cursor position accordingly: http://git.lyx.org/?p=gsoc.git;a=com

Re: Row by Row sliding

2013-07-15 Thread Hashini Senaratne
Hello Jean-Marc, >What do you mean by "cursor positions"? The position where the text-cursor seems to be appear. I have to edit it as the next step. >Something very weird: when moving in the long formula, the >"Math-Formula" title moves, whereas it should not. I tried to debug >this, but do no

Re: Row by Row sliding

2013-07-12 Thread Hashini Senaratne
Hi Jean-Marc, > The important thing is to know what is the row that you have decided to > slide. This is why you have defined (set|get)ToowideRow, isn't it? Why > don't you use these methods? Thank you. I implemented the basic sliding functionality in order to slide a single row, according to

Re: Row by Row sliding

2013-07-12 Thread Hashini Senaratne
Hi Jean-Marc > I hope you found your way out of this problem. Otherwise tomorrow I will comment on your patch and give advice. > I think I found the pr > oblem. That is because in the for loop I am updatingthe left edge all the time. I will try to correct it. Although I found the reason, I am s

Re: Row by Row sliding

2013-07-11 Thread Hashini Senaratne
Hello Jean-Marc, > But at the moment I am stuck at a point. In my last comment, I wrote a > general algorithm. According to that all the rows should slide. But what I > am getting is, sliding of a non relevant row. > http://git.lyx.org/?p=gsoc.git;a=commitdiff;h=18447e084037ef29b37f8bc938dc84f1a8

Re: Row by Row sliding

2013-07-11 Thread Hashini Senaratne
Hello Jean-Marc, > I am not sure what you have in mind, but I think that you should not > worry about that. The right place for setting the row offset (or > whatever name you give to it) is when the screen is about to get drawn > (BufferView::draw). It is not necessary to track all the places

Re: Row by Row sliding

2013-07-01 Thread Hashini Senaratne
Hello Jean-Marc, > I am not sure we undertand each other: in my mind, this "offset" is > indeed the amount of horizontal pixel by which the row has been slid. > That is, instead of drawing the part of the row that goes from 0 to > window_width, LyX will draw the part between offset and > offse

Re: Row by Row sliding

2013-06-29 Thread Hashini Senaratne
Hello Jean-Marc, > This is why I proposed that the row (or the cursor) remembers the > current offset and only changes it if is is not suitable. See one of my > previous mails. I think this not-suitability cannot decide only with this offset attribute. As proceeds I figured out that only using

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > There is a mechanism to avoid drawing rows when they are unchanged. Look > for this code in drawParagrph: > > // Row signature; has row changed since last paint? > row.setCrc(pm.computeRowSignature(row, bparams)); > bool row_has_change

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > OK, what about using TexMetrics::cursorX() or maybe > BufferView::getPos()? The later is what is called by setTargetX. Nothing that work. I think the reason is when the cursor moves along a row as a result of key board presses of arrow keys, drawparagraph

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > > You can use setTargetX() to force a recomputation. Does this work? > > > > Sorry that did not work. > > I am using this within drawparagraph() of TextMetrics. As setTargetX() is > not a const method, I cannot call it as cur.setTargetX(). So I defined > another non- cnstant

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > > Le 26/06/2013 08:45, Hashini Senaratne a écrit : > > Hello Jean-Marc, > > > >> * A Cursor is a descendant of CursorData that contains interesting > >> display-related information, in particular targetX(), the horizontal > >>

Re: Row by Row sliding

2013-06-25 Thread Hashini Senaratne
Hello Jean-Marc, > * A Cursor is a descendant of CursorData that contains interesting > display-related information, in particular targetX(), the horizontal > position of the cursor in pixels. I checked targetX() and it only gets changed when the cursor is moving along a Math equation. To ment

Re: Row by Row sliding

2013-06-24 Thread Hashini Senaratne
Hello Jean-Marc, > Does this look like a plan? Please do not hesitate to ask me if some > parts are not clear. You have explained me a lot of things that I do not know properly. Thank you and I will ask questions while I proceed. I am sure that I will have a lot of questions. Thank you Hashini

Re: Row by Row sliding

2013-06-23 Thread Hashini Senaratne
Hello Jean-Marc, > I read on the wiki page that you had issue pushing some code. On what > branch are you working? I cannot find your code. Being able to run your > code would help me to see what are your problems and try to help. I am pushing on the branch called scroll/testing. You can view t

Re: Row by Row sliding

2013-06-23 Thread Hashini Senaratne
Hello Jean-Marc > > I suspect this is not going to work when you want to set cursor by mouse on a slided row. I think the offset information shall be in bufferview as Richard said. I tried it already; but still having some problems. Will continue on working and report back when I come to a st

Re: Row by Row sliding

2013-06-21 Thread Hashini Senaratne
Hello Richard, > I think this is in the GuiWorkArea::Private::showCursor() routine. The > place to put the cursor gets calculated there, and then passed to > another showCursor(...) routine. That information is retrieved, however, > from BufferView::cursorPosAndHeight(), so the thing to do mig

Re: Row by Row sliding

2013-06-21 Thread Hashini Senaratne
Thank you for this information; Jean-Marc Lasgouttes & Richard > > Yes, only the visible cursor point is not at the correct place. I can delete > > or add characters to where I expect. > > Is this blink code is in Cursor.cpp or somewhere related to graphics? I > > tried to find it but failed. > >

Re: Row by Row sliding

2013-06-21 Thread Hashini Senaratne
Hello Jean-Mark , Pavel & Scott Yes, I will try to document the areas where I will go through. Thank you Hashini

Re: Row by Row sliding

2013-06-19 Thread Hashini Senaratne
> The code that draws the cursor does not know that you have moved the > row, so I aimgaine it will be wrong. What I would do maybe is to add a > x_offset (or something) variable to the Cursor object that indicates > that the row is sliding. Then the cursor-blink code could take this in > accou

Re: Row by Row sliding

2013-06-19 Thread Hashini Senaratne
Hello Jean-Marc, > I tested what you have given and that helped me to understand more. Today I > did more testing and realized that cur.pos() is not related with pixels and > this approach cannot be used as a generic solution. > > Problems: > *I checked the cur.pos() values inside a tabular inse

Re: Row by Row sliding

2013-06-19 Thread Hashini Senaratne
Hello Jean-Marc, > You have to check that you are in the correct paragraph. pos is the > position in the paragraph. The index of the paragraph is "pit" (the same > that is passed to RowPainter constructor). Thus the test should be > > if (cur.pos() >0 && cur.pit() == pit) > > This will however

Row by Row sliding

2013-06-17 Thread Hashini Senaratne
Hello All, When I replace the line; RowPainter rp(pi, *text_, pit, row, bidi, x, y); in TextMetrics.cpp with following few lines: int inc_x=x; if(cur.pos()>0) inc_x-=100; RowPainter rp(pi, *text_, pit, row, bidi, inc_x, y); what I expected was; when I move the cursor using right arrow beginni

Re: GSoC : Horizontal scrollbar

2013-06-16 Thread Hashini Senaratne
Hello Jean-Marc, >From today onwards I will work on this project during following time periods. State in UTC. 23:30 (previous day)-1:30 and 14:30 - 17:30 (Monday, Tuesday, Thursday, Friday) : in these days I will be able to find few more hours (around 2) in between 3:30 - 13:30 (5 for sure + 2 or

Re: GSoC : Horizontal scrollbar

2013-06-12 Thread Hashini Senaratne
Hello Jean-Marc, > Yes, putting the documents in an extra directory is probably the best > thing to do. I'd create a directory under development to hold these > files. When the time comes to merge into master, we'll see what to do > with these files. Richard add my key to the list of student k

Re: GSoC : Horizontal scrollbar

2013-06-12 Thread Hashini Senaratne
Richard, > Do you know how to create a public-private keypair? If so, please > send me your public key, to rgheck lyx.org, and I will add it to the > list of student keys for the GSoC repository. You will then be able > to commit your work to feature branches in the gsoc repositor

Re: GSoC : Horizontal scrollbar

2013-06-11 Thread Hashini Senaratne
Dear Jean-Marc, I hope to start the initial work from tomorrow as I am done with my exams. I already started to go through the features of LyX and hope to make use of them as much as possible. I hope that will help to understand how the insets are working and how they will affect this implementat

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
> Another example is that one can add code in any inset, like explicit > LaTeX code (so-called ERT) or R/Sweave code (R is a statistical package > and Sweave allows to include R code in a document). Of course, this code > will not appear in printed output, but on screen it can use a lot of space

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
> You can insert graphics by Insert > graphics. There are less issues > with oversized images, as you can right click on image then Settings > > LyX Options > Scale on screen > 10%. This way you can change the way > an image looks on screen without modifying teh way it looks in the > output PDF. T

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
Dear Cyrille, > When editing, we also don't want to worry too much about the size of the > final output. LyX allows you to enter the content first, and let LaTeX > take care of the layout. At the end you can fine-tune the output if > necessary (by reducing the font size, for example). Thank yo

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
Dear Jean-Marc, > Forget about that. Richard already created the page > http://wiki.lyx.org/GSoC.HorizontalScrollbar, alongside with the other > two projects. I delete the above page. Thank you for creating a wiki page. I will edit that sooner. I hope to document about the progress about the p

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
Hi Scott, > Fortunately for you, I'm no longer one of your mentors. This doesn't > really change anything on my side. If you have any questions that I'm > able to answer, I'd be very happy to do so. I thought both of you will remain as the mentors. Thank you for advising on this project. > I do

Re: GSoC : Horizontal scrollbar

2013-05-31 Thread Hashini Senaratne
> I think that both global and local scrolling with cursor are easy to > implement (even global scrollbar is easy IMO). We should indeed try both. I am also a bit confused with what to implement; a set of local scroll features or a global scroll feature. I think it is better to try both of them a

GSoC : Horizontal scrollbar

2013-05-27 Thread Hashini Senaratne
Hello all, I am glad to hear that my proposal "Horizontal scrollbar for tables and math for LyX" submitted has been accepted for Google Summer of Code 2013. Thank you (all the developers and specially my two mentors; Jean and Scott) very much for helping me by providing advice and relevant deta

Re: Interested in GSOC Project:

2013-05-11 Thread Hashini Senaratne
Hello Tommaso, > Just while we're at it, can't we also have an inset-specific vertical scrolling feature ? > > Shortly, instead of the boolean expanded/collapsed insert, also allow for a third scrollable state where > I show just a part of it, with the possibility to drag the size of the par

Re: Interested in GSOC Project:

2013-04-25 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > To be frank, I do not know. Sometimes (I will write about it in another > thread to vary a bit) I think that an horizontal scrollbar for the whole > workarea would actually be enough (but anyway the effect should be > obtained through changes to TextMetri

Re: Interested in GSOC Project:

2013-04-23 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > What I would try personally is to look at TextMetrics::drawParagraph > (TextMetrics.cpp). There, you can test whether the cursor is in the row > one wants to paint, and whether its x_pos() is too large for the screen. > In this case you can, as a first ex

Re: Interested in GSOC Project:

2013-04-23 Thread Hashini Senaratne
Scott Kostyshak lyx.org> writes: > I think it is best not to duplicate conversations. People on this list > generally find what's meant for them. If they don't, feel free to bump > the email after a few days and explicitly CC them. Thank you Scott. I got your advice and hope to work with the appl

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-21 Thread Hashini Senaratne
Hello Liviu, Liviu Andronic gmail.com> writes: > > Dear Hashini, > I think best would be to wait for Google Melange to open its > applications system to students, in about a day or so. Then you could > start preparing a first draft of your application there, and mentors > could give you feedback

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-21 Thread Hashini Senaratne
Hello Jean, I was trying to sliding too long Labels for the past few days. I was able to learn many new things about painting methods and still interested to proceed with this project. After figuring out how the partial slides of current tables have been implemented (using the method void Inset

Re: Interested in GSOC Project:

2013-04-21 Thread Hashini Senaratne
Hello Scott, I was trying to sliding too long Labels for the past few days. I was able to learn many new things about painting methods and still interested to proceed with this project. After figuring out how the partial slides of current tables have been implemented (using the method void Inse

Re: JASA.lyx: Error in latexParagraphs: You should not mix title layouts with normal ones.

2013-04-16 Thread Hashini Senaratne
Scott Kostyshak lyx.org> writes: > output_latex.cpp (): Error in latexParagraphs: You should not > mix title layouts with normal ones. > > Thanks to Hashini Senaratne for narrowing down the problem. > --- > lib/layouts/jasatex.layout |1 + > 1 file changed,

Re: JASA.lyx: Error in latexParagraphs: You should not mix title layouts with normal ones.

2013-04-15 Thread Hashini Senaratne
Hello Scott, Scott Kostyshak lyx.org> writes: > I get the following error when exporting templates/JASA.lyx: > output_latex.cpp (): Error in latexParagraphs: You should not mix > title layouts with normal ones. > > Is there something in the layout that needs fixing? > As you know I am new

Problems regarding attempts to slide insets horizontally

2013-04-14 Thread Hashini Senaratne
Hello all, I have figured out that the code responsible for sliding the tables partially (to give a solution to too large tables) under InsetTabulartables.cpp.If I have correctly identified, this code lies within the method void InsetTabular::resetPos(Cursor & cur) const. Please correct me if it i

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-14 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > > Could you please explain it to me? > > It would look like: > > 1/ implement the function slide_row_by__amount_xx (I do not know in what > unit the xx should be). > > 2/ when the test cursor is moved to a place where it would not be > visible, move a b

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-14 Thread Hashini Senaratne
Scott Kostyshak lyx.org> writes: > OK, sounds good. I will go through my disorganized dump of notes this > weekend and write up some descriptions of minor bugs. I'm sure I have > something related to UI, but not sure how related to the part of UI > you will need for the project. Then you can see i

Re: Interested in GSOC Project:

2013-04-12 Thread Hashini Senaratne
Hello Pavel, Pavel Sanda lyx.org> writes: > Bingo, they are no way related to QT and I suspect they had .ui extension > before LyX had QT graphical frontend at all. > We do the layout manually in the code, search for strings like menu, toolbar > or shortcut in the code :) Thank you Pavel for the

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-12 Thread Hashini Senaratne
Hello Jean, Jean-Marc Lasgouttes lyx.org> writes: > > If we are going to implement the buttons, I think we need to indent a slight > > amount horizontally for one click? Is that the same idea that had in your > > mind? If the click on this button, shows us the end (edge) of the object, > > that

Re: Interested in GSOC Project:

2013-04-12 Thread Hashini Senaratne
Hello Cyrille, Cyrille Artho aist.go.jp> writes: > > > * have buttons with arrows in the left and right margin or (since > these margins are currently thin) maybe buttons that appear as > needed when the mouse if over the problematic inset. > >>> > >>> I think this option will not

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-12 Thread Hashini Senaratne
Hello Scott, Scott Kostyshak lyx.org> writes: > Commenting out lines of code sounds like a great technique for > learning. I had never thought about that! That was because I am new to this and could not identified specific places with related code. I will promise you that I will improve on this.

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-11 Thread Hashini Senaratne
Hello again, Hashini Senaratne gmail.com> writes: > Today I installed QT4 development tools and the QT4 designer. I could open > all the files in /src/frontends/qt4/ui by using the designer. But I failed > to open two files using qt4 designer; > /development/attic/lyxled/ui/

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-11 Thread Hashini Senaratne
Hello Scott, Scott Kostyshak lyx.org> writes: > > On Wed, Apr 10, 2013 at 3:07 AM, Hashini Senaratne gmail.com> wrote: > > If you have some time could you please give me some more details about > > autotools that you are aware of, later. I do not want to keep on d

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-11 Thread Hashini Senaratne
Hello Jean, Jean-Marc Lasgouttes lyx.org> writes: > I am not competent at all when it comes to Qt, but I suuspect that a lot > of work will be needed in our WorkArea widget to have it aware that it > contains other Qt widgets (the scrollbars) and pass the needed messages > (process paint events.

Re: Introduction

2013-04-10 Thread Hashini Senaratne
ce and still have not started work with any ticket. Hope you will get more problem specific bugs from the mentors. Thank you Hashini Senaratne

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-10 Thread Hashini Senaratne
"Is not it possible to implement to have a horizontal scrollbar (real scrollbar) like the vertical scrollbar at the bottom of the working area. But it only gets appear when the cursor enters a too wide area (too wide table, too wide equation). And by scrolling this horizontal scrollbar, only the above mentioned too wide area will get scrolled horizontally." Thank you Hashini Senaratne

Re: Interested in GSOC Project:

2013-04-10 Thread Hashini Senaratne
t feels like one). > Thank you for the idea of having visual feedbacks. Currently what I can think about is a pop up window that gives some warnings about the cut off sections in the output. I will think about it further and contact you for further advices. Thank you Hashini Senaratne Liviu A

Re: Interested in GSOC Project: "Horizontal scrollbar for tables and math" and Some problems regarding the project

2013-04-10 Thread Hashini Senaratne
> If you're looking for easy targets then search for 'easyfix' on the > bug tracker. > Thank you very much for the guide. Initially I will try to understand the source code and hope to work on few tickets to familiar with LyX more. Thank you Hashini Senaratne

  1   2   >