Hello Jean-Marc, > - create a nice and tidy scroll/master repo with a few commits, or maybe > one for where we are now and one for removing insettabulat special code > once you got it right in testing.
Did you mean deleting current scroll/master and recreate one? > I prefer the later option. The code for scrolling was very difficult to > get right, but the fact is that current changes are not that large: > > fantomas (scroll/testing): git diff origin/master src |diffstat > BufferView.cpp | 66 > +++++++++++++++++++++++++++++++++++++++-- > Cursor.cpp | 58 +++++++++++++++++++++++++++++++++++- > Cursor.h | 67 > ++++++++++++++++-------------------------- > CursorSlice.h | 2 + > TextMetrics.cpp | 22 +++++++++++-- > frontends/qt4/GuiWorkArea.cpp | 9 +++++ > mathed/InsetMathHull.cpp | 2 - > 7 files changed, 174 insertions(+), 52 deletions(-) > > In the count above there are a few changes that are wrong, probably > because we forget to rebase some stuff, I am not sure actually. > > You should first review this diff and understand what should be fixed. > For example, there is in origin/master a chunk of comments in Cursor.h > coming from a description I did which is not in gsoc/scroll/master. You > should re-add it I am not sure what happened. Also the changes in > mathed/InsetMathHull.cpp should not be there. There are a couple (one) > other example that does not look correct. I am working on this. I was trying to figure out what has happened with vertical scrolling. This problem has remained for a long time as I can see. The first point this introduced was when using, if (&cur.textRow() == &row) What happens is what is doing inside cur.textRow() affects the vertical scrolling. Will you be able to give me some hints? I think this bug make the implementation of horrizontal scrolling worthless. Thank you. Hashini
