Hello Jean-Marc, > I am now back from vacation for a week and took the time to review the > current code and change it according to the ideas that we have discussed > in July. It strikes me as a better way to state my ideas (and was also a > good way to understand what ideas do not work...).
Nice to see you back again. As you asked me to change the cursor that we use in TextMetrics.cpp to non-constant by using the non-constant cursor of PainterInfo I tried to find information about that. 'In particular in pi you have pi.bv, which is a pointer to the buffer view. Therefore you can change the definition of cur to Cursor & cur = pi.bv.cursor();' But this gave compilation errors. And I could not find any class named PainterInfo in the repository. Why is that? > With these changes, I see less problematic cases. There is still > something related to target_x that has to be sorted out. > > Could you please make sure that you understand what I do there, discuss > what you do not like/understand and then commit the corresponding patch? I tried your patch and that works fine when changing rows. Did you notice that the size of the vertical scroll bar changes when we come into the too wide math equation, from another row? I do not think that is not a bug appeared at this moment. But as I can see it came from the previous versions. I have no idea why that is happening. I committed this patch. Tomorrow I will learn more about it and raise questions. Thank you for guiding me. > Then it will be time to make a list of the remaining things to do about > keyboard navigation. *fixing the wrong sliding when entering from either right or left corner of a Math inset. *fixing the wrong sliding happens when selecting positions or range of text in a too wide row using mouse pointer/ cursor. (related to the above problem) *implement the sliding needed when using Home/End keys. > PS: could you please commit the missing wide_image used in your > changesNeeded.lyx test files? Shall I commit that to the same folder? But I would not be able to give a relative address directing that picture in the LyX document. Thank you Hashini
