[PATCH] move row for tabular

2012-12-07 Thread Scott Kostyshak
This patch implements a "move row" feature for tabular. The purpose is to provide a useful behavior in tabular that is consistent with PARAGRAPH_MOVE_UP and PARAGRAPH_MOVE_DOWN so that the user can do, for example, alt- to move a row up. If there is any selection, the LFUN is disabled. This is con

[PATCH] delete row/column patch

2012-12-07 Thread Scott Kostyshak
The attached patch is based on a patch sent by Zahari Dimitrov in this email: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg172590.html I have tested it. Can it go in to trunk? Should he send a GPL statement? Thanks, Scott From 317e78f5d70fc926da3fb01b0e443f7ded2e0e1f Mon Sep 17 00:00:

[PATCH] fix three selection bugs in tabular

2012-12-07 Thread Scott Kostyshak
Attached are three patches which fix selection bugs in tabular. I have a feeling that I am cheating by throwing in "cur.screenUpdateFlags(Update::Force | Update::FitCursor);" in a few places. Doing so does fix the bugs but I'm thinking I'm being wasteful by not attacking the problem at its root. An

[PATCH] Remove a FIXME in InsetTabular

2012-12-07 Thread Scott Kostyshak
>From my interpretation, the FIXME in the attached patch (added in 2009 by Vincent) is now satisfied and we can remove the !empty_cell from the condition. Is that correct or did I misunderstand something? Thanks, Scott From 80a114b3f47b768a4763fac1b7f1408ed7433fe6 Mon Sep 17 00:00:00 2001 From: S

Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-07 Thread Scott Kostyshak
I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. - Enter "a". - Undo twice, then redo twice, then undo once. I get a SIGSEGV. I can also reproduce wit

[PATCH] InsetTabular code cleanup

2012-12-07 Thread Scott Kostyshak
While studying InsetTabular{.cpp,.h}, I have some suggestions and questions. In the 0001 patch attached, am I missing something or can we remove cur.selection in the conditions? In 0003, can I rename "copy-column" and "copy-row" to "duplicate-column" and "duplicate-row"? The features do not just

Expected behavior of "set bottom line" in tabular?

2012-12-07 Thread Scott Kostyshak
Below I describe two situations which surprised me and I'm not sure what the expected behavior should be. Situation 1: - Start a new table, say 4x4. - Click on a cell in the second-to-last row. - Click the "set bottom line" button in the toolbar. Nothing happens. Repeating the above but doing "s

Re: [patch] final layout patches for branch

2012-12-07 Thread Georg Baum
Uwe Stöhr wrote: > Am 06.12.2012 21:21, schrieb Georg Baum: > >> Definitely. One big advantage of LyX is that you do not need to think if >> you switch between minor point releases. > > But who does this? > Have you have downgraded your LyX from e.g. 1.6.8 back to 1.6.3? That > doesn't make sens

Re: Any way to have custom inset labels always displayed?

2012-12-07 Thread Richard Heck
On 12/07/2012 09:10 AM, Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: 2012/12/4 Jean-Marc Lasgouttes : Or we could always insert them opened. I would not object. Jürgen JMarc I'll do that change in trunk if I hear no objections. This looks like a good idea to me. rh

[DECISION] final layout patches for branch

2012-12-07 Thread Richard Heck
After all of this discussion, it seems to me that the consensus is that we should not make major changes to layout files for minor releases. I understand Uwe's reasons for wanting to do so, but it will break a lot of documents for people whose machines do not automatically update when new cla

Re: [patch] final layout patches for branch

2012-12-07 Thread Richard Heck
On 12/07/2012 04:03 AM, Jean-Marc Lasgouttes wrote: Le 07/12/2012 00:13, Uwe Stöhr a écrit : Am 06.12.2012 21:21, schrieb Georg Baum: Definitely. One big advantage of LyX is that you do not need to think if you switch between minor point releases. But who does this? Have you have downgraded

Re: Any way to have custom inset labels always displayed?

2012-12-07 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > 2012/12/4 Jean-Marc Lasgouttes : > > Or we could always insert them opened. > > I would not object. > > Jürgen > > > JMarc I'll do that change in trunk if I hear no objections. Jürgen

Typo in lib/layouts/acmsiggraph.layout?

2012-12-07 Thread Kornel Benko
Hi Uwe, this line looks suspect lib/layouts/acmsiggraph.layout:76 LabelString "Oneline ID:" Shouldn't it be "Online ID:"? Kornel signature.asc Description: This is a digitally signed message part.

Re: [patch] final layout patches for branch

2012-12-07 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > My idea would be to provide a new layout with a new name > > (journalx-new.layout), then lyx2lyx could change this to > > journalx.layout in the new major release (and also the old > > journalx.layout) and revert accordingly. > > That is very confusing. What happens if we have

Re: an idea to improve lyx

2012-12-07 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/12/12 18:40, Liviu Andronic wrote: > On Thu, Dec 6, 2012 at 6:31 PM, Richard Heck wrote: What do you think of that? >>> >>> It would be rather frustrating to not be able to type a backslash without >>> having to quit >>> the autocompletio

Re: an idea to improve lyx

2012-12-07 Thread Tommaso Cucinotta
On 06/12/12 22:20, bruno rigal wrote: > There is the same problem with the backslash in conventional latex and > there is a command for that: \textbackslash. > Then there are some stuff that I couldn't do with alt P. For exemple > inserting numbered equations (which I do a lot as a physicist). > A

Re: [patch] final layout patches for branch

2012-12-07 Thread Jean-Marc Lasgouttes
Le 06/12/2012 23:56, Uwe Stöhr a écrit : LyX cannot take care of what OSes do/provide. For example on Windows you get package updates regularly every week or at least every time you upgrade LyX to a new version. So should we discontinue LyX for unix and Mac OS and tell user to switch to window

Re: [patch] final layout patches for branch

2012-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2012 00:04, Uwe Stöhr a écrit : Am 06.12.2012 09:12, schrieb Jean-Marc Lasgouttes: For modernCV, I am not so sure it was a good idea. In texlive2012, I have version 0.12. But this version is 2.5 years old. I would have bet that the example file that comes with LyX 2.0.5 fails with th

Re: [patch] final layout patches for branch

2012-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2012 00:13, Uwe Stöhr a écrit : Am 06.12.2012 21:21, schrieb Georg Baum: Definitely. One big advantage of LyX is that you do not need to think if you switch between minor point releases. But who does this? Have you have downgraded your LyX from e.g. 1.6.8 back to 1.6.3? That doesn't