Re: [PATCH] Fix bug 2884 and 3437

2007-04-19 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > >> Comment? Objection? > > > > On what? To what? > > This. It breaks WYSIWYM experience for boxes. Jürgen

Re: removing of math panel - breaks compilation

2007-04-19 Thread Uwe Stöhr
Edwin Leuven wrote: > >>attached patch gets rid of math panel > > get rid of last relic of mathpanel, the old iconpalette: > > http://www.lyx.org/trac/changeset/17873 Thiy commit is buggy: QLToolbar.C d:\lyxsvn\lyx-devel\src\frontends\qt4\iconpalette.h(47) : error C2143: syntax error: missin

Re: removing of math panel

2007-04-19 Thread Jonathan Vogt
Am Freitag 20 April 2007 schrieb Edwin Leuven: > Edwin Leuven wrote: > > the last one for tonight guys... > > will hit the pillow now and dream of brown papers bags... Hope you slept well. Trying to compile i get: Making all in qt4 make[5]: Entering directory `/home/jonathan/Documents/downloads/

Re: removing of math panel

2007-04-19 Thread José Matos
On Thursday 19 April 2007 11:08:12 pm Edwin Leuven wrote: > Edwin Leuven wrote: > > the last one for tonight guys... > > will hit the pillow now and dream of brown papers bags... Like this: Making all in qt4 make[5]: Entering directory `/home/jamatos/tmp/lyx-build/src/frontends/qt4' make[5]: *** N

Re: removing of math panel

2007-04-19 Thread Edwin Leuven
Edwin Leuven wrote: the last one for tonight guys... will hit the pillow now and dream of brown papers bags...

Re: removing of math panel

2007-04-19 Thread Edwin Leuven
Richard Heck wrote: Is the matrix dialog set to go the same route at some point? dunno, i have never used that one in my life and found out how it looks like two hours ago... ;-) I know I've said it before, but I'm not sure we can say it enough. This is great stuff. :-)

Re: removing of math panel

2007-04-19 Thread Edwin Leuven
Edwin Leuven wrote: attached patch gets rid of math panel get rid of last relic of mathpanel, the old iconpalette: http://www.lyx.org/trac/changeset/17873 the last one for tonight guys...

Re: removing of math panel

2007-04-19 Thread Edwin Leuven
Edwin Leuven wrote: attached patch gets rid of math panel will commit soon it is in: http://www.lyx.org/trac/changeset/17872

removing of math panel

2007-04-19 Thread Edwin Leuven
attached patch gets rid of math panel will commit soon Index: development/scons/scons_manifest.py === --- development/scons/scons_manifest.py (revision 17867) +++ development/scons/scons_manifest.py (working copy) @@ -628,7 +628,6 @@

Re: Current svn fails to compile under msvc

2007-04-19 Thread Edwin Leuven
Bo Peng wrote: This probably means that we need and #include above, no? You are right. MSVC continues with the addition of this line, and gcc does not complain. Please fix it. just put it in...

Re: Current svn fails to compile under msvc

2007-04-19 Thread Bo Peng
This probably means that we need and #include above, no? You are right. MSVC continues with the addition of this line, and gcc does not complain. Please fix it. Bo

Re: Current svn fails to compile under msvc

2007-04-19 Thread Edwin Leuven
José Matos wrote: On Thursday 19 April 2007 9:09:40 pm Bo Peng wrote: My MSVC (patch 1) syas: toolbarbacken.c 35, 307, 317: error c2039, 'find_if' is not a member of 'std'. Linux/gcc is fine. This probably means that we need and #include above, no? bo could you check this? i don't see t

Re: Beta 2 (preliminar work)

2007-04-19 Thread Edwin Leuven
patch 3 (small): http://www.lyx.org/trac/changeset/17869 adjust a couple of icons dimensions to avoid the problems enrico saw (we probably need more of these)

Re: Beta 2 (preliminar work)

2007-04-19 Thread Edwin Leuven
2nd patch: http://www.lyx.org/trac/changeset/17868 adds the menus and panels

Re: Current svn fails to compile under msvc

2007-04-19 Thread José Matos
On Thursday 19 April 2007 9:09:40 pm Bo Peng wrote: > My MSVC (patch 1) syas: > > toolbarbacken.c 35, 307, 317: error c2039, 'find_if' is not a member of > 'std'. > > Linux/gcc is fine. This probably means that we need and #include above, no? > Cheers, > Bo -- José Abílio

Current svn fails to compile under msvc

2007-04-19 Thread Bo Peng
My MSVC (patch 1) syas: toolbarbacken.c 35, 307, 317: error c2039, 'find_if' is not a member of 'std'. Linux/gcc is fine. Cheers, Bo

Re: Beta 2 (preliminar work)

2007-04-19 Thread Edwin Leuven
first patch is in: http://www.lyx.org/trac/changeset/17867 this one introduces the toolbar backend refactoring

Re: Beta 2 (preliminar work)

2007-04-19 Thread José Matos
On Thursday 19 April 2007 6:11:06 pm José Matos wrote: > Hi, > I am preparing to tag and release beta 2. > > I took this chance and I have documented the procedure in > http://wiki.lyx.org/Devel/ReleaseProcedure > > I will fix it during the way. :-) > > So if you have someth

Re: Beta 2 (preliminar work)

2007-04-19 Thread Edwin Leuven
José Matos wrote: On Thursday 19 April 2007 7:13:05 pm Edwin Leuven wrote: > So if you have something that is really, really, really > urgent speak now or wait for post beta 2. :-) the math toolbar stuff? Put it in. great! i will also remove math panel (which is redundant now) u

[PATCH-updated] Bug 3478

2007-04-19 Thread Richard Heck
Bernhard, Do you want to comment on this? Have a look especially at the bits about entryDelim. At first, I thought I'd caught a typo---"{" getting paired with ")"---but then I realized that entryDelim never actually got used. So I think it can just be removed, as in the diff. Otherwise, I think t

Re: Beta 2 (preliminar work)

2007-04-19 Thread José Matos
On Thursday 19 April 2007 7:13:05 pm Edwin Leuven wrote: > > > >So if you have something that is really, really, really > > urgent speak now or wait for post beta 2. :-) > > the math toolbar stuff? Put it in. -- José Abílio

Re: Beta 2 someday?

2007-04-19 Thread Enrico Forestieri
On Thu, Apr 19, 2007 at 04:04:26PM +0200, Edwin Leuven wrote: > Enrico Forestieri wrote: > > The patch works with Qt 4.1 but for some reason the \leqq and \geqq > > symbols (the first two symbols in "AMS Relations") are displayed as > > \leq and \geq (see attached qt414.png). > > and with the atta

Re: Beta 2 (preliminar work)

2007-04-19 Thread Richard Heck
Edwin Leuven wrote: > José Matos wrote: >> Hi, >> I am preparing to tag and release beta 2. > > So if you have something that is really, really, really > > urgent speak now or wait for post beta 2. :-) > > the math toolbar stuff? I'm new, so don't listen to me, but I'd agree. This is

Re: Beta 2 (preliminar work)

2007-04-19 Thread Edwin Leuven
José Matos wrote: Hi, I am preparing to tag and release beta 2. >So if you have something that is really, really, really > urgent speak now or wait for post beta 2. :-) the math toolbar stuff?

Re: Cheap bugs (Was: [PATCH] Bug 3461)

2007-04-19 Thread Richard Heck
I'll add easyfix to some bugs then, as I find them. It might be nice to add something about this to the development page on the main lyx.org site. Something like: A good way to get started is to fix some of the easyfix bugs. This will help you get to know the code, etc, etc. I might add, too, th

Re: [PATCH] Bug 3463

2007-04-19 Thread Richard Heck
Abdelrazak Younes wrote: >> +//It's not obvious this is the right place for this enum. Note >> that it >> +//serves a different purpose from the one in insetbase.C and so >> can't be >> +//replaced by it. > Couldn't they be merged instead? See above. The InsetBase::Code can be different

Beta 2 (preliminar work)

2007-04-19 Thread José Matos
Hi, I am preparing to tag and release beta 2. I took this chance and I have documented the procedure in http://wiki.lyx.org/Devel/ReleaseProcedure I will fix it during the way. :-) So if you have something that is really, really, really urgent speak now or wait

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Richard Heck
This turns out not to matter, as entryDelim must be a leftover from some previous code: It's set but never read---which is why no problem ever occurred here---so it can just be deleted.But I'll wait a bit before committing, in case Bernhard has a different view. Richard Abdelrazak Younes wrote:

Re: [PATCH] Bug 3461

2007-04-19 Thread Richard Heck
So what's the status here? This look OK at this point? The neatest thing to do would have been just to put form_->setGotoRef() in closeEvent(). That's what I tried first, and it didn't work. I can't remember why now. I think it was because closeEvent() doesn't routinely get triggered when the can

Re: Nomencl version

2007-04-19 Thread José Matos
On Thursday 19 April 2007 3:46:37 pm Ozgur Ugras BARAN wrote: > Hi all, > > If I can find a computer this weekend and if nobody is already caring about > nomencl.sty version mess, I'll try to find a solution. Please do. :-) > Maybe you may wish to postpone Beta-2 until I submit the patch. Indee

Nomencl version

2007-04-19 Thread Ozgur Ugras BARAN
Hi all, If I can find a computer this weekend and if nobody is already caring about nomencl.sty version mess, I'll try to find a solution. Maybe you may wish to postpone Beta-2 until I submit the patch. Indeed, releasing beta with this bug will end up with thousands of complaints. For me, it is

Re: Beta 2 someday?

2007-04-19 Thread José Matos
On Friday 13 April 2007 5:04:10 pm Georg Baum wrote: > I am not sure when we really use blocker. It is matter of convention, if we agree with your classification we could change the bug reports so that this information does not get lost and is concentrated in a single place. > Georg -- José

Re: Beta 2 someday?

2007-04-19 Thread Edwin Leuven
Enrico Forestieri wrote: The patch works with Qt 4.1 but for some reason the \leqq and \geqq symbols (the first two symbols in "AMS Relations") are displayed as \leq and \geq (see attached qt414.png). and with the attached icons? /* XPM */ static char *a[] = { /* columns rows colors chars-per-

cursor hide and seek

2007-04-19 Thread Edwin Leuven
the bottom of the cursor starts to blink in the top left corner of the workarea when i scroll down with the mousewheel or scrollbar. looks a bit strange...

Re: [patch] crash when inserting backslash to math macro (#3466)

2007-04-19 Thread Abdelrazak Younes
Stefan Schimanski wrote: Here is a patch for #3466 (http://bugzilla.lyx.org/show_bug.cgi?id=3466). Is the call of updateFlags ok? Yes. Wondering if we get two redraws here instead of one if e.g. you close a macro with space. No, there'll be only one redraw in principle. OK, I suppose you

[patch] crash when inserting backslash to math macro (#3466)

2007-04-19 Thread Stefan Schimanski
Here is a patch for #3466 (http://bugzilla.lyx.org/show_bug.cgi? id=3466). Is the call of updateFlags ok? Wondering if we get two redraws here instead of one if e.g. you close a macro with space. This attempt to avoid recursive macros should be obsolete now. SVN commit log: If the cursor is c

Re: Cheap bugs (Was: [PATCH] Bug 3461)

2007-04-19 Thread christian . ridderstrom
On Thu, 19 Apr 2007, Abdelrazak Younes wrote: > By the way, if there are such cheap bugs, please list them. Maybe > that would motivate someone to do some cheap bug fixing. There's already the easyfix keyword for that. Heh... very easy then. I've added them to this page: http://w

Re: [PATCH/RFC] Icon mode in the Delimiter dialog

2007-04-19 Thread Abdelrazak Younes
José Matos wrote: On Thursday 19 April 2007 11:05:08 am Abdelrazak Younes wrote: The Icon Mode allow to get rid of the scrollbar (selection with arrow keys still work). See attached screenshot. Comment? Objection? I like it. :-) OK, committed. Abdel.

Re: Cheap bugs (Was: [PATCH] Bug 3461)

2007-04-19 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: On Thu, 19 Apr 2007, Abdelrazak Younes wrote: Richard Heck wrote: Edwin Leuven wrote: > Richard Heck wrote: > > Attached patch addresses 3461. Comments please. > if only all bugs were this easy to fix... Indeed. But you know, there are a lot of cheap bugs on bug

Re: Trouble importing LaTeX file w/macros into LyX 1.5

2007-04-19 Thread José Matos
On Tuesday 10 April 2007 6:59:03 pm Weber, Anne wrote: > Dear LyX Developers, Hi, > I'm having consistent trouble with importing a LaTeX file with macros > (user-written shortcuts) into LyX 1.5 (and 1.4.4 as well). In several > equations throughout the document, shortcut text from the LaTeX fil

Cheap bugs (Was: [PATCH] Bug 3461)

2007-04-19 Thread christian . ridderstrom
On Thu, 19 Apr 2007, Abdelrazak Younes wrote: Richard Heck wrote: Edwin Leuven wrote: > Richard Heck wrote: > > Attached patch addresses 3461. Comments please. > if only all bugs were this easy to fix... Indeed. But you know, there are a lot of cheap bugs on bugzilla---or so I'm finding

Re: [PATCH/RFC] Icon mode in the Delimiter dialog

2007-04-19 Thread José Matos
On Thursday 19 April 2007 11:05:08 am Abdelrazak Younes wrote: > The Icon Mode allow to get rid of the scrollbar (selection with arrow > keys still work). See attached screenshot. > > Comment? Objection? I like it. :-) > Abdel. -- José Abílio

[PATCH/RFC] Icon mode in the Delimiter dialog

2007-04-19 Thread Abdelrazak Younes
The Icon Mode allow to get rid of the scrollbar (selection with arrow keys still work). See attached screenshot. Comment? Objection? Abdel. Index: QDelimiterDialog.C === --- QDelimiterDialog.C (revision 17858) +++ QDelimiterDialog

Re: BUG 3464: Invalid latex generated with foreign language words inside headings

2007-04-19 Thread Helge Hafting
I found out that the problem was my document class, as this problem don't exist with standard classes. So, not a LyX problem and I set the bug to "fixed". (Or is "invalid" more correct?) Now to find out how my .layout additions can have such a strange effect. Helge Hafting

Re: [PATCH] Bug 3463

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: This patch addresses the remaining issue with crashes on ill-formed inset-insert minibuffer commands. I've also added some comments expressing my understanding of what's going on here. +InsetCommandParams::InsetParamType InsetCommandParams::command2ParamType(std::string c

Re: [PATCH] Bug 3463

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: This patch addresses the remaining issue with crashes on ill-formed inset-insert minibuffer commands. I've also added some comments expressing my understanding of what's going on here. I am not well versed in this InsetCommand stuff but your patch looks good and the comment

Finishing CJK support Re: Beta 2 someday?

2007-04-19 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: I understand that and I should probably make the same decision someday. If you can find some free time, I would only request that you finish the CJK LateX support (bug 3043) as I really don't think I could do it. Or perhaps JMarc or Enrico could finish

Re: Beta 2 someday?

2007-04-19 Thread José Matos
On Thursday 19 April 2007 9:20:06 am Georg Baum wrote: > AFAIK yes. Renaming styles is a fileformat change unless you use the > "obsoletedby" (spelling?) feature. ObsoletedBy is now deprecated by lyx2lyx. > Georg -- José Abílio

Re: Beta 2 someday?

2007-04-19 Thread José Matos
On Wednesday 18 April 2007 9:41:27 pm Edwin Leuven wrote: > 4. i was editing some tables and deleting rows resulted in the deletion > of rows other than the one the cursor was in (i haven't been able to > reproduce this, but it happened) I had several crashes when selecting table parts. The emerge

Re: Beta 2 someday?

2007-04-19 Thread Georg Baum
Abdelrazak Younes wrote: > I understand that and I should probably make the same decision someday. > If you can find some free time, I would only request that you finish the > CJK LateX support (bug 3043) as I really don't think I could do it. Or > perhaps JMarc or Enrico could finish it? It is r

Re: Beta 2 someday?

2007-04-19 Thread Georg Baum
Michael Gerz wrote: > What file format change are you talking about? Does it still break > backwards compatibility? AFAIK yes. Renaming styles is a fileformat change unless you use the "obsoletedby" (spelling?) feature. Georg

Re: Bug 3432: Request for Ctrl-Tab Support

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: Obviously this is a totally trivial patch. But do speak up if you object. Please add this also while you are at it: +\bind "C-S-Tab" "buffer-previous" Abdel. Richard Inde

Re: [PATCH] Bug 3461

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: Edwin Leuven wrote: Richard Heck wrote: Attached patch addresses 3461. Comments please. if only all bugs were this easy to fix... Indeed. But you know, there are a lot of cheap bugs on bugzilla---or so I'm finding---and I'll bet we could squash dozens if we were so inclin

Re: Beta 2 someday?

2007-04-19 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: I personally arrive at saturation. I simply cannot maintain this rhythm. What I really mean is that 1.5.0svn is good enough for me and for a lot of people already. So, even if we did not solve all 1.4 regressions WRT 1.3, I reckon that 1.5 is very s

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: And oh by the way, can someone check this bit: if (ch == '(') entryDelim = ')'; - else if (ch == '{') entryDelim = ')'; + else if (ch == '{') entryDelim = '}'; It had previous been: else if (ch = '{') en

Re: Icon Sizes [WAS Re: Beta 2 someday?]

2007-04-19 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Apr 18, 2007 at 06:32:04PM -0400, Richard Heck wrote: But surely you could run the script and then have a look at what you had, re-doing by hand those that needed to be redone by hand. It'd at least be worth investigating, if no-one has yet tried it. Of course, s

Re: Icon Sizes [WAS Re: Beta 2 someday?]

2007-04-19 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Apr 18, 2007 at 06:12:39PM -0400, Richard Heck wrote: Enrico Forestieri wrote: On Wed, Apr 18, 2007 at 09:33:56PM +0200, Edwin Leuven wrote: what do you see when you have large icons (right click on toolbar and select big-sized icons)? Doh! I would say

Re: [PATCH] Bug 3461

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: Actual patch. Richard Index: QRefDialog.C === --- QRefDialog.C(revision 17850) +++ QRefDialog.C(working copy) @@ -33,6