Richard Heck wrote:
This patch addresses the remaining issue with crashes on ill-formed inset-insert minibuffer commands. I've also added some comments expressing my understanding of what's going on here.
I am not well versed in this InsetCommand stuff but your patch looks good and the comments look sound. But, and this is a big BUT, please put this new conversion method command2ParamType() *outside* of the InsetCommandParams class. InsetCommandParams is a base class and should not know _anything_ about which type of class is using it.
The rest looks OK to me. Abdel.
