And that is only thing I absolutely refuse. Not a single included
header file should ever be removed from any source because of some
pch.h.
Nothing will be more portable.
How about adding
#ifdef _USE_PCH
#include
#endif
and change --include=pch.h to -D_USE_PCH?
Bo
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > Yes. I basically require you to find a find a way to avoid the code
| > intrusion of win-style precompiled headers.
|
| Now my answer is no, there is no way to do msvc/pch without
| modification to the source files themselves. Since the inclusion of
| pch
Am Mittwoch, 7. Juni 2006 02:45 schrieb Edwin Leuven:
> the attached patch includes qt4 (haven't had time to test yet, added
> booktabs but didn't check out interline space)
Thanks, I put the stuff without the interlinespace changes in. The current
diff is now attrached. I still need to think a
Yes. I basically require you to find a find a way to avoid the code
intrusion of win-style precompiled headers.
Now my answer is no, there is no way to do msvc/pch without
modification to the source files themselves. Since the inclusion of
pch.h will cost almost nothing (other than intrusiveness
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > | Unless you can convince me with more benefits of the current approach,
| >
| > No, It is _you_ that has to convice me.
|
| I have listed benefits and costs, you simply said "I do not like it".
Yes. I basically require you to find a find a way to avoid
| Unless you can convince me with more benefits of the current approach,
No, It is _you_ that has to convice me.
I have listed benefits and costs, you simply said "I do not like it".
"mainstream"?
Only in your world not mine.
That is the case for all online tutorials, examples, manuals. Ca
"Bo Peng" <[EMAIL PROTECTED]> writes:
| Unless you can convince me with more benefits of the current approach,
No, It is _you_ that has to convice me.
| I would suggest that lyx follows the mainstream and adds pch.h to
| source files.
"mainstream"?
Only in your world not mine.
--
Lg
To me the change to provide pvh for win is just too ugly.
This time, I do not think it is Bill's fault.
You insist on 'non-intrusive pch'. As a result, every source file has
its own full set of headers and can compile normally. When pch is on,
many headers in the source files are shadowed becau
On Wed, Jun 21, 2006 at 12:17:41PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> In my newfound tradition of making everything simpler :-) If
> Martin> you paint the whole tabular background, you don't have to
> Martin> figure out wha
Jürgen,
when updating my tree with the font patch I got conflicts. I guess that
the removal of the paper options was not done on purpose? If that was an
accident, I am going to put the attached patch in.
Georg
Index: src/frontends/qt3/QDocument.C
===
Angus Leeming <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > The title says it all. This is one more step in the eradication of
| > workArea_ inside BufferView!
|
| Totally sane.
But instead we get both the width and height of the workArea_ cached
in BufferView.
Look also at the QApplication problem: I asked for testing by windows
people, and the only response I got was from Peter. I am not motivated at
all to continue fixing bugs for other people if they can't be bothered to
even test the patches.
While, Abdel was busy, I do not usually have access to
Angus Leeming <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > Here is the next step on my GUI API cleanup. Only qt4 for now.
| > Committed to the "younes" branch. Comments welcome.
|
| Summary
| ===
| So a summary of this patch might be: A BufferView requires a
Am Mittwoch, 21. Juni 2006 18:59 schrieb Bo Peng:
> Regarding conservativeness, I do feel that we should do more in the
> user (and developer) friendliness end. The idea that a normal user
> will read tutorial and follow the instructions is plainly wrong. There
> are also some discrimination again
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > Haven't we discussed the patch on the list? I don't wanna explain all
| > the stuff again in the log message.
|
| What you are lacking is which files you have changed.
svn log -v
--
Lgb
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > > Other votes? JMarc, Georg? (We need to include pch.h in each source
| > > file and remove --include=pch.h)
| >
| > I don't care as long as I don't have to do build system changes afterwards.
|
| The build system change (autotools end) is minimal. A simp
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> The title says it all. This is one more step in the eradication of
> workArea_ inside BufferView!
Totally sane.
Angus
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Here is the next step on my GUI API cleanup. Only qt4 for now.
> Committed to the "younes" branch. Comments welcome.
Summary
===
So a summary of this patch might be: A BufferView requires a valid WorkArea, so
make the code do that. (ATM, the code
> Other votes? JMarc, Georg? (We need to include pch.h in each source
> file and remove --include=pch.h)
I don't care as long as I don't have to do build system changes afterwards.
The build system change (autotools end) is minimal. A simple deletion
of --include=pch.h in config/common.m4 will
Hello,
The title says it all. This is one more step in the eradication of
workArea_ inside BufferView!
Abdel.
Log:
* BufferView::workAreaResize(): now requires width and height.
* BufferView::pimpl::workAreaResize(): ditto
* gtk/GWorkArea.C: adapt call to above Change
* qt3/QContentPane.C: di
> FYI I had the very same reaction when I first joined in (Bo also I
> believe). I still think that the LyX team is overly conservative but I
> have the feeling that this is changing.
I am sorry for pointing the obvious, "or you are changing, you become one of
us". ;-)
I was mainly complainin
Bo Peng wrote:
>> |
>> | Please decide whether or not we want msvc/pch.
>>
>> My vote then is: No.
>
> Other votes? JMarc, Georg? (We need to include pch.h in each source
> file and remove --include=pch.h)
I don't care as long as I don't have to do build system changes afterwards.
Georg
Jose' Matos wrote:
On Wednesday 21 June 2006 17:12, Abdelrazak Younes wrote:
FYI I had the very same reaction when I first joined in (Bo also I
believe). I still think that the LyX team is overly conservative but I
have the feeling that this is changing.
I am sorry for pointing the obvious,
On Wednesday 21 June 2006 17:12, Abdelrazak Younes wrote:
> FYI I had the very same reaction when I first joined in (Bo also I
> believe). I still think that the LyX team is overly conservative but I
> have the feeling that this is changing.
I am sorry for pointing the obvious, "or you are chang
Haven't we discussed the patch on the list? I don't wanna explain all
the stuff again in the log message.
What you are lacking is which files you have changed. The description
should not be too long, something like: add isMaximized options, allow
save/restore correct windows size/state. No furth
Peter Kümmel wrote:
Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: kuemmel
Date: Wed Jun 21 12:30:32 2006
New Revision: 14166
Log:
fix: qt3/qt4 save/restore of the window geometry and maximize status
Try to be more verbose next time Peter. The SVN log is there to let us
know what h
|
| Please decide whether or not we want msvc/pch.
My vote then is: No.
Other votes? JMarc, Georg? (We need to include pch.h in each source
file and remove --include=pch.h)
| Note that we do not gain much from gcc/pch. my initial benchmark says:
|
| autotools/gcc/pch: 12.36s
| autotools/gcc/n
"Bo Peng" <[EMAIL PROTECTED]> writes:
| On 6/19/06, Bo Peng <[EMAIL PROTECTED]> wrote:
| > > I thought this was were the pch.cpp came in, only used for generating
| > > the pch.pch file.
|
| From what I read
|
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_.2f
Abdelrazak Younes wrote:
> [EMAIL PROTECTED] wrote:
>> Author: kuemmel
>> Date: Wed Jun 21 12:30:32 2006
>> New Revision: 14166
>>
>> Log:
>> fix: qt3/qt4 save/restore of the window geometry and maximize status
>
> Try to be more verbose next time Peter. The SVN log is there to let us
> know what
On 6/19/06, Bo Peng <[EMAIL PROTECTED]> wrote:
> I thought this was were the pch.cpp came in, only used for generating
> the pch.pch file.
From what I read
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_.2f.yu.asp
, it is necessary to change all our source
> Log:
> fix: qt3/qt4 save/restore of the window geometry and maximize status
Try to be more verbose next time Peter. The SVN log is there to let us
know what has changed without having to svn diff in the future.
Peter will be annoyed. Last time, I asked him to reduce log message
(he used to pu
[EMAIL PROTECTED] wrote:
Author: kuemmel
Date: Wed Jun 21 12:30:32 2006
New Revision: 14166
Log:
fix: qt3/qt4 save/restore of the window geometry and maximize status
Try to be more verbose next time Peter. The SVN log is there to let us
know what has changed without having to svn diff in the
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> So done.
Thanks.
Martin> Don't think it requires anything in status.14x.
Why? I try to put everything there.
JMarc
On Tue, 2006-06-20 at 15:00 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> Your question presupposes that these two mechanisms would have
> Martin> anything in common. They have not. display() is a property of
> Martin> the inset (or i
Joost Verburg writes:
> Abdelrazak Younes wrote:
>> It would be very nice if your installer would install the aspell header
>> and libraries in [install dir] in addition to the executable:
> These files are available as a separate download:
> http://wiki.lyx.org/uploads/Windows/Tools/aspell-0.60.
Abdelrazak Younes wrote:
It would be very nice if your installer would install the aspell header
and libraries in [install dir] in addition to the executable:
- mingw static and dynamic libs: lib/libaspell.a and lib/libaspell.dll
- msvc static and dynamic libs: lib/aspell.lib and lib/aspell.dll
Lars Gullik Bjønnes wrote:
> Peter Kümmel <[EMAIL PROTECTED]> writes:
>
> | Done.
> |
> | Attached the new patch.
>
> This is ok with me now.
>
I've checked it in.
Having now the qt3 and the qt4 version of lyx on my machine
here my two benchmark timings:
Windows
qt3: 18 sec
qt4: 31 sec
Peter Kümmel <[EMAIL PROTECTED]> writes:
> Lars Gullik Bjønnes wrote:
>> QRect const &
> Done.
> (Will search for the reason for this in the mailing list archive.
> The doc says Asger had strong arguments)
I think it's just because we decided it improves readability. These things
should be read f
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Sure... but how does rowpainter (i.e., the surrounding row)
Martin> tell the inset that it is Wide?
This is a good question :)
>> I tested the patch, and it seems to work very well. I am OK with
>> putting this in 1.4.
>>
>>
Peter Kümmel <[EMAIL PROTECTED]> writes:
| Done.
|
| Attached the new patch.
This is ok with me now.
--
Lgb
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> In my newfound tradition of making everything simpler :-) If
Martin> you paint the whole tabular background, you don't have to
Martin> figure out what cell you're in...
Martin> Please give it some exercise before the go-ahead fo
Lars Gullik Bjønnes wrote:
> | + maxWidth=QApplication::desktop()->width()-20;
>
> Oooo... spacing.
Year, I've only one line with spacing errors ;)
> | + if (width() > maxWidth)
> | + maxWidth = width();
>
> maxWidth = max(width(), maxWidth);
Msvc needs std::max and #include .
>
Bo Peng wrote:
> On 6/20/06, Peter Kümmel <[EMAIL PROTECTED]> wrote:
>> Hi Abdel, Bo
>>
>> here the next version with your embedded suggestions.
>> I've also simplified the floating code.
>
> Looks fine to me (others may have higher standard though).
>
> Is this patch against the trunk or some br
Joost Verburg wrote:
Hi,
I decided to fix Aspell 0.60.4 so we can finally get rid of the
C:\Aspell hard-coding. The next build of the installer will solve this
long-standing issue.
For this to work the dictionary installers need to be recompiled. Could
you launch the script again Angus :) ?
Peter Kümmel wrote:
Hi Abdel, Bo
here the next version with your embedded suggestions.
I've also simplified the floating code.
If you correct Lars small issue, that's fine with me.
Good work.
Abdel.
Stephen Harris wrote:
Your aspelldata-0.60.4.exe works much better! I changed the Work
directory and the Temp directory from C: to F: and that worked. I
made a mistake about not listening to you about the German dictionary;
the English dictionary worked fine (except for the 2nd misspell bug).
T
Hello,
My name is Daniel Bennet, and I want to propose you triangle (three way
linking) link exchange.
I can place your link on the following sites:
http://www.casino-tribune.com (PR=6) or
http://slotsgame4u.com/ (PR=6) or
http://www.videopoker4u.com/ (PR=5) or
http://www.roulette4u.com/ (
47 matches
Mail list logo
