Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: >> > Revised glade file makes dialog modal. >> I don't know what this means. No GUI expert me. > A modal dialog blocks all input to its parent window until it is > dismissed. In this case the dialog's contents become invalid if the > user selects another paragraph, so I prevent t

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 21:28, Angus Leeming wrote: > > Revised glade file makes dialog modal. > I don't know what this means. No GUI expert me. A modal dialog blocks all input to its parent window until it is dismissed. In this case the dialog's contents become invalid if the user selects another p

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Regarding the spacingadj_ pointer, it turned out that it was not | necessary to create one anyway, one came with the spinbutton. > | Requested changes to spacing etc have been made. > | Patch to Makefile.am, Dialogs.C from previous message still applies. >

Re: [PATCH]Replace Combo with ComboBox in GLayoutBox

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Tue, 2004-09-28 at 23:36, Lars Gullik Bjønnes wrote: >> Hmm... did you compile this or not? | It was weird, actually, I could have sworn that I did compile it, but I | obviously didn't. Anyway, I've been using this for a day now, and I'm | pretty sure i

Automatic creation of the TOC document for the different languages

2004-09-29 Thread José Abílio Oliveira Matos
Hi, in Chemnitz, this year, Jean-Marc and I discussed the update of the scheme use to generate dinamically the TOC files for the different translated languages. I have studied the subject and this is what I propose: - replace the present non working perl script with a shiny new script th

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: > Revised glade file makes dialog modal. I don't know what this means. No GUI expert me. > This would not be necessary if I > could get a signal each time the cursor in the workarea changes position > (to load the present paragraph's settings into the dialog), but that > would

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. > >> drop the if. (and change to use a smart pointer) | Confession time: I have

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. I probably should :-) Anyhow this is done everywhere else in the code. > >> d

Re: [PATCH]Replace Combo with ComboBox in GLayoutBox

2004-09-29 Thread John Spray
On Tue, 2004-09-28 at 23:36, Lars Gullik Bjønnes wrote: > Hmm... did you compile this or not? It was weird, actually, I could have sworn that I did compile it, but I obviously didn't. Anyway, I've been using this for a day now, and I'm pretty sure it's working okay. Attached version has a little

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
Regarding the spacingadj_ pointer, it turned out that it was not necessary to create one anyway, one came with the spinbutton. Requested changes to spacing etc have been made. Patch to Makefile.am, Dialogs.C from previous message still applies. Attached is also an addition to GViewBase: update(

Re: Gtk::Menu accelerators

2004-09-29 Thread Angus Leeming
Angus Leeming wrote: > John Spray wrote: >> I don't get it. See what it looks like for me: >> http://icculus.org/~jcspray/lyx-gtk.png > > I get a whopping great minibuffer that takes up half the screen. > >> Note that my GView.C is different to yours, with a single (yet >> critical) false inste

Re: Gtk::Menu accelerators

2004-09-29 Thread Angus Leeming
John Spray wrote: > I don't get it. See what it looks like for me: > http://icculus.org/~jcspray/lyx-gtk.png I get a whopping great minibuffer that takes up half the screen. > Note that my GView.C is different to yours, with a single (yet > critical) false instead of a true. > Patch attached for

Re: Gtk::Menu accelerators

2004-09-29 Thread John Spray
Oops, clicked Send too soon on previous reply. On Wed, 2004-09-29 at 15:31, Angus Leeming wrote: > Incidentally, whilst all these dialogs are nice, you should see how > the Gtk frontend looks with multiple toolbars activated. Try changing > lib/ui/default.ui to I should probably explain my reaso

Re: Gtk::Menu accelerators

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 15:31, Angus Leeming wrote: > You don't check "!symname.empty()", so this is unsafe. Thanks. Revised patch attached. > Also, why not: > > string buf; > if (mod & key_modifier::shift) > buf = "Shift+"; > if (mod & key_modifier::ctrl)

Re: Gtk::Menu accelerators

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 15:39, Jean-Marc Lasgouttes wrote: > Hmm, couldn't you use this constructor in GLyXKeySym::print and > transform this into a string? This would look better than adding > 'Ctrl+' by hand, IMO. Gtk::AccelKey::get_abbrev unfortunately only outputs the gtk-parsable form "n". Good

Re: insetgraphic docbook support for image sizes

2004-09-29 Thread José Abílio Oliveira Matos
On Wed, Sep 29, 2004 at 01:58:17AM +0200, Andreas Vox wrote: > > Hi José and others from the XML edge ! Patch commited. I changed a litle bit the ChangeLog, inside parentesis goes the function where the changes were made. Keep the good work. -- José Abílio Matos LyX and docbook a perfect m

Re: insetgraphic docbook support for image sizes

2004-09-29 Thread José Abílio Oliveira Matos
On Wed, Sep 29, 2004 at 01:58:17AM +0200, Andreas Vox wrote: > > Hi José and others from the XML edge ! > > > I made a first stab at modifying insetgraphic to provide size hints for > exported > graphics. Right now it only works for me since the units are not > converted. > > I found the page

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: > Two newlines between functions please. That one doesn't seem to be in the Rules document, maybe you should add it. > drop the if. (and change to use a smart pointer) Confession time: I have no idea about smart pointers. I've looked at the

Re: Gtk::Menu accelerators

2004-09-29 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> Attached patch should sort this issue: Add gtk+ style John> accelerator labels to menu items. Previous runtime warnings have John> of course vanished because we're not using Gtk accels any more, John> just plain old labels. It looks OK

Re: Gtk::Menu accelerators

2004-09-29 Thread Angus Leeming
John Spray wrote: > +*symname.begin() = > lyx::support::uppercase(*symname.begin()); > +buf += symname; You don't check "!symname.empty()", so this is unsafe. Also, why not: string buf; if (mod & key_modifier::shift) buf = "Shift+"; i

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | class ControlParagraph; > | /** This class provides a gtk implementation of the paragraph dialog. | */ | class GParagraph | : public GViewCB { | Gtk::Adjustment * spacingadj_; Do you really need it to be a pointer at all? -- Lgb

[PATCH] Remove dependencies in lyx.spec.in

2004-09-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This is fine with me. In the debian world, we would downgrade Georg> the dependency to "Recommends" or even "Suggests", but AFAIK Georg> rpm does not offer this flexibility. That would be nice indeed. >> The same holds for qt: what a

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | /** | * \file GParagraph.C | * This file is part of LyX, the document processor. | * Licence details can be found in the file COPYING. | * | * \author John Spray | * | * Full author contact details are available in file CREDITS. | */ > | #include >

Re: Gtk::Menu accelerators

2004-09-29 Thread John Spray
Right, here's how I've handled this issue: -modify GLyXKeySym.C to produce nicer human-readable accelerators like Ctrl+N. Not functionally necessary, but better UI. -In GMenubar.C, load two labels (item name and accel string) into an hbox and load the hbox into a menuitem. It's not that concise,

Re: assertions triggered

2004-09-29 Thread Jean-Marc Lasgouttes
> "Jeremy" == Jeremy C Reed <[EMAIL PROTECTED]> writes: Jeremy> Easy to reproduce. I have two documents open and I click File Jeremy> -> Close. I can confirm this. This is bug 1694 http://bugzilla.lyx.org/show_bug.cgi?id=1694 JMarc

Re: Re: Thank you!

2004-09-29 Thread sales
PLEASE NOTE: [EMAIL PROTECTED] is no longer in use, Please re-send to the following email address and we will respond as soon as possible: [EMAIL PROTECTED] Your email has NOT been saved or forwarded. PostMaster

[PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
Hi, The paragraph dialog. Note that this is the first instant-apply dialog I've done: hopefully that should all work okay. John Index: ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/gtk/ChangeLog,v retrieving revision 1.62

Re: Gtk::Menu accelerators

2004-09-29 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> On Wed, 2004-09-29 at 08:44, Jean-Marc Lasgouttes wrote: >> And what would be the right gtkmm method to get a nice >> human-readable version? John> Well, I'm currently using a modified GLyXKeySym::print to John> produce gtk-style strings

Re: Gtk::Menu accelerators

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 08:44, Jean-Marc Lasgouttes wrote: > And what would be the right gtkmm method to get a nice human-readable > version? Well, I'm currently using a modified GLyXKeySym::print to produce gtk-style strings like "Ctrl+N" (in fact, this is also the normal style for qt apps, so I don

Re: Gtk::Menu accelerators

2004-09-29 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> On Tue, 2004-09-28 at 16:24, John Spray wrote: >> > While I do not have anything useful to say about the errors, I'd >> like > to point you to GLyXKeySym::print, which is the right hook >> for > generating a correct string corresponding