Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> Bennett, could you try it and tell me whether it fixes the problems >> in LyX/Mac? Note that this will not display the emacs-like two-key >> bindings, but this is a limitation of Qt/Mac, as far as I can see. Bennett> It works! That is

[PATCH] Fix bug #1609 -- error on emphasize, bold, and similar

2004-06-24 Thread Jean-Marc Lasgouttes
See: http://bugzilla.lyx.org/show_bug.cgi?id=1609 This patch fixes LyXText::getWord to operate on full LCursor instances instead of simple CursorSlices. This fixes word selection, which was the problem in bug 1609. I still can't select words by double clicking, but I guess this is a different p

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> It would be nicer if getLabel returned a QString in the first > Angus> place, wheich would also enable you to move the #ifdef block > Angus> back into getLabel. > > Yes, that can be done but... [see below] > > Angus> Otherwise, have you not forgotten to do som

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> However, since we are supposedly in freeze time, I came up with the >> attached kludgy but simple patch. It adds a method to kb_keymap >> that returns the first 1-key binding to a FuncRequest. This is much >> easier than writing the com

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: One other point. This: >> label += '\t' + QAccel::keyToString(key); Angus> is deprecated in the Qt docs which state that you should use: >> label += '\t' + static_cast(key); Angus> Ditto with any use of

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: One other point. This: > label += '\t' + QAccel::keyToString(key); is deprecated in the Qt docs which state that you should use: > label += '\t' + static_cast(key); Ditto with any use of QAccel::stringToKey which should be replaced by QString qstr("foo");

Re: [PATCH] fix tex2lyx font attribute handling

2004-06-24 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> It seems reasonable. Note that the current font is typically a part >> of the 'context'. Why not put the font parameter in there? Georg> I forgot why I did it like that (it is some time ago when I Georg>

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Bennett Helm
Bennett, could you try it and tell me whether it fixes the problems in LyX/Mac? Note that this will not display the emacs-like two-key bindings, but this is a limitation of Qt/Mac, as far as I can see. It works! That is, all combinations of modifier keys and normal keys (including function keys) s

Re: [PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Rather than try and do this yourself, why not generate a > Angus> QKeySequence from the binding and then invoke: > > Actually, the right thing to do would be to have > kb_keymap::findbinding return a list of kb_sequence and expose only > that to the frontends.

Re: iso-8859-13

2004-06-24 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Trying again. Ah, that's better. I have to press the 'attach' Martin> button... >> is latin-7 the same as iso-8859-13? I see that the patch has been applied, but the following line seems suspicious to me: +icelandic iceland

[PATCH] Re: Bug with menu shortcuts in Qt/Mac

2004-06-24 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Rather than try and do this yourself, why not generate a Angus> QKeySequence from the binding and then invoke: Actually, the right thing to do would be to have kb_keymap::findbinding return a list of kb_sequence and expose only tha

Re: [PATCH] fix tex2lyx font attribute handling

2004-06-24 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > It seems reasonable. Note that the current font is typically a part of > the 'context'. Why not put the font parameter in there? I forgot why I did it like that (it is some time ago when I wrote that). I'll try your suggestion. > Actually, I wonder whether using LyX

Re: [PATCH] fix tex2lyx font attribute handling

2004-06-24 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> tex2lyx has code to handle the following: {\small bla} blubb Georg> The size of bla is set to small. Unfortunately it is not reset Georg> afterwards, i.e. blubb is also small. Not only the size can be Georg> changed like this, but als