>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
>> However, since we are supposedly in freeze time, I came up with the >> attached kludgy but simple patch. It adds a method to kb_keymap >> that returns the first 1-key binding to a FuncRequest. This is much >> easier than writing the complete recursive version, but I can try >> to do that if people prefer. Angus> Would be nice. Kludges tend not to get fixed... I'll wait to see what Lars prefers... This would mean some changes in how MenuBackend works. And since I would like to push some changes in there to fix the remaining OSX menu bug, I save my karma points for later :) >> Bennett, could you try it and tell me whether it fixes the problems >> in LyX/Mac? Note that this will not display the emacs-like two-key >> bindings, but this is a limitation of Qt/Mac, as far as I can see. >> >> Comments welcome. Angus> The only places using getLabel convert it immediately to Angus> QString: Angus> It would be nicer if getLabel returned a QString in the first Angus> place, wheich would also enable you to move the #ifdef block Angus> back into getLabel. Yes, that can be done but... [see below] Angus> Otherwise, have you not forgotten to do something similar to Angus> the second user of getLabel above. AFAICS, this second user Angus> currently displays the binding (on non-Mac boxes) but would not Angus> were you to apply your patch. Actually the second user is for submenus, and the code in getLabel is only for normal commands. So the code does not really belong in getLabel, IMO. JMarc
