Jean-Marc Lasgouttes wrote: > Angus> It would be nicer if getLabel returned a QString in the first > Angus> place, wheich would also enable you to move the #ifdef block > Angus> back into getLabel. > > Yes, that can be done but... [see below] > > Angus> Otherwise, have you not forgotten to do something similar to > Angus> the second user of getLabel above. AFAICS, this second user > Angus> currently displays the binding (on non-Mac boxes) but would not > Angus> were you to apply your patch. > > Actually the second user is for submenus, and the code in getLabel is > only for normal commands. So the code does not really belong in > getLabel, IMO.
Fair 'nuff. -- Angus
