tberghammer added a comment.
In http://reviews.llvm.org/D16334#331428, @zturner wrote:
> In http://reviews.llvm.org/D16334#331420, @tberghammer wrote:
>
> > In http://reviews.llvm.org/D16334#331368, @zturner wrote:
> >
> > > I don't know, I still disagree. If something in step-over breaks, I
>
tberghammer added a comment.
Looks good to me and if Apple using this code then I am pretty sure my CL break
them as well. Having 0 size symbols around will cause a lot of issue around
LLDB.
http://reviews.llvm.org/D16415
___
lldb-commits mailing
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits inline
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418
@@ +417,3 @@
+bool
+ABISysV_arm::IsArmHardFloat (Thread *thread) const
Hi Omair,
Can you send me some logs about the failure you see for this test both on
arm and aarch64 Linux? The test is passing reliably on android both for arm
and aarch64 so I would like to understand what is the difference.
Thanks,
Tamas
On Wed, Jan 27, 2016 at 2:01 PM Omair Javaid via lldb-co
Hi Zach,
I think this CL (or one of your other recent related CL) caused some
regression on the Linux builder. You can see the failed build here:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10736
Can you take a look (if you need help or you think it isn't caused by one
tberghammer created this revision.
tberghammer added reviewers: zturner, tfiala.
tberghammer added a subscriber: lldb-commits.
Re-submit rL258759: Write the session log file in UTF-8.
Previously we were writing in the default encoding, which depends
on the operating system and is not guaranteed t
tberghammer added a comment.
I know that this version is not the cleanest implementation but I think this is
a very robust because we don't depend on the system encoding anywhere. Please
gave it a try and feel free to commit it if if works.
http://reviews.llvm.org/D16680
___
tberghammer added a comment.
I am more worried about Windows and python3 and I don't think we have any build
bot running the tests on Windows. I don't really know what is the original
issue this commit try to address so I plan to wait until Zachary can check it
out (the current ToT works on Lin
tberghammer added a comment.
I don't think using unicode strings everywhere is a good idea because when we
compare a string coming from the SB API with a string literal we don't want to
do a lot of conversion. Also I think enforcing all string literals to be
unicode is something what will break
tberghammer added a comment.
I converted the strings it was complaining about but I haven't managed to get
the traceback printing working without converting the data to utf-8 manually.
We are using traceback.format_exception to collect the stack trace what returns
a string, then we store it in
tberghammer added a comment.
The traceback calculation is done inside unittest2 so I think we shouldn't
change it and we don't have access to the session variable either.
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lis
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks reasonable but should we merge TestSingleStepOntoBreakpoint.py and
TestConsecutiveBreakpoints.py? I think they have quite a bit of code in common.
http://reviews.llvm.org/D167
tberghammer created this revision.
tberghammer added reviewers: clayborg, labath.
tberghammer added a subscriber: lldb-commits.
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differences.
This C
tberghammer created this revision.
tberghammer added reviewers: omjavaid, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
Fix single stepping over the IT instruction
The ARM instruction emulator had 2 bugs related to the handling of the
IT instruction
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a comment.
In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
> Looks good.
>
> A related comment about IT instructions. You need to be careful when software
> single stepping through instructions that are in the middle of an ITSTATE
> block. You can NOT use a 16 bit i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259509: Fix single stepping over the IT instruction
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16772?vs=46542&id=46647#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: tberghammer
Date: Tue Feb 2 08:32:11 2016
New Revision: 259509
URL: http://llvm.org/viewvc/llvm-project?rev=259509&view=rev
Log:
Fix single stepping over the IT instruction
The ARM instruction emulator had 2 bugs related to the handling of the
IT instruction causing an error in single st
tberghammer added a comment.
In http://reviews.llvm.org/D16769#340936, @clayborg wrote:
> Looks fine. A few things I don't like, but I can live with:
>
> - Making constructors appear all on one line does save space, but it means
> you can't debug very well as stepping into these constructors wil
tberghammer created this revision.
tberghammer added reviewers: omjavaid, jasonmolenda, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
Fix handling of the arm IT instruction in the unwinder
The IT instruction can speci
Author: tberghammer
Date: Tue Feb 2 12:18:13 2016
New Revision: 259538
URL: http://llvm.org/viewvc/llvm-project?rev=259538&view=rev
Log:
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differenc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259538: [NFC] Cleanup RangeMap.h (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16769?vs=46531&id=46673#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16769
Files:
tberghammer added a comment.
UINT32_MAX is a kind of a random value what is most likely won't be used on any
architecture as a condition code (I can't imagine having so much different
condition flags) and my current intention is to map the unconditional value to
into it as it is already done on
tberghammer updated this revision to Diff 46764.
tberghammer added a comment.
Create a typedef for the condition type and a static const value for the
unconditional condition.
http://reviews.llvm.org/D16814
Files:
include/lldb/Core/EmulateInstruction.h
include/lldb/Symbol/UnwindPlan.h
so
tberghammer accepted this revision.
tberghammer added a comment.
Looks reasonable and I agree with Pavel in the idea of moving the android
related utility functions into their own file for better separation
Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:73-81
@@
tberghammer created this revision.
tberghammer added reviewers: clayborg, omjavaid.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Use BKPT instead of UDF for arm/thumb breakpoints
The UDF instruction is deprecated in armv7 and in case of thumb2 instru
tberghammer added inline comments.
Comment at: include/lldb/Core/EmulateInstruction.h:390
@@ +389,3 @@
+typedef uint32_t InstructionCondition;
+static const InstructionCondition UnconditionalCondition = UINT32_MAX;
+
clayborg wrote:
> It is nice to tell wh
tberghammer updated this revision to Diff 46899.
tberghammer added a comment.
Update breakpoint opcodes based on review
http://reviews.llvm.org/D16853
Files:
source/Plugins/Platform/Linux/PlatformLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.cpp
Index: source/Plugins/Process/Li
tberghammer accepted this revision.
tberghammer added a comment.
Looks reasonable
Comment at: packages/Python/lldbsuite/test/lldbtest.py:672-682
@@ -768,1 +671,13 @@
+
+def skipUnlessListedRemote(remote_list=None):
+def is_remote_unlisted(self):
+if remote_list and l
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591
@@ -580,10 +580,13 @@
{
size_t byte_size = compiler_type.GetByteSize(&thread);
if (byte_size <= 4)
{
RegisterValue r0_reg_value;
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346182, @labath wrote:
> I agree with the idea in general, but I wanted to ask what is your plan with
> the android decorators: For them we use the additional `api_levels` flag,
> which d
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:597
@@ +596,3 @@
+{
+if (base_type.IsFloatingPointType(float_count, is_complex))
+{
omjavaid wrote:
> tberghammer wro
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+{
+if (!is_complex)
+{
Please check that "float_count == 1" as well (we don't want to use this code
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346408, @zturner wrote:
> In http://reviews.llvm.org/D16936#346293, @tberghammer wrote:
>
> > In http://reviews.llvm.org/D16936#346182, @labath wrote:
> >
> > > I agree with the idea in general, but I wanted to ask what is your plan
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346536, @tfiala wrote:
> > I agree but I also might consider going further where the only thing you
> > can specify is a function and we remove all arguments. Then we implement
> > functions like architectureMatches, targetOsMatches
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols are already present
Author: tberghammer
Date: Tue Feb 9 04:10:42 2016
New Revision: 260216
URL: http://llvm.org/viewvc/llvm-project?rev=260216&view=rev
Log:
Fix a typo in an xfail decorator in TestExprsChar
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
Modified:
tberghammer added a comment.
My main concern is that we have a lot of named argument for
skipIf/expectFailure and I expect it to increase even further as we support
more and more configuration. In my opinion we can have some functional style
solution as readable as the current solution with gre
tberghammer added a comment.
In http://reviews.llvm.org/D16853#347120, @omjavaid wrote:
> GDB doesnt use bkpt instruction for user debugging for the reason that it
> interferes with jtag debug probes. I am not sure if LLDB will be ever used
> with a jtag probe in near future but still a jtag pr
tberghammer added a comment.
Jason: Can you take at the change in the unwinding logic?
Comment at: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp:13653
@@ -13656,2 +13652,3 @@
const uint32_t cond = CurrentCond (m_opcode.GetOpcode32());
-return cond != 0xe && c
tberghammer abandoned this revision.
tberghammer added a comment.
The change was submitted with a different CL
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
tberghammer updated this revision to Diff 47314.
http://reviews.llvm.org/D16996
Files:
include/lldb/Core/RangeMap.h
include/lldb/Symbol/DWARFCallFrameInfo.h
include/lldb/Symbol/ObjectFile.h
include/lldb/Symbol/Symtab.h
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Obj
tberghammer added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2939
@@ +2938,3 @@
+symbol_id, // Symbol table index.
+symbol_name, // Symbol name.
+false, //
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Add new option to lldb-server to display its version
http://reviews.llvm.org/D17030
Files:
tools/lldb-server/lldb-server.cpp
Index: tools/lldb-server/lldb-server.cpp
Author: tberghammer
Date: Wed Feb 10 04:35:48 2016
New Revision: 260366
URL: http://llvm.org/viewvc/llvm-project?rev=260366&view=rev
Log:
Add new option to lldb-server to display its version
Modified:
lldb/trunk/tools/lldb-server/lldb-server.cpp
Modified: lldb/trunk/tools/lldb-server/lldb-se
tberghammer closed this revision.
tberghammer added a comment.
Comitted as http://reviews.llvm.org/rL260366
http://reviews.llvm.org/D17030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260367: Use BKPT instead of UDF for arm/thumb breakpoints
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16853?vs=46899&id=47431#toc
Repository:
rL LLVM
http://reviews.
Author: tberghammer
Date: Wed Feb 10 04:42:13 2016
New Revision: 260368
URL: http://llvm.org/viewvc/llvm-project?rev=260368&view=rev
Log:
Fix handling of the arm IT instruction in the unwinder
The IT instruction can specify condition code for up to 4 consecutive
instruction and it is used quite o
Author: tberghammer
Date: Wed Feb 10 04:42:00 2016
New Revision: 260367
URL: http://llvm.org/viewvc/llvm-project?rev=260367&view=rev
Log:
Use BKPT instead of UDF for arm/thumb breakpoints
The UDF instruction is deprecated in armv7 and in case of thumb2
instructions set it don't work well together
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260368: Fix handling of the arm IT instruction in the
unwinder (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16814?vs=46764&id=47432#toc
Repository:
rL LLVM
http://rev
Author: tberghammer
Date: Wed Feb 10 04:43:34 2016
New Revision: 260369
URL: http://llvm.org/viewvc/llvm-project?rev=260369&view=rev
Log:
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260369: Improve the handling of missing elf symtab and
missing symbol sizes (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16996?vs=47314&id=47433#toc
Repository:
rL LLV
Author: tberghammer
Date: Wed Feb 10 06:10:58 2016
New Revision: 260377
URL: http://llvm.org/viewvc/llvm-project?rev=260377&view=rev
Log:
Revert "Improve the handling of missing elf symtab and missing symbol sizes"
This reverts commit 252dda67782f2cbf838e375bce21ed4191f6d9ce.
The commit caused s
tberghammer added a comment.
Can you take a look for the 2 marked comment? I think you handling those error
scenarios incorrectly
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+if (float_count == 1 && !is_complex)
+
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good, thank you for fixing it
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
Hi Ewan,
Can you give me some instruction about how can I reproduce the issue on a
Nexus 6? (If you can't gave the information out then the disassembly of the
offending function and the fault address might gave me some hint as well)
A SIGBUS error looks a bit strange for me but my best guess is t
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Hi Ewan,
Can you give me some instruction about how can I reproduce the issue on a
Nexus 6? (If you can't gave the information out then the disassembly of the
offending function and the fault address might gave me some hint
Author: tberghammer
Date: Tue Feb 16 09:14:36 2016
New Revision: 260969
URL: http://llvm.org/viewvc/llvm-project?rev=260969&view=rev
Log:
Revert "Use BKPT instead of UDF for arm/thumb breakpoints"
This reverts commit 293c18e067d663e0fe93e6f3d800c2a4bfada2b0.
The BKPT instruction generates SIGBUS
tberghammer created this revision.
tberghammer added reviewers: ovyalov, jasonmolenda, clayborg.
tberghammer added a subscriber: lldb-commits.
Stack unwinding emulation: handle adjustment of FP
This change is improving the instruction emulation based unwinding to
handle when the frame pointer is
Author: tberghammer
Date: Thu Feb 18 05:12:18 2016
New Revision: 261205
URL: http://llvm.org/viewvc/llvm-project?rev=261205&view=rev
Log:
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols ar
Author: tberghammer
Date: Fri Feb 19 04:59:25 2016
New Revision: 261318
URL: http://llvm.org/viewvc/llvm-project?rev=261318&view=rev
Log:
Stack unwinding emulation: handle adjustment of FP
This change is improving the instruction emulation based unwinding to
handle when the frame pointer is adjus
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261318: Stack unwinding emulation: handle adjustment of FP
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17295?vs=48078&id=48472#toc
Repository:
rL LLVM
http://reviews
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clay.chang.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Handle the case when a variable is only valid in part of the enclosing scope
DWARF stores this information in the DW
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for handling absolute symbols in ELF
Most address represented in lldb as section plus offset and handling of
absolute addresses is problematic in several lo
tberghammer requested a review of this revision.
tberghammer added a comment.
There is a (minor) difference between a variable being out of scope and having
no location information. Being out of scope means that the variable hasn't
declared yet while having no location information means that the
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D17510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Tue Feb 23 05:35:38 2016
New Revision: 261630
URL: http://llvm.org/viewvc/llvm-project?rev=261630&view=rev
Log:
XFAIL TestInlines for Linux with gcc
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestInlines.py
Modified:
lldb/trunk/packages/Pyth
tberghammer added a comment.
We have 2 (+1) independent dimension here:
1. List of ranges where the variable is in scope
2. List of ranges where the variable is available
3. Format of the location list (it is more of an implementation details because
of a format change in dwarf5)
To represent a
tberghammer added a comment.
I am not sure I agree with the following starting point of the CL (I know about
the similar functionality in GDB) and even if we agree in it I think you are
handling a very small fraction of the problems.
> LLDB should treat all instructions in the atomic sequence a
tberghammer added a comment.
I can live with that but I still think the scope information belongs to the
variable and not to the DWARF expression representing it's location. As far as
I see keeping the information inside the variable have lower memory impact
(assuming an empty list means full s
tberghammer added a comment.
In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
> If we do so (and that breakpoint is hit) then continuing from breakpoint
> address will cause "SC" to fail due to a breakpoint excepti
tberghammer updated this revision to Diff 48908.
tberghammer added a comment.
I added the memory optimization to represent the case when no DW_AT_start_scope
is specified as an empty range map. This way the memory impact for C/C++ will
be only an empty std::vector per variable.
Regarding the lo
tberghammer updated this revision to Diff 48947.
tberghammer marked an inline comment as done.
http://reviews.llvm.org/D17450
Files:
include/lldb/lldb-enumerations.h
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mac
tberghammer added a comment.
In http://reviews.llvm.org/D17450#357477, @clayborg wrote:
> We should probably make it such that if a section has the type
> eSectionTypeAbsoluteAddress that we do the right thing inside the following
> functions:
> Section::GetLoadBaseAddress(...);
> Section::Sl
Author: tberghammer
Date: Thu Feb 25 06:23:37 2016
New Revision: 261858
URL: http://llvm.org/viewvc/llvm-project?rev=261858&view=rev
Log:
Handle the case when a variable is only valid in part of the enclosing scope
DWARF stores this information in the DW_AT_start_scope attribute. This
CL add supp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261858: Handle the case when a variable is only valid in
part of the enclosing scope (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17449?vs=48908&id=49034#toc
Repository:
Author: tberghammer
Date: Thu Feb 25 06:23:43 2016
New Revision: 261859
URL: http://llvm.org/viewvc/llvm-project?rev=261859&view=rev
Log:
Add support for handling absolute symbols in ELF
Most address represented in lldb as section plus offset and handling of
absolute addresses is problematic in s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261859: Add support for handling absolute symbols in ELF
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17450?vs=48947&id=49036#toc
Repository:
rL LLVM
http://reviews.l
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_OP_push_object_address in dwarf expressions
Additionally fix the type of some dwarf expression where we had a confusion
between scalar and load addr
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Add a set of new plugins to handle Java debugging
The purpose of these plugins is to make LLDB capable of debugging ja
tberghammer marked 2 inline comments as done.
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
granata.enrico wrote:
> Is there any reason to use hardcod
Author: tberghammer
Date: Fri Feb 26 08:21:10 2016
New Revision: 262014
URL: http://llvm.org/viewvc/llvm-project?rev=262014&view=rev
Log:
Add support for DW_OP_push_object_address in dwarf expressions
Additionally fix the type of some dwarf expression where we had a
confusion between scalar and l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262014: Add support for DW_OP_push_object_address in dwarf
expressions (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17604?vs=49047&id=49179#toc
Repository:
rL LLVM
ht
Author: tberghammer
Date: Fri Feb 26 08:21:27 2016
New Revision: 262016
URL: http://llvm.org/viewvc/llvm-project?rev=262016&view=rev
Log:
Fix address class lookup for absolute symbols
Modified:
lldb/trunk/source/Symbol/ObjectFile.cpp
Modified: lldb/trunk/source/Symbol/ObjectFile.cpp
URL:
ht
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL262015: Add a set of new plugins to handle Java debugging
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17616?vs=49089&id=491
Author: tberghammer
Date: Fri Feb 26 09:33:32 2016
New Revision: 262023
URL: http://llvm.org/viewvc/llvm-project?rev=262023&view=rev
Log:
Revert part of rL262014 as it caused issues on gcc-i386
Modified:
lldb/trunk/source/Expression/DWARFExpression.cpp
Modified: lldb/trunk/source/Expression/
Author: tberghammer
Date: Fri Feb 26 09:47:35 2016
New Revision: 262028
URL: http://llvm.org/viewvc/llvm-project?rev=262028&view=rev
Log:
Add new java plugin files to the xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (it would be nice if we can split GetReturnValueObjectImpl to
multiple function as it starts to become pretty big and hard to read but I
don't think we shouldn't do it as
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good but please verify that the new test is passes on other architectures
and XFAIL the test accordingly.
If you have to XFAIL something then I would prefer to split this test
Author: tberghammer
Date: Tue Mar 1 09:01:05 2016
New Revision: 262339
URL: http://llvm.org/viewvc/llvm-project?rev=262339&view=rev
Log:
DWARFExpression: Don't resolve load address in DW_OP_plus
If we have a TargetLoadAddress on the top of the DWARF stack then a
DW_OP_plus or a DW_OP_plus_ucons
Author: tberghammer
Date: Wed Mar 2 06:42:43 2016
New Revision: 262482
URL: http://llvm.org/viewvc/llvm-project?rev=262482&view=rev
Log:
Upgrade the arm/thumb architecture used by the disassembler
Previously we were using thumbv7 and armv8.1a what ended up showing a
few undefined instruction whe
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Add reverse file remapping for breakpoint set
LLDB can remap a source file to a new directory based on the
"target.sorce-map" to handle the usecase when the source code
tberghammer added a comment.
It is a good point. I don't think displaying incorrect path for a breakpoint is
a big issue so I don't plan to address it now but we should do it at some point.
http://reviews.llvm.org/D17848
___
lldb-commits mailing li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262711: Add reverse file remapping for breakpoint set
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17848?vs=49732&id=49812#toc
Repository:
rL LLVM
http://reviews.llvm
Author: tberghammer
Date: Fri Mar 4 05:26:44 2016
New Revision: 262711
URL: http://llvm.org/viewvc/llvm-project?rev=262711&view=rev
Log:
Add reverse file remapping for breakpoint set
LLDB can remap a source file to a new directory based on the
"target.sorce-map" to handle the usecase when the so
Author: tberghammer
Date: Tue Mar 8 05:43:56 2016
New Revision: 262923
URL: http://llvm.org/viewvc/llvm-project?rev=262923&view=rev
Log:
Try to fix windows build after rL262863
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
Modified:
lldb/trunk/source/P
Author: tberghammer
Date: Tue Mar 8 07:33:14 2016
New Revision: 262925
URL: http://llvm.org/viewvc/llvm-project?rev=262925&view=rev
Log:
Fix log in Broadcaster causing a crash
Modified:
lldb/trunk/source/Core/Broadcaster.cpp
Modified: lldb/trunk/source/Core/Broadcaster.cpp
URL:
http://llvm
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D18146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer added a comment.
You can pass extra compiler flags to the test suit with the -E option (haven't
tested it). I would suggest to use that option and then xfail based on it
(xfail if extra flags contain -foo).
In long term I would prefer to not add a new option to expectedFailureAll bu
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:334
@@ +333,3 @@
+virtual std::unique_ptr
+GetDWOForCompileUnit(DWARFCompileUnit &dw
401 - 500 of 725 matches
Mail list logo
