tberghammer added a comment.
Can you take a look for the 2 marked comment? I think you handling those error
scenarios incorrectly
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+ if (float_count == 1 && !is_complex)
+ {
+ ProcessSP process_sp (thread.GetProcess());
----------------
?
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:636
@@ +635,3 @@
+ if (data_offset == byte_size)
+ {
+ DataExtractor data;
----------------
?
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:650
@@ -582,2 +649,3 @@
+
if (byte_size <= 4)
{
----------------
I think this should be an "else if" to fix the issue I mentioned in line 636
http://reviews.llvm.org/D16975
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
