tberghammer added inline comments. ================ Comment at: include/lldb/Core/EmulateInstruction.h:390 @@ +389,3 @@ + typedef uint32_t InstructionCondition; + static const InstructionCondition UnconditionalCondition = UINT32_MAX; + ---------------- clayborg wrote: > It is nice to tell when something is a constant (prefixed with "k"), a > member variable (prefixed with "m_"), typenames are camel case, variables > should be lower cased with underscores. That is our current coding convention. > > I would like to see this be > > ``` > static const InstructionCondition k_unconditional_condition = UINT32_MAX; > ``` > It is a public, static member variable so I think we should use CamelCase and not snake_case and I don't see where I can add a k prefix into it (KInstructionCondition?) Also as (almost) all static member is cons inside LLDB I don't think it will be confusing
http://reviews.llvm.org/D16814 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
