Author: spyffe
Date: Wed Apr 27 20:36:21 2016
New Revision: 267833
URL: http://llvm.org/viewvc/llvm-project?rev=267833&view=rev
Log:
Fixed a bug where const this would cause parser errors about $__lldb_expr.
In templated const functions, trying to run an expression would produce the
error
error:
Pavel,
thank you for reverting this. I have no idea how I was able to run the
testsuite with this code still in there – I’ll
Sean
> On Apr 28, 2016, at 1:16 AM, Pavel Labath via lldb-commits
> wrote:
>
> Author: labath
> Date: Thu Apr 28 03:16:19 2016
> New Revision: 267861
>
> URL: http:
Apr 29, 2016, at 10:09 AM, Sean Callanan via lldb-commits
> wrote:
>
> Pavel,
>
> thank you for reverting this. I have no idea how I was able to run the
> testsuite with this code still in there – I’ll
>
> Sean
>
>> On Apr 28, 2016, at 1:16 AM, Pave
Author: spyffe
Date: Fri Apr 29 13:09:03 2016
New Revision: 268083
URL: http://llvm.org/viewvc/llvm-project?rev=268083&view=rev
Log:
[fix] Fixed a bug where const this would cause parser errors about $__lldb_expr.
In templated const functions, trying to run an expression would produce the
error
Author: spyffe
Date: Mon May 2 16:15:31 2016
New Revision: 268307
URL: http://llvm.org/viewvc/llvm-project?rev=268307&view=rev
Log:
Import block pointers from DWARF as Clang block pointers, not as structs.
Also added a data formatter that presents them as structs if you use frame
variable to loo
Author: spyffe
Date: Tue May 3 15:36:06 2016
New Revision: 268433
URL: http://llvm.org/viewvc/llvm-project?rev=268433&view=rev
Log:
Added a testcase for the ptr_refs tool so we catch if it stops working.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/ptr_refs/
lldb/trun
Author: spyffe
Date: Wed May 4 16:42:55 2016
New Revision: 268559
URL: http://llvm.org/viewvc/llvm-project?rev=268559&view=rev
Log:
Intentionally leak the ASTSourceMap instead of destroying it when LLDB quits.
Modified:
lldb/trunk/source/Symbol/ClangExternalASTSourceCommon.cpp
Modified: l
spyffe added a subscriber: spyffe.
spyffe added a comment.
Ah… you know me too well.
Looking at this now.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This patch is fine. I especially appreciate the time you took making the
IRInterpreter properly testable. I will use this myself.
Comment at: source/Commands/CommandObjectE
Author: spyffe
Date: Mon May 9 16:13:27 2016
New Revision: 268970
URL: http://llvm.org/viewvc/llvm-project?rev=268970&view=rev
Log:
Fixed multiline expressions, and removed some dead code.
IOHandlerLinesUpdated() does nothing, and IOHandlerIsInputComplete should be
implemented but isn't. This m
Author: spyffe
Date: Mon May 9 16:14:18 2016
New Revision: 268971
URL: http://llvm.org/viewvc/llvm-project?rev=268971&view=rev
Log:
Added a testcase that verifies that multiline expressions work.
Added:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/multiline/
lldb/trunk/p
Author: spyffe
Date: Mon May 16 15:55:10 2016
New Revision: 269698
URL: http://llvm.org/viewvc/llvm-project?rev=269698&view=rev
Log:
Test diamond virtual inheritance in top-level expressions.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/test.cpp
Modified:
Author: spyffe
Date: Mon May 16 16:11:21 2016
New Revision: 269704
URL: http://llvm.org/viewvc/llvm-project?rev=269704&view=rev
Log:
Fixed and re-enabled the Clang modules testcase.
Macros work again after Clang r269554. This testcase just needed some small
tweaks to get it going again.
Modifie
spyffe created this revision.
spyffe added reviewers: paulherman, sivachandra, jingham.
spyffe added a subscriber: lldb-commits.
spyffe set the repository for this revision to rL LLVM.
`m_decl_objects` is not sound when there are multiple instances of an inline
function. The reason is that the `
spyffe added a comment.
Added a few inline comments to make the patch's intent more understandable.
Comment at: include/lldb/Symbol/ClangASTContext.h:1221
@@ -1220,3 +1214,2 @@
boolm_can_evaluate_expressions;
-std::map>
Author: spyffe
Date: Thu May 19 14:23:37 2016
New Revision: 270097
URL: http://llvm.org/viewvc/llvm-project?rev=270097&view=rev
Log:
Fixed a crash if a FunctionDecl couldn't be imported.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
Modified:
lldb/tru
spyffe updated this revision to Diff 57879.
spyffe added a comment.
Added a test case,
Repository:
rL LLVM
http://reviews.llvm.org/D20395
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
include/lldb/Symbol/GoASTContext.h
include/lldb/Symbol/JavaASTCont
Author: spyffe
Date: Mon May 23 13:30:59 2016
New Revision: 270474
URL: http://llvm.org/viewvc/llvm-project?rev=270474&view=rev
Log:
Removed the m_decl_objects map from ClangASTContext.
m_decl_objects is problematic because it assumes that each VarDecl has a unique
variable associated with it. T
Author: spyffe
Date: Thu Jun 2 12:59:47 2016
New Revision: 271551
URL: http://llvm.org/viewvc/llvm-project?rev=271551&view=rev
Log:
Fixed a problem where we couldn't call extern "C" functions.
Some compilers do not mark up C++ functions as extern "C" in the DWARF, so LLDB
has to fall back (if it
spyffe created this revision.
spyffe added a reviewer: tfiala.
spyffe added a subscriber: lldb-commits.
spyffe set the repository for this revision to rL LLVM.
To eliminate problems where 'lldbinline.py'-generated Makefiles are re-used,
I've standardized the generation of them. The testsuite now
Author: spyffe
Date: Tue Jun 7 12:22:18 2016
New Revision: 272024
URL: http://llvm.org/viewvc/llvm-project?rev=272024&view=rev
Log:
Make lldbinline.py regenerate the Makefile each time it builds.
If a lldbinline test's source file changed language, then the Makefile wasn't
updated. This was a p
spyffe created this revision.
spyffe added reviewers: tfiala, clayborg.
spyffe added a subscriber: lldb-commits.
spyffe set the repository for this revision to rL LLVM.
Right now the default initial address is 0x0, which is very problematic on
embedded targets where that's the CPU's initializatio
Author: spyffe
Date: Thu Jun 9 15:22:25 2016
New Revision: 272301
URL: http://llvm.org/viewvc/llvm-project?rev=272301&view=rev
Log:
Updated the FindSpace() algorithm to avoid the 0 page when it's unsafe.
Previously we eliminated the randomized scheme for finding memory when the
underlying proces
Author: spyffe
Date: Thu Jun 9 17:22:40 2016
New Revision: 272320
URL: http://llvm.org/viewvc/llvm-project?rev=272320&view=rev
Log:
Fixed a problem in IRMemoryMap where the flag to zero out memory was ignored.
Modified:
lldb/trunk/source/Expression/IRMemoryMap.cpp
Modified: lldb/trunk/sourc
Author: spyffe
Date: Mon Jun 20 18:01:11 2016
New Revision: 273211
URL: http://llvm.org/viewvc/llvm-project?rev=273211&view=rev
Log:
Test that lldb calls the right 'printf' even when a 'printf' method exists.
This test is currently failing. We have a bug for it, as noted.
Added:
lldb/trunk/
Author: spyffe
Date: Wed Jun 22 12:32:17 2016
New Revision: 273445
URL: http://llvm.org/viewvc/llvm-project?rev=273445&view=rev
Log:
Don't omit `this' from expression args if it couldn't be read, but warn loudly.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression
Author: spyffe
Date: Thu Jun 23 17:18:08 2016
New Revision: 273622
URL: http://llvm.org/viewvc/llvm-project?rev=273622&view=rev
Log:
Don't run the top-level expression test case with -gmodules.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExp
Author: spyffe
Date: Thu Jun 23 19:24:40 2016
New Revision: 273632
URL: http://llvm.org/viewvc/llvm-project?rev=273632&view=rev
Log:
Handle variadic Objective-C methods from DWARF correctly.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/variadic_methods/
lldb/trunk/package
Author: spyffe
Date: Fri Jun 24 15:41:18 2016
New Revision: 273718
URL: http://llvm.org/viewvc/llvm-project?rev=273718&view=rev
Log:
Added a test case for bitfield ivars. It currently fails.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/
lldb/trunk/packages
Author: spyffe
Date: Thu Jun 30 13:00:32 2016
New Revision: 274254
URL: http://llvm.org/viewvc/llvm-project?rev=274254&view=rev
Log:
Removed the redundant "%d errors parsing expression" error. Nobody keeps score.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/T
Author: spyffe
Date: Tue Jul 5 17:06:01 2016
New Revision: 274580
URL: http://llvm.org/viewvc/llvm-project?rev=274580&view=rev
Log:
Fixed a bug where we report a single type multiple times in namespaces.
Also added a testcase.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/name
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This code has been eliminated as -part of a refactoring of the way IRForTarget
works.
I'm sorry that I didn't get to this review earlier, but at this point the patch
probably isn't w
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Sorry for getting to this review so late.
This looks all right, and pretty conservative. As long as the test suite is
okay with it, this looks fine!
Thanks for the test case, too.
Repository
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yes, we should follow the same rules as in regular lookup for these contexts.
If the test suite is happy here, I'm happy.
http://reviews.llvm.org/D13350
__
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
I'm concerned about the performance implications here, because
`FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just
for ones that would fail unless we did
Author: spyffe
Date: Tue Jul 12 17:42:07 2016
New Revision: 275223
URL: http://llvm.org/viewvc/llvm-project?rev=275223&view=rev
Log:
Mark TagDecls as having external visible storage, like ContainerDecls.
The lookup tables can get out of date during the lifetime of the object so we
need to preserv
Argh, this isn’t what I wanted to commit AT ALL.
Sorry folks. I’ll fix this momentarily.
Thanks to Jim Ingham for pointing it out.
Sean
> On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits
> wrote:
>
> Author: spyffe
> Date: Tue Jul 12 17:42:07 2016
> New Revisio
Author: spyffe
Date: Tue Jul 12 18:31:42 2016
New Revision: 275237
URL: http://llvm.org/viewvc/llvm-project?rev=275237&view=rev
Log:
Revert r275223, which committed the wrong thing.
Modified:
lldb/trunk/lldb.xcworkspace/contents.xcworkspacedata
Modified: lldb/trunk/lldb.xcworkspace/contents.
Reverted with r275237.
Sean
> On Jul 12, 2016, at 4:33 PM, Sean Callanan wrote:
>
> Argh, this isn’t what I wanted to commit AT ALL.
> Sorry folks. I’ll fix this momentarily.
> Thanks to Jim Ingham for pointing it out.
>
> Sean
>
>> On Jul 12, 2016, at 3
Author: spyffe
Date: Fri Jul 15 19:18:24 2016
New Revision: 275652
URL: http://llvm.org/viewvc/llvm-project?rev=275652&view=rev
Log:
Fixed the location of the Swift bindings in the Xcode build.
$BUILT_PRODUCTS_DIR is usually the same as $CONFIGURATION_BUILD_DIR, but differs
when LLDB is being bui
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This looks fine. How tricky would it be to make a test case for a reproduction
scenario?
https://reviews.llvm.org/D21328
___
lldb-com
Author: spyffe
Date: Thu Aug 18 12:45:50 2016
New Revision: 279098
URL: http://llvm.org/viewvc/llvm-project?rev=279098&view=rev
Log:
Fixed a problem where we failed to get the size of an Objective-C type.
Modified:
lldb/trunk/source/Expression/Materializer.cpp
Modified: lldb/trunk/source/E
Author: spyffe
Date: Fri Aug 26 13:12:39 2016
New Revision: 279850
URL: http://llvm.org/viewvc/llvm-project?rev=279850&view=rev
Log:
Don't crash when trying to capture persistent variables in a block.
Reports an error instead. We can fix this later to make persistent variables
work, but right no
Author: spyffe
Date: Fri Aug 26 18:48:03 2016
New Revision: 279884
URL: http://llvm.org/viewvc/llvm-project?rev=279884&view=rev
Log:
Fixed a bad lldbassert() condition.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins/E
Author: spyffe
Date: Fri Aug 26 19:20:38 2016
New Revision: 279894
URL: http://llvm.org/viewvc/llvm-project?rev=279894&view=rev
Log:
The error stream in IRForTarget is never null, so use it instead of the log.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cp
Author: spyffe
Date: Fri Aug 26 19:35:37 2016
New Revision: 279896
URL: http://llvm.org/viewvc/llvm-project?rev=279896&view=rev
Log:
Fixed the location of a conditional to make the following code clearer.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Mo
Author: spyffe
Date: Mon Sep 5 23:48:36 2016
New Revision: 280692
URL: http://llvm.org/viewvc/llvm-project?rev=280692&view=rev
Log:
Added the "frame diagnose" command and use its output to make crash info better.
When a process stops due to a crash, we get the crashing instruction and the
crashi
Author: spyffe
Date: Tue Sep 13 16:18:27 2016
New Revision: 281398
URL: http://llvm.org/viewvc/llvm-project?rev=281398&view=rev
Log:
Cleaned up some of the "frame diagnose" code to use Operands as currency.
Also added some utility functions around Operands to make code easier and more
compact to
Author: spyffe
Date: Tue Sep 13 19:48:19 2016
New Revision: 281428
URL: http://llvm.org/viewvc/llvm-project?rev=281428&view=rev
Log:
Cleaned up the code that handles function return addresses in "frame diagnose."
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/T
Author: spyffe
Date: Wed Sep 14 15:29:57 2016
New Revision: 281534
URL: http://llvm.org/viewvc/llvm-project?rev=281534&view=rev
Log:
Cleaned up a little bit of redundant code in 'frame diagnose.`
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.
Okay, one sec.
Sean
> On Sep 14, 2016, at 1:40 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 14, 2016 at 1:38 PM Sean Callanan via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
>
> Instruction::Operand *origin_operand = nullptr;
Author: spyffe
Date: Wed Sep 14 15:58:31 2016
New Revision: 281536
URL: http://llvm.org/viewvc/llvm-project?rev=281536&view=rev
Log:
Replaced two instances of std::function with auto.
Thanks to Zachary Turner for the suggestion. It's distasteful that the actual
type of the lambda can't be spelle
Author: spyffe
Date: Wed Sep 14 16:54:28 2016
New Revision: 281545
URL: http://llvm.org/viewvc/llvm-project?rev=281545&view=rev
Log:
More cleanup in `frame diagnose,` eliminating a bunch of messy cases.
Modified:
lldb/trunk/include/lldb/Core/Disassembler.h
lldb/trunk/source/Core/Disassemb
spyffe added a subscriber: spyffe.
spyffe added a comment.
I like this concept a lot, and I think it's great for testcases that actually
need to interact with the command line.
I'm concerned, though, that the separation of input from command files makes
tests more complex to write. One thing th
How different is that really from
(lldb) script lldb.frame.FindVariable("argc").GetValue()
'1'
(lldb) script lldb.process.GetNumThreads()
1
(lldb) script lldb.process.GetThreadAtIndex(0).GetThreadID()
3514809
? If it's developer-only, then this is even fairly well-documented using e.g.
"script
I agree completely with tackling the easy stuff first.
That said, the easy stuff (probably >50% of the testsuite) doesn't even require
command-line interaction and is just of the form "stop here, run this one
expression, maybe print this variable using 'frame variab'e'"
I would argue that we can
Author: spyffe
Date: Mon Sep 19 17:06:12 2016
New Revision: 281943
URL: http://llvm.org/viewvc/llvm-project?rev=281943&view=rev
Log:
Fixed the build by changing a couple of const char *s to StringRefs.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
lldb/trunk/source/Host/macosx/HostInfoM
Author: spyffe
Date: Mon Sep 26 15:18:51 2016
New Revision: 282434
URL: http://llvm.org/viewvc/llvm-project?rev=282434&view=rev
Log:
Added a setting that enables saving all .o files from a given JIT expression.
This allows debugging of the JIT and other analyses of the internals of the
expression
Author: spyffe
Date: Wed Sep 28 19:16:37 2016
New Revision: 282653
URL: http://llvm.org/viewvc/llvm-project?rev=282653&view=rev
Log:
Introduced a null check to avoid a crash in a test on i386.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.cpp
Author: spyffe
Date: Wed Sep 28 19:45:33 2016
New Revision: 282657
URL: http://llvm.org/viewvc/llvm-project?rev=282657&view=rev
Log:
Fixed TestObjCStructArgument/i386; expressions can now call ObjC class methods.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
Author: spyffe
Date: Thu Sep 29 12:57:33 2016
New Revision: 282741
URL: http://llvm.org/viewvc/llvm-project?rev=282741&view=rev
Log:
To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleO
Author: spyffe
Date: Thu Sep 29 16:43:31 2016
New Revision: 282787
URL: http://llvm.org/viewvc/llvm-project?rev=282787&view=rev
Log:
Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestO
Author: spyffe
Date: Thu Sep 29 17:01:11 2016
New Revision: 282794
URL: http://llvm.org/viewvc/llvm-project?rev=282794&view=rev
Log:
Don't expect new-style Objective-C literals to work on i386 with the V1 runtime.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-new-syntax/
Author: spyffe
Date: Fri Sep 30 11:02:28 2016
New Revision: 282869
URL: http://llvm.org/viewvc/llvm-project?rev=282869&view=rev
Log:
Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-runtime-ivars/
Author: spyffe
Date: Fri Sep 30 13:44:43 2016
New Revision: 282898
URL: http://llvm.org/viewvc/llvm-project?rev=282898&view=rev
Log:
Fixed several i386 Objective-C tests by completing objects, not their pointers.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/sou
Author: spyffe
Date: Fri Sep 30 15:46:09 2016
New Revision: 282943
URL: http://llvm.org/viewvc/llvm-project?rev=282943&view=rev
Log:
Adding ivars in class extensions isn't supported on i386; skip a test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/persist_objc_poin
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
The expression parser side fixes look fine to me, and they remove some hacks
and make things slightly more elegant.
Obviously the ideal would be to have GCC generate full debug info, but to me
spyffe added a comment.
I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears
to generate a new set of options from whole cloth rather than using the
existing set as a starting point.
Specifically, since your use case is wanting to override the calling
convention, I thi
Author: spyffe
Date: Wed Jan 13 13:23:30 2016
New Revision: 257653
URL: http://llvm.org/viewvc/llvm-project?rev=257653&view=rev
Log:
Fixed a problem where the Xcode build put lldb's __init__.py in the wrong place.
Most of the time CONFIGURATION_BUILD_DIR and BUILT_PRODUCTS_DIR are the same,
but t
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This looks fine. Thanks for paying attention to the details!
http://reviews.llvm.org/D16155
___
lldb-commits mailing list
lldb-commits@lists.llv
spyffe added a comment.
What I'm getting at here is: OverrideExprOptions just subclasses
clang::TargetOptions if I'm not mistaken. What I might suggest is
virtual bool
OverrideExprOptions (clang::TargetOptions &options)
{
return false; // return true if you actually modified "options"
}
Yo
Author: spyffe
Date: Thu Jan 14 12:59:49 2016
New Revision: 257786
URL: http://llvm.org/viewvc/llvm-project?rev=257786&view=rev
Log:
Fixed a crasher when dealing with table entries that have blank names.
This can happen with -gmodules tables when an anonymous struct is referred to.
Modified:
Author: spyffe
Date: Thu Jan 14 15:46:09 2016
New Revision: 257812
URL: http://llvm.org/viewvc/llvm-project?rev=257812&view=rev
Log:
Enable the use of modules in the expression parser by default.
If your program refers to modules (as indicated in DWARF) we will now try to
load these modules and g
Author: spyffe
Date: Thu Jan 14 16:05:26 2016
New Revision: 257818
URL: http://llvm.org/viewvc/llvm-project?rev=257818&view=rev
Log:
Removed a redundant function call after review.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Modified: lldb/trunk/source/Plugins/Sy
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
That looks fine to me as far as it goes, but it doesn't cover other places
where $ is used in function names, e.g. the name of the expression itself, and
classes it's placed in. Cou
Author: spyffe
Date: Tue Jan 19 15:48:25 2016
New Revision: 258194
URL: http://llvm.org/viewvc/llvm-project?rev=258194&view=rev
Log:
Removed a bunch of spurious files from the man page Copy Files build phase.
A few files were accidentally added to the Copy Files build phase for our man
page, and
Author: spyffe
Date: Wed Jan 20 17:12:39 2016
New Revision: 258365
URL: http://llvm.org/viewvc/llvm-project?rev=258365&view=rev
Log:
Fixed some #ifdefs. We were erroneously not supporting certain simulators.
We had some #ifdefs that were looking for the wrong #defines and as a result
debugserver
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Thank you for that clarification. In that case, I think this patch is fine as
it is.
Repository:
rL LLVM
http://reviews.llvm.org/D14111
___
Author: spyffe
Date: Mon Jan 25 19:15:57 2016
New Revision: 258763
URL: http://llvm.org/viewvc/llvm-project?rev=258763&view=rev
Log:
Fix the lldbinline tests so they make well-formed Makefiles.
lldbinline tests previously did not run correctly unless there was already a
Makefile for them. This w
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Siva, this is a clever and self-contained solution to a problem that's annoyed
us a great deal for a while now. I have a few minor quibbles about
implementation but overall this is
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yeah, this looks much cleaner. I'm fine with this.
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Siva, I've inlined my comments. I believe there's a misunderstanding about
what role //this// has in the patched version of GetUniqueNamespaceDeclaration.
In fact, as I argue in my
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
I suggested a name change; just fix that and I think we're good to go.
Comment at: source/Symbol/ClangASTContext.cpp:1893
@@ +1892,3 @@
+{
+ClangASTContext *ast_ctx = Clan
Author: spyffe
Date: Wed Feb 10 16:00:32 2016
New Revision: 260445
URL: http://llvm.org/viewvc/llvm-project?rev=260445&view=rev
Log:
When importing Objective-C protocols, mark them as having external decls.
We already do this for Objective-C interfaces, but we never handled protocols
because the
Author: spyffe
Date: Fri Feb 12 12:42:00 2016
New Revision: 260699
URL: http://llvm.org/viewvc/llvm-project?rev=260699&view=rev
Log:
Renamed TestRdar12991846 to the more descriptive TestUnicodeLiterals.
Test cases should not be named after PR or Radar numbers. It's fine to
annotate them with the
Author: spyffe
Date: Fri Feb 12 13:45:31 2016
New Revision: 260713
URL: http://llvm.org/viewvc/llvm-project?rev=260713&view=rev
Log:
Make Target::CalculateProcess() return a sensible result.
The Calculate* functions in general should not derive any information that isn't
implicit, but for Target
Author: spyffe
Date: Fri Feb 12 13:47:57 2016
New Revision: 260715
URL: http://llvm.org/viewvc/llvm-project?rev=260715&view=rev
Log:
Objective-C++ is a kind of C++.
Modified:
lldb/trunk/source/Target/Language.cpp
Modified: lldb/trunk/source/Target/Language.cpp
URL:
http://llvm.org/viewvc/ll
Author: spyffe
Date: Fri Feb 12 15:11:25 2016
New Revision: 260734
URL: http://llvm.org/viewvc/llvm-project?rev=260734&view=rev
Log:
Centralized symbol lookup in IRExecutionUnit, and fixed the code model.
I'm preparing to remove symbol lookup from IRForTarget, where it constitutes a
dreadful hack
Author: spyffe
Date: Fri Feb 12 15:16:58 2016
New Revision: 260735
URL: http://llvm.org/viewvc/llvm-project?rev=260735&view=rev
Log:
IRInterpreter now recognizes expressions with constants it doesn't handle.
If an instruction has a constant that IRInterpreter doesn't know how to deal
with (say, a
Author: spyffe
Date: Fri Feb 12 15:55:05 2016
New Revision: 260747
URL: http://llvm.org/viewvc/llvm-project?rev=260747&view=rev
Log:
Disable recognition of "using" declarations at translation-unit level.
Currently CountDeclLevels uses the ASTs which have no distinction between
separate translatio
Author: spyffe
Date: Fri Feb 12 17:55:13 2016
New Revision: 260767
URL: http://llvm.org/viewvc/llvm-project?rev=260767&view=rev
Log:
Fix stripping of _ when looking for symbols in IRExecutionUnit.
Previously we would try both versions of a symbol -- the one with _ in it and
the one without -- in
Author: spyffe
Date: Fri Feb 12 18:01:46 2016
New Revision: 260768
URL: http://llvm.org/viewvc/llvm-project?rev=260768&view=rev
Log:
Removed many JIT workarounds from IRForTarget.
Since IRExecutionUnit is now capable of looking up symbols, and the JIT is up to
the task of generating the appropria
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit, this looks like good cleanup. If it passes the
testsuite, feel free to commit after addressing the inline comment.
Comment at: source/Plugins/Express
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Looks fine to me, but let's put in an assertion to make sure our assumptions in
making this change are not violated.
Comment at: source/Expression/Materializer.cpp:
Author: spyffe
Date: Mon Feb 22 18:51:52 2016
New Revision: 261598
URL: http://llvm.org/viewvc/llvm-project?rev=261598&view=rev
Log:
Fixed a problem where the DWARF for inline functions was mis-parsed.
Inline functions in DWARF have AT_abstract_origin set, but we only handled that
if the function
Author: spyffe
Date: Mon Feb 22 18:52:34 2016
New Revision: 261599
URL: http://llvm.org/viewvc/llvm-project?rev=261599&view=rev
Log:
Actually commit the test for r261598.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestInlines.py
Modified:
lldb/trunk/packages/Python/ll
Author: spyffe
Date: Tue Feb 23 17:09:06 2016
New Revision: 261704
URL: http://llvm.org/viewvc/llvm-project?rev=261704&view=rev
Log:
When looking for symbols, find load addresses in a more robust way.
IRExecutionUnit previously replicated a bunch of logic that already
existed elsewhere for the pu
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Aside from one minor object ownership issue this is good to go. Change the
`IRExecutionUnitSP` to an `IRExecutionUnit&` and you have my blessing!
Comment at: source/Expressi
spyffe accepted this revision.
spyffe added a comment.
Looks good to me. Thanks for the fix!
Comment at: source/Expression/IRExecutionUnit.cpp:802
@@ -801,3 +801,3 @@
-load_address =
candidate_sc.symbol->ResolveCallableAddress(*target);
+l
Author: spyffe
Date: Tue Mar 8 12:58:48 2016
New Revision: 262950
URL: http://llvm.org/viewvc/llvm-project?rev=262950&view=rev
Log:
Made self.expect() errors a little more readable in the testsuite.
self.expect() had two problems:
- If there was a substrs argument, then it overwrote the variabl
101 - 200 of 260 matches
Mail list logo
