spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit, this looks like good cleanup. If it passes the
testsuite, feel free to commit after addressing the inline comment.
================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:522
@@ -528,5 +521,3 @@
- for (diag_iterator = diag_buf->warn_begin();
- diag_iterator != diag_buf->warn_end();
- ++diag_iterator)
- stream.Printf("warning: %s\n", (*diag_iterator).second.c_str());
+ for (auto warn = diag_buf->warn_begin(), warn_end = diag_buf->warn_end();
warn != warn_end; ++warn)
+ stream.Printf("warning: %s\n", warn->second.c_str());
----------------
I'm okay with use of //auto// when the type is really onerous to express in
code, but in this case //TextDiagnosticBuffer::const_iterator// is pretty
compact, and makes the type of //warn// more obvious. Could we use that
instead of //auto//?
http://reviews.llvm.org/D17273
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
