[Lldb-commits] [lldb] r274254 - Removed the redundant "%d errors parsing expression" error. Nobody keeps score.

[Sean Callanan via lldb-commits]

Author: spyffe
Date: Thu Jun 30 13:00:32 2016
New Revision: 274254

URL: http://llvm.org/viewvc/llvm-project?rev=274254&view=rev
Log:
Removed the redundant "%d errors parsing expression" error.  Nobody keeps score.

<rdar://problem/24306284>

Modified:
    
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp

Modified: 
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py?rev=274254&r1=274253&r2=274254&view=diff
==============================================================================
--- 
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py 
(original)
+++ 
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py 
Thu Jun 30 13:00:32 2016
@@ -36,9 +36,9 @@ class MiVarTestCase(lldbmi_testcase.MiTe
 
         # Print non-existant variable
         self.runCmd("-var-create var1 * undef")
-        self.expect("\^error,msg=\"error: use of undeclared identifier 
\'undef\'\\\\nerror: 1 error parsing expression\\\\n\"")
+        self.expect("\^error,msg=\"error: use of undeclared identifier 
\'undef\'\\\\n\"")
         self.runCmd("-data-evaluate-expression undef")
-        self.expect("\^error,msg=\"error: use of undeclared identifier 
\'undef\'\\\\nerror: 1 error parsing expression\\\\n\"")
+        self.expect("\^error,msg=\"error: use of undeclared identifier 
\'undef\'\\\\n\"")
 
         # Print global "g_MyVar", modify, delete and create again
         self.runCmd("-data-evaluate-expression g_MyVar")

Modified: 
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp?rev=274254&r1=274253&r2=274254&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp 
(original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp 
Thu Jun 30 13:00:32 2016
@@ -511,8 +511,6 @@ ClangUserExpression::Parse(DiagnosticMan
                     m_fixed_text = fixed_expression.substr(fixed_start, 
fixed_end - fixed_start);
             }
         }
-        diagnostic_manager.Printf(eDiagnosticSeverityError, "%u error%s 
parsing expression", num_errors,
-                                  num_errors == 1 ? "" : "s");
 
         ResetDeclMap(); // We are being careful here in the case of breakpoint 
conditions.
 

Modified: 
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp?rev=274254&r1=274253&r2=274254&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp 
(original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp 
Thu Jun 30 13:00:32 2016
@@ -115,9 +115,6 @@ ClangUtilityFunction::Install(Diagnostic
 
     if (num_errors)
     {
-        diagnostic_manager.Printf(eDiagnosticSeverityError, "%d error%s 
parsing expression", num_errors,
-                                  num_errors == 1 ? "" : "s");
-
         ResetDeclMap();
 
         return false;


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits