spyffe added a subscriber: spyffe.
spyffe added a comment.

I like this concept a lot, and I think it's great for testcases that actually 
need to interact with the command line.
I'm concerned, though, that the separation of input from command files makes 
tests more complex to write.  One thing that's very nice about the `inline` 
tests in LLDB is that the test and the source for the debugged program are both 
in the same file.
If the goal is to port compiler tests across (or just to have tests be more 
understandable for compiler engineers), I would argue for choosing that model 
as the default.  It would mean a slightly customized LLDB driver but that 
wouldn't be insanely hard.  (We've already done it in Python!)


https://reviews.llvm.org/D24591



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to