[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:22 +#define INCLUDE_LINUX_PTRACE_DEFINITIONS_FOR_SVE_ARM64 +#include "Plugins/Process/Utility/LinuxPTraceDefines_arm64sve.h

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280037. omjavaid added a comment. This update fixes issues highlighted in last review iteration. @labath any further action on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

omjavaid added a comment. In D84257#2166215 , @labath wrote: > In D84257#2164967 , > @tatyana-krasnukha wrote: > > > Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. > > > @omjavaid might be i

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + ---

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a reviewer: rengolin. In our discussion D79699 SVE ptrace register access support we decide to invalidate register context cached data on every stop instead of doing at before Step/Re

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280373. omjavaid added a comment. In this update I have moved ConfigureRegisterContext insider InvalidateAllRegisters in light of D84501 where we move InvalidateAllRegisters on every stop rather than doing so before step/r

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

omjavaid updated this revision to Diff 280374. omjavaid added a comment. Corrected a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84501/new/ https://reviews.llvm.org/D84501 Files: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp Index: lldb/source/Plugins/Process/Linu

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

omjavaid added subscribers: max-kudr, omjavaid. omjavaid added a comment. In D85235#2198062 , @JDevlieghere wrote: > In D85235#2198013 , @max-kudr wrote: > >> @JDevlieghere This change is is failing LLDB Windows bu

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks for fixing this. SVE was just a typo orignal core files were generated without SVE flag on a aarch64-linux target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

omjavaid created this revision. omjavaid added reviewers: JDevlieghere, labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. D83904 seems to have changed timeout value on expect_gdbremote_sequence which was 120 previously.

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This breaks LLDB arm-linux buildbot http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/2651 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

omjavaid updated this revision to Diff 284068. omjavaid added a comment. Fixed as suggested by @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85514/new/ https://reviews.llvm.org/D85514 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py l

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc888694a8eda: [LLDB] Fix timeout value on expect_gdbremote_sequence (authored by omjavaid). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. This patch updates LLDB's in house version of SVE ptrace/sig macros by converting them into constants and inlines.

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 284328. omjavaid added a comment. This patch fixes review items from last review cycles. Now we do not use LinuxPTraceDefines_arm64sve.h for NativeProcessLinux_arm64 as these defs are already back ported into libc ptrace.h available on most distros. LLDB ar

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid added a comment. @labath Any further action needed on this change? I have updated test main.c for doing asm write to SVE regs and then reading them back during testing. Also i have removed NativeProcessLinux_arm64 dependence on LinuxPTraceDefines_arm64sve.h. We are using sys root's pt

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 285956. omjavaid added a comment. This update adds check for SVE support using /proc/cpuinfo in SVE testcases. Also tests case to read predicate registers with 5 different values instead of 0xff. @labath this seems reasonable now? CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

omjavaid updated this revision to Diff 285957. omjavaid added a comment. This update fixes SVE namespace name to lower case and fixes a typo in previous update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85641/new/ https://reviews.llvm.org/D85641 Files: lldb/source/Plugins/Proces

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 286161. omjavaid added a comment. Herald added a subscriber: JDevlieghere. In light of review comments I have come up with this new sceheme for setting up QEMU VM based testing environment for LLDB. We now have three scripts: 1. setup.sh is used to build L

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

This revision was automatically updated to reflect the committed changes. Closed by commit rG090306fc80db: Convert SVE macros into c++ constants and inlines (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4f40c376f5: [LLDB] NativeThreadLinux invalidate register cache on stop (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG567ba6c468b9: [LLDB] Add ptrace register access for AArch64 SVE registers (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79699?vs=285956&id=2865

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82865/new/ https://reviews.llvm.org/D82865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82853/new/ https://reviews.llvm.org/D82853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid updated this revision to Diff 286525. omjavaid added a comment. This revision updated after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/s

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid updated this revision to Diff 287323. omjavaid added a comment. This reworks previous implementation by returning a vector containing register numbers to be expedited. Default case is minimal set of generic registers or complete register set 0. In the child rev D82855

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid updated this revision to Diff 287325. omjavaid added a comment. Updated after changes to parent rev D82853 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 Files: lldb/source/Plugins/Process/Linux/Nati

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 287333. omjavaid added a comment. Updated after changes to TestSVERegister.py for detecting SVE support using /proc/cpuinfo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 287526. omjavaid added a comment. This update changes this test;s dependence on register offset API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch6

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

omjavaid added a comment. In D82865#2225978 , @labath wrote: > The new API looks fairly confusing. This doesn't sound like something that > the SB users should generally know or care about. What would the > GetByteOffset function return in the generic ca

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. In D82064#2223991 , @JDevlieghere wrote: > I didn't look at the scripts in detail but I have a few general (high level) > comments: > > - I also feel this should go under `lldb/scripts`. > - Can we put the documentations as RST

[Lldb-commits] [PATCH] D86872: [LLDB] Move targetHasSVE function to lldbtest.py

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. targetHasSVE helper function was added to test for availability of SVE support by connected platform. We now inten

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid updated this revision to Diff 288941. omjavaid added a comment. Added test case for vg testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py lldb/

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid updated this revision to Diff 288942. omjavaid added a comment. Fixed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82853/new/ https://reviews.llvm.org/D82853 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/source/Host/common/NativeRegist

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 288943. omjavaid added a comment. Update after moving SVE supported function to lldbtest.py CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch64_sve_reg

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: llvm-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: LLVM. omjavaid requested review of this revision. This patch removes register set definitions and other redundant code from Nati

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid added a comment. NativeRegisterContextLinux_arm still uses "Plugins/Process/Utility/lldb-arm-register-enums.h" which I intend to deal in a later patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 __

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289218. omjavaid added a comment. Fixed last diff it contained an invalid change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cp

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289361. omjavaid added a comment. Herald added a subscriber: emaste. Adding changes to FreeBSD/* missed earlier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files: lldb/source/Plugins/Process/FreeBSD/

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289362. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp lldb/s

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D86872: [LLDB] Move targetHasSVE function to lldbtest.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bee13f89085: Move targetHasSVE function to lldbtest.py (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rG76953321: Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to… (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D86962?vs=289362&id=29

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 290189. omjavaid added a comment. This diff addresses issues highlighted in review. @labath any further thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064 Files: lldb/docs/resources/test.rst lld

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added inline comments. Comment at: lldb/docs/resources/test.rst:427 +actual hardware. QEMU helper scripts and README.txt document can be found under +llvm-project/lldb/scripts/lldb-test-qemu which can help setup a virtual testing +environment for LLDB using QEMU. These s

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

omjavaid added a comment. Herald added a reviewer: JDevlieghere. This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written. Comment at: lldb/source/API/SBMemoryReg

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 293136. omjavaid added a comment. Herald added a subscriber: arphaman. This adds a rst page qemu-testing.rst that describes content which was previously written in README.txt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://review

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. Ping! LGTM or any further comments or suggestions? PS: I have been on holidays so apologies for late responses in past few week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath I am just back from holiday and was hoping for Jason to give his advice in this. I am wondering how we can move forward on this. I have added a some information from GDB inline. In D82863#2254423 , @labath wrote: > I'd l

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dffec03b0f6: [LLDB] Add QEMU testing environment setup guide for SVE testing (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 296811. omjavaid added a comment. This is an update after addressing comments from @jasonmolenda CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterCont

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:767 + m_reg_data.Clear(); + m_reg_data.SetData(reg_data_sp); + m_reg_data.SetByteOrder(GetByteOrder()); jasonmolenda wrote: > I'm proba

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. HI @labath Do you have any comments or suggestions for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2320342 , @jasonmolenda wrote: > In D82863#2319568 , @labath wrote: > >> In D82863#2313676 , @jasonmolenda >> wrote: >> >>> (about g pac

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2321647 , @labath wrote: > In D82863#2321370 , @omjavaid wrote: > >> In D82863#2320342 , @jasonmolenda >> wrote: >> >>> The original g/G

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2330122 , @labath wrote: > In D82863#2324560 , @omjavaid wrote: > >> In D82863#2321647 , @labath wrote: >> >>> In D82863#2321370

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid created this revision. omjavaid added reviewers: labath, clayborg. Herald added a subscriber: kristof.beyls. This patch simplifies register accesses in NativeRegisterContextLinux_arm64 and also adds some bare minimum caching to avoid multiple calls to ptrace during a stop. Linux ptrace

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid marked an inline comment as done. omjavaid added a comment. We ll be dealing with Linux user mode and mostly aarch64 data registers except for cpsr, fpsr and fpcr. I think we should be fine but let me confirm this again from documentation. Further more, motivation behind these changes

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

omjavaid created this revision. omjavaid added reviewers: jasonmolenda, labath, clayborg. Herald added a subscriber: kristof.beyls. This patch adds core definitions in lldb ArchSpecs for armv8l and armv7l cores. There is also fix where while merging target and paltform triple we were updating co

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi Jan, This change has introduced a regression in 32bit arm linux testsuite with around 60 new test failures. Here are list of tests which are failing with this change. Mostly tests are

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGa6c40f56aed1: Revert "Fix lookup of symbols at the same address with no size vs. size" (authored by omjavaid). Changed

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

omjavaid marked an inline comment as done. omjavaid added a comment. I have updated the patch as suggested and will move out the triple fix and whitespace issue in separate patches. Committing remaining changes shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69904/new/ https://r

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9b958356983a: [LLDB] Add core definition for armv8l and armv7l (authored by omjavaid). Herald added a project: LLDB. Chan

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

omjavaid created this revision. omjavaid added a reviewer: labath. This patch fixes whitespace/tabs mismatch in lldb/packages/Python/lldbsuite/test/make/Makefile.rules https://reviews.llvm.org/D70154 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules Index: lldb/packages/Python

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda, clayborg. Herald added a subscriber: kristof.beyls. This patch fixes a bug where when target triple created from elf information is arm-*-linux-eabihf and platform triple is armv8l-*-linux-gnueabihf. Merging both tri

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

omjavaid added a comment. In D70154#1743904 , @labath wrote: > It looks like you're replacing everything with tabs. I suppose that's fine, > as that is the prevalent local convention, but it might be better to go for > spaces, as we don't use tabs anywhe

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9f30f2ecba5: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. In D63540#1744110 , @jankratochvil wrote: > It is still the same (no arm32 regression) with > `16bdcc809c72c639a2888b6b859dca88453e3c28` and this patch reapplied. Hi Jan, This issue manifests itself only when lldb test suite

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks rovka. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70381/new/ https://reviews.llvm.org/D70381 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid updated this revision to Diff 229971. omjavaid added a comment. Added a unittest as suggested by @labath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 Files: lldb/source/Utility/ArchSpec.cpp lldb/unittests/Utility/ArchSpecTest.cp

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda. Herald added subscribers: kristof.beyls, javed.absar. Herald added a reviewer: rengolin. This patches paves way for upcoming SVE RegisterInfo definitions. This is cosmetic change which allows us to define ARM64 Regist

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

omjavaid marked 3 inline comments as done. omjavaid added a comment. Thanks @clayborg suggestions noted and will be fixed in committed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66934/new/ https://reviews.llvm.org/D66934 ___ lldb-

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

This revision was automatically updated to reflect the committed changes. Closed by commit rL370644: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett, javed.absar. Herald added a project: LLDB. This patch updates assembler attributes for AArch64 targets so we can disassemble newer instructions supported in ISA version 8.5 and SV

[Lldb-commits] [PATCH] D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361451: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE… (authored by omjavaid, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

omjavaid added a comment. Hi This change breaks arm/aarch64 linux builds. http://147.75.106.138:32769/builders/lldb-aarch64-ubuntu/builds/47 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62337/new/ https://reviews.llvm.org/D62337 __

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

omjavaid created this revision. omjavaid added reviewers: jankratochvil, gkistanova, labath. Herald added subscribers: kristof.beyls, javed.absar. This patch adds lldb aarch64 linux builder. It ll run on staging master until tests become stable. https://reviews.llvm.org/D62473 Files: buildbo

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

omjavaid marked 2 inline comments as done. omjavaid added inline comments. Comment at: buildbot/osuosl/master/config/status.py:282 +mode = "failing", +builders = ["lldb-x86_64-debian"], +addLogs=False), labath wrote: > This doe

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

omjavaid updated this revision to Diff 201490. omjavaid added a comment. Fixes typo in first rev. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62473/new/ https://reviews.llvm.org/D62473 Files: buildbot/osuosl/master/config/builders.py buildbot/osuosl/master/config/slaves.py buil

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

This revision was automatically updated to reflect the committed changes. omjavaid marked an inline comment as done. Closed by commit rL361787: [zorg] Add lldb-aarch64-ubuntu builder (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil, gkistanova. Herald added subscribers: kristof.beyls, javed.absar. This patch adds lldb aarch64 linux builder. It ll run on staging master until tests become stable. https://reviews.llvm.org/D63441 Files: buildbo

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL363659: [zorg] Add lldb-arm-ubuntu builder (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2334664 , @labath wrote: > In D82863#2331892 , @omjavaid wrote: > >> In D82863#2330122 , @labath wrote: >> >>> I started drafting an email

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2341628 , @labath wrote: > I'm afraid I don't understand what you mean. Could you try to be more > specific? > > It's true that currently lldb client uses the register offsets provided by > the server (if they are pres

[Lldb-commits] [PATCH] D90741: [LLDB] Fix SVE reginfo for sequential offset in g packet

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. This moves in the direction of our effort to synchronize register descriptions between LLDB and GDB

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 302794. omjavaid added a comment. This update tries to mitigate effects of fixed offset fields in LLDB register description. We have now replaced Arm64 register infos on lldb-server side to generate offsets which increase with respect to size in increasing

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373276 , @labath wrote: > I'm sorry about the delay, I was having trouble finding the time to think > this through... > > In D82863#2342112 , @omjavaid wrote: > >> In D82863#234

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373557 , @labath wrote: > [ I've replying to your message in a slightly different order that what it > was written. ] > > In D82863#2373356 , @omjavaid wrote: > >> In D82863#237

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303052. omjavaid added a comment. This updates after discussion yesterday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D91057: [LLDB] Update SVE Z reg info to remove invalidate regs

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. In our recent discussion we are aiming to make LLDB registers exchange minimum possible information in qRegisterIn

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303786. omjavaid added a comment. This updates after remove invalidate_regs from primary registers D91057 . Currently only SVE Z registers had invalidate_reg list populated which has been removed to send less information ac

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch carries forward our aim to remove offset field from qRegisterInfo packets and XML register description. I have created a new function

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 304726. omjavaid added a comment. This update addresses comments about last revision. Also sending offset field in qRegisterInfo and XML register description has been disabled D91241 CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 304728. omjavaid added a comment. Minor update after changes to D82863 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/Dynamic

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391072 , @labath wrote: > This looks pretty straightforward, modulo the inline comment about the > centralization of the offset computations So the current approach of finalizing offsets of pseudo registers after

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391126 , @labath wrote: > That's a good point. Maybe this does need to be a two-pass algorithm (first > compute the offsets of primary registers, then fill out subregs). But that > doesn't mean the two passes should b

<    1   2   3   4   5   6   >