omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land.
Hi Jan, This change has introduced a regression in 32bit arm linux testsuite with around 60 new test failures. Here are list of tests which are failing with this change. Mostly tests are failing when an expression is being evaluated. I think we should immediately revert this change from 9.x branch as well as master. It.py lldb-api :: commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py lldb-api :: commands/expression/call-overridden-method/TestCallOverriddenMethod.py lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py lldb-api :: commands/expression/char/TestExprsChar.py lldb-api :: commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py lldb-api :: commands/expression/context-object/TestContextObject.py lldb-api :: commands/expression/dont_allow_jit/TestAllowJIT.py lldb-api :: commands/expression/expr-in-syscall/TestExpressionInSyscall.py lldb-api :: commands/expression/inline-namespace/TestInlineNamespace.py lldb-api :: commands/expression/no-deadlock/TestExprDoesntBlock.py lldb-api :: commands/expression/persistent_types/TestNestedPersistentTypes.py lldb-api :: commands/expression/persistent_types/TestPersistentTypes.py lldb-api :: commands/expression/pr35310/TestExprsBug35310.py lldb-api :: commands/expression/radar_9531204/TestPrintfAfterUp.py lldb-api :: commands/expression/radar_9673664/TestExprHelpExamples.py lldb-api :: commands/expression/rdar44436068/Test128BitsInteger.py lldb-api :: commands/expression/save_jit_objects/TestSaveJITObjects.py lldb-api :: commands/expression/static-initializers/TestStaticInitializers.py lldb-api :: commands/expression/test/TestExprs.py lldb-api :: commands/expression/timeout/TestCallWithTimeout.py lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py lldb-api :: commands/expression/xvalue/TestXValuePrinting.py lldb-api :: commands/register/register/register_command/TestRegisters.py lldb-api :: commands/source/info/TestSourceInfo.py lldb-api :: functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py lldb-api :: functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py lldb-api :: functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py lldb-api :: functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py lldb-api :: functionalities/load_unload/TestLoadUnload.py lldb-api :: functionalities/load_using_paths/TestLoadUsingPaths.py lldb-api :: functionalities/memory/find/TestMemoryFind.py lldb-api :: functionalities/process_group/TestChangeProcessGroup.py lldb-api :: functionalities/show_location/TestShowLocationDwarf5.py lldb-api :: functionalities/signal/handle-abrt/TestHandleAbort.py lldb-api :: functionalities/thread/num_threads/TestNumThreads.py lldb-api :: lang/c/anonymous/TestAnonymous.py lldb-api :: lang/c/bitfields/TestBitfields.py lldb-api :: lang/c/enum_types/TestEnumTypes.py lldb-api :: lang/c/function_types/TestFunctionTypes.py lldb-api :: lang/c/shared_lib/TestSharedLib.py lldb-api :: lang/c/strings/TestCStrings.py lldb-api :: lang/c/struct_types/TestStructTypes.py lldb-api :: lang/cpp/auto/TestCPPAuto.py lldb-api :: lang/cpp/call-function/TestCallCPPFunction.py lldb-api :: lang/cpp/chained-calls/TestCppChainedCalls.py lldb-api :: lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py lldb-api :: lang/cpp/extern_c/TestExternCSymbols.py lldb-api :: lang/cpp/global_operators/TestCppGlobalOperators.py lldb-api :: lang/cpp/lambdas/TestLambdas.py lldb-api :: lang/cpp/llvm-style/TestLLVMStyle.py lldb-api :: lang/cpp/namespace/TestNamespace.py lldb-api :: lang/cpp/namespace/TestNamespaceLookup.py lldb-api :: lang/cpp/namespace_conflicts/TestNamespaceConflicts.py lldb-api :: lang/cpp/namespace_definitions/TestNamespaceDefinitions.py lldb-api :: lang/cpp/operators/TestCppOperators.py lldb-api :: lang/cpp/overloaded-functions/TestOverloadedFunctions.py lldb-api :: lang/cpp/rvalue-references/TestRvalueReferences.py lldb-api :: lang/cpp/scope/TestCppScope.py lldb-api :: lang/cpp/static_methods/TestCPPStaticMethods.py lldb-api :: lang/cpp/symbols/TestSymbols.py lldb-api :: lang/cpp/template-function/TestTemplateFunctions.py lldb-api :: lang/cpp/template/TestTemplateArgs.py lldb-api :: lang/cpp/this/TestCPPThis.py lldb-api :: lang/cpp/trivial_abi/TestTrivialABI.py lldb-api :: lang/cpp/unicode-literals/TestUnicodeLiterals.py lldb-api :: lang/cpp/virtual/TestVirtual.py lldb-api :: python_api/sbvalue_persist/TestSBValuePersist.py lldb-api :: python_api/thread/TestThreadAPI.py lldb-api :: python_api/value/TestValueAPI.py Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
