[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere added a comment. - Do we need the source file for anything? I think it's fine to keep it around to regenerate the test, but please fix the extension. Nothing in lldb uses `.cc`. - I think if we check in the "binary", we should also update the other crashlogs tests to rely on it, an

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1022 +# 1. Try to use the user-provided target +if options.target_path is not None and options.target_path != "": +target = debugger.CreateTarget(options.target_path)

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return Can we do this with a t

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Refactor command option enum values so that there's a table that connects the CommandArgumentType enumeration with the corresponding enum values

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Print the enum values and their description in the argument value help output. Here's what the output looks like: (lldb) help

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere added a comment. In case anyone is wondering why I created a new table instead of using `g_arguments_data`, the answers is that I didn't want to pull that whole table, and the help text callbacks it depends on, into a separate header. But after having discovered two entries that we

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere updated this revision to Diff 444506. JDevlieghere added a comment. Herald added a subscriber: mgorny. - Merge two tables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129703/new/ https://reviews.llvm.org/D129703 Files: lldb/include/lldb/Interpreter/CommandObject.h lld

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere updated this revision to Diff 444510. JDevlieghere added a comment. Add static_assert that ensures that the entries in the table have the same order as in the enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129703/new/ https://reviews.llvm.org/D129703 Files: lldb/in

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

JDevlieghere updated this revision to Diff 444511. JDevlieghere added a comment. Rebase on D129703 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129707/new/ https://reviews.llvm.org/D129707 Files: lldb/source/Interpreter/CommandObject.cpp lldb/tes

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// Do we still need a copy of this for LLDB? CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:25-54 -// FIXME: "script-type" needs to have its contents determined dynamically, so -// somebody can add a new scripting languag

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a subscriber: teemperor. JDevlieghere added a comment. In D112374#3653702 , @mizvekov wrote: > @JDevlieghere I spent a lot of time trying to get this test running on my > machine to no avail. I think lldb build and test setup is quite

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG7ced9fff9547: [lldb] Refactor command option enum values (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcae3cdbd029: [lldb] Print the enum values and their description in the help output (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

JDevlieghere added a comment. Seems like there's another instance of this in `TestForwardDeclFromStdModule.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129898/new/ https://reviews.llvm.org/D129898 ___

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129338/new/ https://reviews.llvm.org/D129338 ___

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few nits about naming, but otherwise this LGTM. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:47 +DEFINE_BINARY_PROTO_FU

[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

JDevlieghere accepted this revision. JDevlieghere added a comment. The changes themselves look good, but please undo the formatting/unrelated changes before landing this. When I've been in a situation like this where I accidentally formatted unrelated things, I usually unstage my changes and use

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. In D112374#3665989 , @mizvekov wrote: > If anyone wants to take a look at the new changes to lldb tests, be my guest. > Otherwise I will try to land this again soon. It might well be that we figure > out some other in-tree

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

JDevlieghere added a comment. The relative/absolute caching seems like a nice improvement. Splitting it into a separate patch would make it easier to review. I'm slightly worried about the change to make the new "fuzzy" matching the default. While it makes sense for the breakpoints, I wouldn't

[Lldb-commits] [PATCH] D130312: [LLDB][Reliability] Fix accessing invalid iterator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130312/new/ https://reviews.llvm.org/D130312 ___

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Greg, this is a much cleaner API. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D130396: Cache the value for absolute path in FileSpec.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130396/new/ https://reviews.llvm.org/D130396 ___

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1390-1395 + case ArchSpec::eCore_riscv64: +if (!enforce_exact_match) { + if (core2 == ArchSpec::eCore_riscv64) +return true; +} +break; I don't think this i

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added subscribers: jsji, ctetreau, pengfei. Herald added a project: All. JDevlieghere requested review of this revision. Xcode 14 no longer puts the Rosetta expanded shared cache under `16.0`. Ins

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

JDevlieghere marked an inline comment as done. JDevlieghere added subscribers: adrian, ismail. JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10 +def apple_silicon(test): +return platform.system() == 'Darwin' and test.getArchitec

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130602/new/ https://reviews.llvm.org/D130602 ___

[Lldb-commits] [PATCH] D130215: [DebugInfo] Teach dwarfdump and lldb about ptrauth DWARF tags and attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGa8c3d9815e04: [DebugInfo] Teach LLVM and LLDB about ptrauth in DWARF (authored by JDevlieghere). Heral

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGecda408178fc: [lldb] Read from the Rosetta shared cache with Xcode 14 (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: ht

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBTraceCursor.h:1-2 +//===-- SBTraceCursor.h ---*- C++ +//-*-===// +// Broken ASCII art Comment at: lldb/source/API/SBTrace.cpp:47

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130937/new/ https://reviews.llvm.org/D130937 ___

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few minor nits but the change looks sound to me. It's great to see the existing code getting unified and nice job on that test. LGTM. Comment at: lldb/source/C

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return mib wrote: > JDevlieghe

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat. LGMT! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131013/new/ https://reviews.llvm.org/D131013

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:51-56 +add_custom_target(fuzz-lldb-expression + COMMENT "Running the LLDB expression evaluator fuzzer..." + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/fuzzer-art

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

JDevlieghere added inline comments. Comment at: lldb/test/Shell/Symtab/Inputs/t.yaml:60 +reserved3: 0x0 +content: 01001C00010020002202983E38003800FD3E380003000C0006002400040

[Lldb-commits] [PATCH] D131025: Document why test is disabled on macos ventura

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131025/new/ https://reviews.llvm.org/D131025 ___ lldb-commits mail

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 ___

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129603/new/ https://reviews.llvm.org/D129603 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere created this revision. JDevlieghere added reviewers: mib, kastiglione, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a function to make it easier to debug a test failure caused by an unexpected stop reason. This is similar to the `assertSta

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere updated this revision to Diff 449707. JDevlieghere added a comment. Add missing stop reasons CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131083/new/ https://reviews.llvm.org/D131083 Files: lldb/docs/resources/test.rst lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:28 if image not in self.loaded_images: +if image.uuid == uuid.UUID(int=0): +print(f"Note: S

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1198-1204 +option_parser.add_option( +'--skip-status', +'-s', +dest='skip_status', +action='store_true', +help='prevent the interac

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/python/crashlog.py:1013-1015 +nonlocal result +result.SetError(sb_error, "error: %s" % message) +r

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1025 +if not target: +result.PutCString("error: couldn't create target provided by the user ({option.target_path})") +return This is not an f-string

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:604 + r'(' +version+ r')?' # img_version + r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)' # addr + r' +(.*)'

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:417 +class CrashLogParser(object): +"Base class and factory." +def __new__(cls, debugger, path, verbose, *args, **kwargs): Comment at: lldb/examples/pytho

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +return "EXC_BAD_ACCESS"; + case EXC_BAD_INSTRUCTION: +return "EXC_BAD_INSTRUCTION"; + case EXC_ARITHMETIC: +return "EXC_AR

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lldb.eStopReasonProcessorT

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0f821339dad1: [lldb] Add assertStopReason helper function (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Make LLDB resilient against failing dyld introspection APIs: `dyld_process_create_for_current_task`, `dyld_process_snapshot_create_for_process`

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:534 + if (auto dyld_process = dyld_process_create_for_current_task()) { +if (auto snapshot = dyld_process_snapshot_create_f

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere updated this revision to Diff 449795. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131110/new/ https://reviews.llvm.org/D131110 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/H

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere updated this revision to Diff 449797. JDevlieghere added a comment. Reduce indentation with early returns in a helper function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131110/new/ https://reviews.llvm.org/D131110 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rG71ebcd334806: [lldb] Make LLDB resilient against failing dyld introspection SPIs (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131110?vs=44

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere added a comment. Can we test this by modifying an address in the existing test case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] mib wrote: > aprantl wrote: > > Is it now undefined if it doesn't exist? Do

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131020/new/ https://reviews.llvm.org/D131020 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131130: [lldb] Improve EXC_RESOURCE exception reason

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Jason noted that the stop message we print for a memory high water mark notification (EXC_RESOURCE) could be clearer. Currently, th

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice. Thanks for taking care of this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131138/new/ https://reviews.llvm.org/D131138 __

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, these all look good. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131122/new/ https://reviews.llvm.org/D131122 _

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131033/new/ https://reviews.llvm.org/D131033 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere added a comment. In D131032#3698163 , @mib wrote: > In D131032#3698108 , @JDevlieghere > wrote: > >> Can we test this by modifying an address in the existing test case? > > Sure but we won't be able

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1198-1204 +option_parser.add_option( +'--skip-status', +'-s', +dest='skip_status', +action='store_true', +help='prevent the interac

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 ___

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:417 +class CrashLogParser(object): +"Base class and factory." +def __new__(cls, debugger, path, verbose, *args, **kwargs): JDevlieghere wrote: > This is not done (yet) CHA

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM module the inline comment. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:27-29 if image not in self.lo

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

JDevlieghere added a comment. Hey Trevor, Thank you for your patch. Please[[ https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch | include as much context ]] as possible when uploading a patch. It makes it a lot easier for the reviewers to see the surrounding code. Could

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

JDevlieghere added a comment. In D131138#3702608 , @jingham wrote: > In D131138#3698508 , @mib wrote: > >> This is awesome 🤩 ! I was also thinking of changing the way enums are >> exposed to python: instead of ha

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { fixathon wrote: > This will default t

[Lldb-commits] [PATCH] D131130: [lldb] Improve EXC_RESOURCE exception reason

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c81b743e31a: [lldb] Improve EXC_RESOURCE exception reason (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131130?vs=449835&id=450335#toc Re

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} fixathon wrote: > JDevlieghere wrote: > > fixathon wrote: > > > Could we delete this un

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. - Reduce indentation - Extract caching of the DbgShellCommand and the dsymForUUID executable (or equivalent) - Check the DBGShellCommands b

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450436. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Don't cache the value of `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303 F

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450441. JDevlieghere added a comment. - Fix typo - Still resolve the LLDB_APPLE_DSYMFORUUID_EXECUTABLE in case it's a relative path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303 Files: lldb/sourc

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450442. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303 Files: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp Index: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp =

[Lldb-commits] [PATCH] D131305: [lldb] Tidy some regex in crashlog.py (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131305/new/ https://reviews.llvm.org/D131305 ___

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. On macOS, LLDB uses the DebugSymbols.framework to locate symbol rich dSYM bundles. [1] The framework uses a variety

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3704791 , @jasonmolenda wrote: > Interesting idea, it seems worth trying out and seeing how it works in > practice. > > My read of the llvm::ThreadPool is that this won't create an unbounded number > of threads

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450659. JDevlieghere added a comment. Implement Jason's suggestion of delaying this until we need the unwind table for a module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3706202 , @labath wrote: > I see two problems with this patch. > > - it makes shutting down lldb safely impossible (because you never know if > there are any unfinished tasks running). We already have problems wit

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. There was another approach I considered initially which might alleviate some of the issues Pavel raised. Instead of using the global thread pool, that plan consisted of a dedicated thread to fetch symbols in the background. That would allow us to add the symbol inf

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere created this revision. JDevlieghere added reviewers: labath, llunak. Herald added a project: All. JDevlieghere requested review of this revision. Use the Initialize/Terminate pattern for the global thread pool to make sure it gets flushed during teardown. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere updated this revision to Diff 450827. JDevlieghere added a comment. - Create the thread pool before the plugin callback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Co

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. 🥳 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D131422: [lldb] Remove include/lldb/lldb-private.h

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131422/new/ https://reviews.llvm.org/D131422 ___

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the `# Return error` but that's addressed in a follow up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 ___

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450993. JDevlieghere added a comment. - Use a debugger event to execute the notification of the targets on the event handler thread CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/inclu

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3706814 , @labath wrote: > In D131328#3706749 , @JDevlieghere > wrote: > >> There was another approach I considered initially which might alleviate some >> of the issues

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450999. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/include/lldb/Core/ModuleList.h lldb/include/lldb/Sym

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131036/new/ https://reviews.llvm.org/D131036 ___

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) mib w

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Language.h:317 + /// function names. + /// + /// \param[in] mangled_names List of mangled names to generate I was wondering the same. I think it's worth the churn.

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3976fed470: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131303?vs=450442&id=451033

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) kasti

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere created this revision. JDevlieghere added reviewers: mib, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. I noticed a few Python API tests (`test/API/python_api`) were not marked as `NO_DEBUG_INFO_TESTCASE` causing them to be rerun needlessly

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D131539#3711488 , @kastiglione wrote: > this diff has made me wonder: should we have a `NoDebugInfoTestCase` that can > be used by any test, and would replace assigning to `NO_DEBUG_INFO_TESTCASE`? I was wondering the s

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere added inline comments. Comment at: lldb/source/Core/DataFileCache.cpp:23-39 // Prune the cache based off of the LLDB settings each time we create a cache // object. ModuleListProperties &properties = ModuleList::GetGlobalModuleListProperties(); llv

<    7   8   9   10   11   12   13   14   15   16   >