JDevlieghere added a comment. - Do we need the source file for anything? I think it's fine to keep it around to regenerate the test, but please fix the extension. Nothing in lldb uses `.cc`. - I think if we check in the "binary", we should also update the other crashlogs tests to rely on it, and get rid of `patch-crashlog.py`. - Let's format the JSON so it's more readable and easier to write tests for it in the future.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129603/new/ https://reviews.llvm.org/D129603 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
