JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561
+ default:
+ LLVM_FALLTHROUGH;
+ case ArchSpec::eCore_arm_arm64: {
----------------
fixathon wrote:
> This will default to the ArchSpec::eCore_arm_arm64 case if no matching
> ArchSpec is specified. Double-checking if this by intent.
I'm sure it was intentional when I wrote it, but I can't figure out for which
core this would actually make sense. If the test suite passes with returning an
empty array here, that works for me.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640
+ }
+ return {};
+}
----------------
fixathon wrote:
> Could we delete this unreachable return statement? It's tripping up static
> code checkers since all possible branches already have a return.
Yes, let's make it an `llvm_unreachable` (otherwise gcc will complain).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113155/new/
https://reviews.llvm.org/D113155
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
