[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops, static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP)); if (!S) { const SCEV **O = SCEVAllocator.Allocate(Ops.size()); -std::uninitialized_copy(Ops.begin(), Ops.end(), O); +llvm::uninitial

[Lldb-commits] [lldb] Remove unneeded conditional (PR #138321)

2025-05-02 Thread via lldb-commits
https://github.com/satyajanga created https://github.com/llvm/llvm-project/pull/138321 Minor code change for removing the unneeded conditional. we already check for `platform_sp` not null in the next line. ### TEST PLAN manual test ``` satyajanga@devvm21837:toolchain $ ./bin/lldb LLDB loggi

[Lldb-commits] [lldb] Remove unneeded conditional (PR #138321)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (satyajanga) Changes Minor code change for removing the unneeded conditional. we already check for `platform_sp` not null in the next line. ### TEST PLAN manual test ``` satyajanga@devvm21837:toolchain $ ./bin/lldb LLDB logging ini

[Lldb-commits] [lldb] Remove unneeded conditional (PR #138321)

2025-05-02 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-05-02 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: @dyung thanks for catching this, I haven't been able to watch closely and didn't realize no one approved. @anjenner No worries, misunderstandings happen. I do think we need to revert this, however. See PR138203 - it sounds like this is causing issues with lifetimes and I'

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Sergei Barannikov via lldb-commits
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) { } void Checksum::SetMD5(llvm::MD5::MD5Result md5) { - const constexpr size_t md5_length = 16; - std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin()); + static_assert(sizeof(md5) ==

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @satyajanga Please update your summary about where you removed the conditional, and the description. Otherwise LGTM. https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) { } void Checksum::SetMD5(llvm::MD5::MD5Result md5) { - const constexpr size_t md5_length = 16; - std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin()); + static_assert(sizeof(md5) ==

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread via lldb-commits
kusmour wrote: > @kusmour Can you please confirm whether or not there's a reason to run the > launch or attach commands in asynchronous mode? It looks like the divergence > was introduced when the feature was added (https://reviews.llvm.org/D154028) > and I'm not sure it's necessary. My local

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Ignoring whitespace, this is a pretty tiny change that makes sense. https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From 7c67ef6748f8813b7aaa91f8e6b463d9fde57d94 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy Add `llvm::uninitiali

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
@@ -2038,6 +2038,11 @@ template auto mismatch(R1 &&Range1, R2 &&Range2) { adl_end(Range2)); } +template +auto uninitialized_copy(R1 &&Src, IterTy Dst) { jurahul wrote: Thanks, fixed. https://github.com/llvm/llvm-project/pull/138174

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -417,8 +424,11 @@ struct DAP { lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); } private: - std::mutex m_queue_mutex; + /// Queue for all incoming messages. std::deque m_queue; + /// Dedicated queue for launching and attaching. + std::deque m_launc

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -938,15 +954,30 @@ llvm::Error DAP::Loop() { StopEventHandlers(); }); - while (!disconnecting || !m_queue.empty()) { + while (true) { std::unique_lock lock(m_queue_mutex); -m_queue_cv.wait(lock, [&] { return disconnecting || !m_queue.empty(); }); +m_que

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From c51a312cd3901a1e51d9e210b3efdc89389f0e10 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove unneeded conditional (PR #138321)

2025-05-02 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/138321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [lldb] 0ddcd20 - Don't hold the Target's ModuleListLock over running LoadScriptingResourceInTarget (#138216)

2025-05-02 Thread via lldb-commits
Author: jimingham Date: 2025-05-02T11:51:21-07:00 New Revision: 0ddcd209ddc8956eb52d642937a4397c6b08449c URL: https://github.com/llvm/llvm-project/commit/0ddcd209ddc8956eb52d642937a4397c6b08449c DIFF: https://github.com/llvm/llvm-project/commit/0ddcd209ddc8956eb52d642937a4397c6b08449c.diff LOG

[Lldb-commits] [lldb] Don't hold the Target's ModuleListLock over running LoadScriptingResourceInTarget (PR #138216)

2025-05-02 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/138216 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Don't hold the Target's ModuleListLock over running LoadScriptingResourceInTarget (PR #138216)

2025-05-02 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/138216 >From 656fe559f84526fd3edc91b1c0d12fd56d838085 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 1 May 2025 16:27:37 -0700 Subject: [PATCH 1/2] Don't hold the Target's ModuleListLock over running LoadScrip

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/2] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
@@ -96,6 +97,8 @@ class FormattersMatchCandidate { bool DidStripTypedef() const { return m_flags.stripped_typedef; } + uint32_t GetPtrStrippedDepth() const { return m_ptr_stripped_depth; } ZequanWu wrote: I meant this `FormattersMatchCandidate` has been s

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From 46542ce5b946735c2c0a8f65e185761ebbf77073 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy Add `llvm::uninitiali

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) { } void Checksum::SetMD5(llvm::MD5::MD5Result md5) { - const constexpr size_t md5_length = 16; - std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin()); + static_assert(sizeof(md5) ==

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops, static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP)); if (!S) { const SCEV **O = SCEVAllocator.Allocate(Ops.size()); -std::uninitialized_copy(Ops.begin(), Ops.end(), O); +llvm::uninitial

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-02 Thread Alex Langford via lldb-commits
@@ -154,6 +154,19 @@ endif() add_definitions(-DLLDB_USE_OS_LOG) +if(CMAKE_OSX_SYSROOT) + set(${MIG_SYSROOT} CMAKE_OSX_SYSROOT) bulbazord wrote: Shouldn't this be `set(MIG_SYSROOT ${CMAKE_OSX_SYSROOT})`? Does this work as-is? https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread John Harrison via lldb-commits
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() { return errWrapper; } + // The launch sequence is special and we need to carefully handle + // packets in the right order. The launch and attach requests cannot + // be answered unt

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
@@ -154,6 +154,19 @@ endif() add_definitions(-DLLDB_USE_OS_LOG) +if(CMAKE_OSX_SYSROOT) + set(${MIG_SYSROOT} CMAKE_OSX_SYSROOT) chelcassanova wrote: Good catch, this doesn't work as-is. I'll update to correct this. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138020 >From 6a100fa2a13c5e8e10981746ea45c7345d3c46c9 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 28 Apr 2025 10:28:03 -0700 Subject: [PATCH] [lldb][cmake] Error out when building debugserver with

[Lldb-commits] [lldb] [lldb][test] Disable flaky TestLldbGdbServer.py (PR #138263)

2025-05-02 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/138263 See #138085 for details. >From b35ad88aa12a000c13a4cc854fd55ba59c2e8535 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 2 May 2025 16:48:21 +0400 Subject: [PATCH] [lldb][test] Disable flaky TestLldbG

[Lldb-commits] [lldb] [lldb][test] Disable flaky TestLldbGdbServer.py (PR #138263)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes See #138085 for details. --- Full diff: https://github.com/llvm/llvm-project/pull/138263.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-server/TestLldbGdbServer.py (+4) ``diff d

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-05-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolution for types parsed from declarations (PR #137974)

2025-05-02 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix raciness in launch and attach tests (PR #137920)

2025-05-02 Thread Pavel Labath via lldb-commits
labath wrote: > I'm even more unhappy with the current state of the patch. I take it you're referring to the uncritical sections. What if we don't lock the mutex automatically for each handler (but leave it up to them to figure out when/if to lock it)? Or we could have the handler declare in s

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolution for types parsed from declarations (PR #137974)

2025-05-02 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/137974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable flaky TestLldbGdbServer.py (PR #138263)

2025-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/138263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix block address resolution for functions in multiple sections (PR #137955)

2025-05-02 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137955 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread Pavel Labath via lldb-commits
labath wrote: > who has the handle would be able to use them They are, but unless they know about them, the FD is just going to sit there, forever. I love to educate people about FDs, so here's a crash course. Suppose you want to communicate with a child process. Here's one way to do this: ``

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { +

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-02 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: A very predictable question. Why is the implementation of this more complicated than `base->GetChildMemberWithName(name)`. I think it shouldn't be. To avoid repeating the same points over and over, I suggest going through the discussion on the dereference/a

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -272,4 +272,204 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +lldb::ValueObjectSP +Interpreter::EvaluateMemberOf(lldb::ValueObjectSP value, + const std::vector

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-02 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/138093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7d01b85 - Reland "[lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (#129092)"

2025-05-02 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-02T13:00:12Z New Revision: 7d01b85c2a0aa8bc91f731cfeb2a7b6885b8d04a URL: https://github.com/llvm/llvm-project/commit/7d01b85c2a0aa8bc91f731cfeb2a7b6885b8d04a DIFF: https://github.com/llvm/llvm-project/commit/7d01b85c2a0aa8bc91f731cfeb2a7b6885b8d04a.diff LOG

[Lldb-commits] [lldb] [lldb] Upgrade ExtractIndexFromString to use llvm::Expected (PR #138297)

2025-05-02 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/138297 This PR is in continuation of https://github.com/llvm/llvm-project/pull/136693. It upgrades `ExtractIndexFromString` to use `llvm::Expected`. Rate limit · GitHub b

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Sbsavecore subregions bug (PR #138206)

2025-05-02 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,35 @@ +--- !minidump +Streams: + - Type:SystemInfo +Processor Arch: AMD64 +Processor Level: 6 +Processor Revision: 15876 +Number of Processors: 40 +Platform ID: Linux +CSD Version: 'Linux 3.13.0-91-generic' +CPU: +

[Lldb-commits] [lldb] [lldb] Upgrade ExtractIndexFromString to use llvm::Expected (PR #138297)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This PR is in continuation of https://github.com/llvm/llvm-project/pull/136693. It upgrades `ExtractIndexFromString` to use `llvm::Expected`. --- Patch is 28.14 KiB, truncated to 20.00 KiB below, fu

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Sbsavecore subregions bug (PR #138206)

2025-05-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/138206 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { +

[Lldb-commits] [lldb] [lldb] Fix block address resolution for functions in multiple sections (PR #137955)

2025-05-02 Thread David Spickett via lldb-commits
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const Address &addr) { return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr); } +static AddressRange ToAddressRange(const Address &func_addr, + const Bloc

[Lldb-commits] [clang] [lldb] [windows] fix flaky linker error when building LLDB (PR #138249)

2025-05-02 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/138249 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial

[Lldb-commits] [clang] [lldb] [windows] fix flaky linker error when building LLDB (PR #138249)

2025-05-02 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/138249 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolution for types parsed from declarations (PR #137974)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -11,6 +11,22 @@ using namespace lldb_private; +std::optional ClangASTMetadata::GetIsDynamicCXXType() const { + switch (m_is_dynamic_cxx) { + case 0: labath wrote: I don't think that's necessary given that the only one who needs to know about them are t

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: > We had code which was waiting for an pipe EOF, but it never got that due to > the FD ending up in an unsuspecting (and unrelated) process. Although that's > possible to solve in a different way, I think it's still better to declare > all of the FDs passed to a process ex

[Lldb-commits] [lldb] [lldb] Fix block address resolution for functions in multiple sections (PR #137955)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const Address &addr) { return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr); } +static AddressRange ToAddressRange(const Address &func_addr, + const Bloc

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread David Spickett via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { +

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread David Spickett via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { +

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-05-02 Thread David Spickett via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/138174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix block address resolution for functions in multiple sections (PR #137955)

2025-05-02 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,102 @@ +# REQUIRES: x86, lld + +# RUN: split-file %s %t +# RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux %t/file.s -o %t/file.o +# RUN: ld.lld %t/file.o -o %t/file.out -T %t/file.lds +# RUN: %lldb %t/file.out -o "disassemble --name func1" -o exit | FileCheck %s + +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-core Author: Rahul Joshi (jurahul) Changes Add `llvm::uninitialized_copy` that accepts a range instead of start/end iterator for the source of the copy. --- Patch is 64.57 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-tablegen @llvm/pr-subscribers-backend-amdgpu Author: Rahul Joshi (jurahul) Changes Add `llvm::uninitialized_copy` that accepts a range instead of start/end iterator for the source of the copy. --- Patch is 64.57 KiB, truncated to 20.00 KiB below, full

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/138174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Jay Foad via lldb-commits
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops, static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP)); if (!S) { const SCEV **O = SCEVAllocator.Allocate(Ops.size()); -std::uninitialized_copy(Ops.begin(), Ops.end(), O); +llvm::uninitial

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-02 Thread Erich Keane via lldb-commits
https://github.com/erichkeane approved this pull request. This looks right, but I'd like someone else to go through to make sure it is right everywhere. Also, the md5 change looks... odd and counts a lot on the internal representation of md5, so I'm not sure about that one, but at least it is

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) { case lldb::eStateSuspended: break; case lldb::eStateStopped: -// We launch and attach in synchronous mode then the first stop -// event will not be delivere

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138219 >From e7333489e50b1efe16203e8fd7b6dc7f2dcd4439 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 2 May 2025 09:59:01 -0700 Subject: [PATCH] [lldb-dap] Change the launch sequence This PR changes h

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/138219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -417,8 +424,11 @@ struct DAP { lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); } private: - std::mutex m_queue_mutex; + /// Queue for all incoming messages. std::deque m_queue; + /// Dedicated queue for launching and attaching. + std::deque m_launc

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @kusmour Can you please confirm whether or not there's a reason to run the launch or attach commands in asynchronous mode? It looks like the divergence was introduced when the feature was added (https://reviews.llvm.org/D154028) and I'm not sure it's necessary. My local tes

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Thanks for adding tests. Please let others take a look before merging. https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] Handle step-in over a Darwin "branch island". (PR #138330)

2025-05-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/macosx/branch-islands/TestBranchIslands.py `` Vie

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Piotr Kubaj via lldb-commits
https://github.com/pkubaj edited https://github.com/llvm/llvm-project/pull/138331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Handle step-in over a Darwin "branch island". (PR #138330)

2025-05-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c -- lldb/test/API/macosx/branch-islands/foo.c lldb/tes

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Piotr Kubaj via lldb-commits
https://github.com/pkubaj edited https://github.com/llvm/llvm-project/pull/138331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Piotr Kubaj via lldb-commits
https://github.com/pkubaj edited https://github.com/llvm/llvm-project/pull/138331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Sbsavecore subregions bug (PR #138206)

2025-05-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/138206 >From 91ce0997c03f87ec617ec2a113e7e88f1a88de11 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 1 May 2025 14:53:08 -0700 Subject: [PATCH 1/7] Change custom regions to be intersections, add test cases fo

[Lldb-commits] [lldb] [lldb] Upgrade ExtractIndexFromString to use llvm::Expected (PR #138297)

2025-05-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I like the idea of this PR (big fan of `llvm::Expected`) but the way this is implemented contains an anti-pattern IMO. Specifically, all callers consume the error from `ExtractIndexFromString` only to then create a similar but different error string afte

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Piotr Kubaj via lldb-commits
https://github.com/pkubaj created https://github.com/llvm/llvm-project/pull/138331 Fix for: Assertion failed: (false && "Architecture or OS not supported"), function CreateRegisterContextForFrame, file /usr/src/contrib/llvm-project/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp, line

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Piotr Kubaj via lldb-commits
https://github.com/pkubaj edited https://github.com/llvm/llvm-project/pull/138331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Handle step-in over a Darwin "branch island". (PR #138330)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/138330.diff 7 Files Affected: - (modified) lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp (+20-7) - (added) lldb/test/API/macosx/

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Piotr Kubaj (pkubaj) Changes Fix for: `Assertion failed: (false && "Architecture or OS not supported"), function CreateRegisterContextForFrame, file /usr/src/contrib/llvm-project/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp, lin

[Lldb-commits] [lldb] lldb: fix crash on FreeBSD/powerpc64le (PR #138331)

2025-05-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/138331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Handle step-in over a Darwin "branch island". (PR #138330)

2025-05-02 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/138330 None >From aafaaa46cb5c9733451eea93be7d4a69cf88c7ad Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 2 May 2025 12:40:11 -0700 Subject: [PATCH] Handle step-in over a Darwin "branch island". --- .../MacO

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/3] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-02 Thread Dmitry Vasilyev via lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const FileSpec &prog, self_args.AppendArgument(llvm::StringRef("platform")); self_args.AppendArgument(llvm::StringRef("--child-platform-fd")); self_args.AppendArgument(llvm::to_string(shared_socket.Ge

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-02 Thread Dmitry Vasilyev via lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo { ExitWithError(error_fd, "close"); break; case FileAction::eFileActionDuplicate: - if (dup2(action.fd, action.arg) == -1) -ExitWithError(error_fd, "dup2"); + if (action.fd != action.arg) { -

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-02 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/137978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138219 >From e7333489e50b1efe16203e8fd7b6dc7f2dcd4439 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 2 May 2025 09:59:01 -0700 Subject: [PATCH 1/3] [lldb-dap] Change the launch sequence This PR chang

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR changes how we treat the launch sequence in lldb-dap. - Send the initialized event after we finish handling the initialize request, rather than after we finish attaching or launching. -

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/138219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >