kusmour wrote: > @kusmour Can you please confirm whether or not there's a reason to run the > launch or attach commands in asynchronous mode? It looks like the divergence > was introduced when the feature was added (https://reviews.llvm.org/D154028) > and I'm not sure it's necessary. My local testing (using the `gdb-remote > 3000` example from the README) seems to work as expected in synchronous mode > and even seems like it would desirable?
I just synced with Greg on some context. I think the nature of attachCommands will allow people do anything. What if they have a waitFor command that will not get timed out by GDBRemote timeout? Then lldb-dap will never return anything to the client. The `dap.WaitForProcessToStop(timeout_seconds);` will guarantee we at least return error if things aren't working. In fact maybe we should consider making the normal launch/attach in async and have the `dap.WaitForProcessToStop(timeout_seconds);` at the end to ensure the process is in expected state before responding to the launch/attach req? https://github.com/llvm/llvm-project/pull/138219 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
