https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/121033
This was never set to anything other than `true`.
>From e635c466deb3ed6423582049b5352a687ca017cb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 24 Dec 2024 06:57:46 +
Subject: [PATCH] [lldb][DWAR
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/2] Some base #if _AIX changes
---
.../Host/posix/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This was never set to anything other than `true`.
---
Full diff: https://github.com/llvm/llvm-project/pull/121033.diff
2 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserCl
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120978
>From 40b9ceabdda30e914a1e3ae2938566f13621429c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 11:19:07 -0600
Subject: [PATCH 1/3] clang-format changes
---
lldb/source/Host/posi
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -11,6 +11,11 @@ if(APPLE)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}
-Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-Info.plist")
endif()
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ remove_definition
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
carlocab wrote:
Seems to be good now: https://lab.llvm.org/buildbot/#/builders/195/builds/2748
https://github.com/llvm/llvm-project/pull/120901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/120569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,40 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCaseTypedefToOuterFwd(TestBase):
+"""
+We a global variable whose type is forward declared. We then
+try to
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/120569
>From 9aa49efdcde5887e8de6bcd6cfbb08c0a499e24b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 19 Dec 2024 12:25:19 +
Subject: [PATCH 1/7] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/120794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
LGTM
Can we add a test for this in `lldb/unittests/Symbol/TestTypeSystemClang.cpp`?
We could create call this API and then use `EnumConstantDecl::getInitVal` to
retrieve the `APSInt` and make sure it's unsigned
https://github.com/llvm/llvm-project/pull
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/120569
>From 9aa49efdcde5887e8de6bcd6cfbb08c0a499e24b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 19 Dec 2024 12:25:19 +
Subject: [PATCH 1/6] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the
@@ -0,0 +1,40 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCaseTypedefToOuterFwd(TestBase):
+"""
+We a global variable whose type is forward declared. We then
+try to
@@ -2299,11 +2301,103 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_va
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH] AIX Changes for MainLoop
---
lldb/source/Host/posi
Author: Michael Buch
Date: 2024-12-23T10:43:35Z
New Revision: ac5029499561a8f76e71325ffb5c59d92ff84709
URL:
https://github.com/llvm/llvm-project/commit/ac5029499561a8f76e71325ffb5c59d92ff84709
DIFF:
https://github.com/llvm/llvm-project/commit/ac5029499561a8f76e71325ffb5c59d92ff84709.diff
LOG:
@@ -11,6 +11,11 @@ if(APPLE)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}
-Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-Info.plist")
endif()
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ remove_definition
labath wrote:
Thanks.
https://github.com/llvm/llvm-project/pull/120901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH 1/2] AIX Changes for MainLoop
---
lldb/source/Host/
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/120794
>From b5cb9a262a5e1bdb19eb72e7e357c98e90fa9f4e Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Sat, 21 Dec 2024 02:04:35 +0500
Subject: [PATCH 1/3] Negate is_signed variable for argument isUnsigned
---
lldb/so
@@ -52,6 +52,7 @@ enum class StreamType : uint32_t {
#include "llvm/BinaryFormat/MinidumpConstants.def"
Unused = 0,
LastReserved = 0x,
+ LLDBGenerated = 0x4C4C4442, // ASCII for 'LLDB'
labath wrote:
Please put this in llvm/BinaryFormat/MinidumpCon
https://github.com/labath approved this pull request.
Thank you. If you really want to keep the magic header, then I guess it's fine,
but I think it adds a lot of unnecessary code and is not particularly
consistent with the other stream types (I don't remember seeing empty streams,
but I also
@@ -354,6 +354,39 @@ DataExtractor ProcessMinidump::GetAuxvData() {
GetAddressByteSize(), GetAddressByteSize());
}
+bool ProcessMinidump::IsLLDBMinidump() {
+ // If we've already checked, return the cached value
+ if (m_is_lldb_generated.has_value())
+
@@ -354,6 +354,39 @@ DataExtractor ProcessMinidump::GetAuxvData() {
GetAddressByteSize(), GetAddressByteSize());
}
+bool ProcessMinidump::IsLLDBMinidump() {
+ // If we've already checked, return the cached value
+ if (m_is_lldb_generated.has_value())
+
@@ -126,6 +129,17 @@ Status MinidumpFileBuilder::AddDirectory(StreamType type,
return error;
}
+Status MinidumpFileBuilder::AddLLDBGeneratedStream() {
+ Status error;
+ StreamType type = StreamType::LLDBGenerated;
labath wrote:
```suggestion
llvm::suppo
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -354,6 +354,39 @@ DataExtractor ProcessMinidump::GetAuxvData() {
GetAddressByteSize(), GetAddressByteSize());
}
+bool ProcessMinidump::IsLLDBMinidump() {
+ // If we've already checked, return the cached value
+ if (m_is_lldb_generated.has_value())
+
@@ -159,6 +160,22 @@ MainLoopPosix::RunImpl::RunImpl(MainLoopPosix &loop) :
loop(loop) {
read_fds.reserve(loop.m_read_fds.size());
}
+int MainLoopPosix::RunImpl::StartPoll(
+std::optional point) {
+#if HAVE_PPOLL
DhruvSrivastavaX wrote:
I noticed that
DhruvSrivastavaX wrote:
> Putting everything together, I think the code should be something like this:
Thanks for the suggestions. I have modified the implementation.
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120978
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120979
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/120794
>From b5cb9a262a5e1bdb19eb72e7e357c98e90fa9f4e Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Sat, 21 Dec 2024 02:04:35 +0500
Subject: [PATCH 1/2] Negate is_signed variable for argument isUnsigned
---
lldb/so
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/120794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ilia Kuklin
Date: 2024-12-23T18:40:09+05:00
New Revision: 92f439c4b7f234583e52e529858365c1bf072879
URL:
https://github.com/llvm/llvm-project/commit/92f439c4b7f234583e52e529858365c1bf072879
DIFF:
https://github.com/llvm/llvm-project/commit/92f439c4b7f234583e52e529858365c1bf072879.diff
L
@@ -62,6 +65,9 @@ struct InputStream {
struct OutputStream {
StreamDescriptor descriptor;
+ explicit OutputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
labath wrote:
```suggestion
: descriptor(std::move(descripto
@@ -5030,47 +5045,81 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::unique_ptr log = nullptr;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.reset(new std::ofstream(log_file_path));
labath wrote:
```suggestion
@@ -5027,43 +5019,77 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::optional log = std::nullopt;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.emplace(log_file_path);
+
// Initialize LLDB first before we do anything.
lldb:
@@ -138,15 +140,20 @@ struct SendEventRequestHandler : public
lldb::SBCommandPluginInterface {
struct DAP {
llvm::StringRef debug_adaptor_path;
+ std::ofstream *log;
InputStream input;
OutputStream output;
+ lldb::SBFile in;
+ OutputRedirector out;
+ OutputRedirec
@@ -17,47 +19,59 @@
#include "OutputRedirector.h"
#include "llvm/ADT/StringRef.h"
-using namespace llvm;
+using lldb_private::Pipe;
+using lldb_private::Status;
+using llvm::createStringError;
+using llvm::Error;
+using llvm::Expected;
+using llvm::StringRef;
namespace lldb
@@ -5030,47 +5045,81 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::unique_ptr log = nullptr;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.reset(new std::ofstream(log_file_path));
+
// Initialize LLDB first before we do anyt
@@ -17,47 +19,59 @@
#include "OutputRedirector.h"
#include "llvm/ADT/StringRef.h"
-using namespace llvm;
+using lldb_private::Pipe;
+using lldb_private::Status;
+using llvm::createStringError;
+using llvm::Error;
+using llvm::Expected;
+using llvm::StringRef;
namespace lldb
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -173,6 +179,55 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::FILE *overrideOut, std::FILE *overrideErr) {
+ auto *inull = lldb_private::FileSystem::Instance().Fopen(
+ lldb_p
https://github.com/labath commented:
We're pretty close, but I still see some presubmit failures in
TestDAP_redirection_to_console, which I have to assume are related to this
change.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits m
@@ -52,6 +52,9 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
+ explicit InputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
labath wrote:
```suggestion
: descriptor(std::move(descri
@@ -9,17 +9,38 @@
#ifndef LLDB_TOOLS_LLDB_DAP_OUTPUT_REDIRECTOR_H
#define LLDB_TOOLS_LLDB_DAP_OUTPUT_REDIRECTOR_H
+#include "lldb/Host/Pipe.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
+#include
+#include
+#include
namespace lldb_dap {
-/// Redi
Michael137 wrote:
> > FWIW, I came across another no_unique_address-related crash today:
> > ```
> > $ cat a.cc
> > struct S {
> > private:
> > int i;
> > short s;
> > };
> > static_assert(sizeof(S) == 8);
> >
> > struct T {
> > [[no_unique_address]] S s;
> > char c;
> > };
> > static_as
labath wrote:
FWIW, I came across another no_unique_address-related crash today:
```
$ cat a.cc
struct S {
private:
int i;
short s;
};
static_assert(sizeof(S) == 8);
struct T {
[[no_unique_address]] S s;
char c;
};
static_assert(sizeof(T) == 8);
T t;
$ clang++ -c -o /tmp/a.out /tmp/a.cc
https://github.com/Michael137 approved this pull request.
LGTM, thanks! (one minor nit in the test)
https://github.com/llvm/llvm-project/pull/120794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -313,6 +313,16 @@ TEST_F(TestTypeSystemClang,
TestGetEnumIntegerTypeBasicTypes) {
}
}
+TEST_F(TestTypeSystemClang, TestEnumerationValueSign) {
+ CompilerType enum_type = m_ast->CreateEnumerationType(
+ "my_enum_signed", m_ast->GetTranslationUnitDecl(),
+ Optio
labath wrote:
> > Could you create a separate PR (or two, but probably not eight) with the
> > refactoring changes, and we can rebase this PR on top of that when they
> > land?
>
> Ok. I assume "Require pull request reviews before merging" is enabled so you
> can't push a group of commits man
Author: Michael Buch
Date: 2024-12-23T11:51:28Z
New Revision: 28d14904c00b74154b8dfa71d5b062a7e590c44c
URL:
https://github.com/llvm/llvm-project/commit/28d14904c00b74154b8dfa71d5b062a7e590c44c
DIFF:
https://github.com/llvm/llvm-project/commit/28d14904c00b74154b8dfa71d5b062a7e590c44c.diff
LOG:
Author: Michael Buch
Date: 2024-12-23T11:51:51Z
New Revision: c660b281b60085cbe40d73d692badd43d7708d20
URL:
https://github.com/llvm/llvm-project/commit/c660b281b60085cbe40d73d692badd43d7708d20
DIFF:
https://github.com/llvm/llvm-project/commit/c660b281b60085cbe40d73d692badd43d7708d20.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/120809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/120569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> FWIW, I came across another no_unique_address-related crash today:
>
> ```
> $ cat a.cc
> struct S {
> private:
> int i;
> short s;
> };
> static_assert(sizeof(S) == 8);
>
> struct T {
> [[no_unique_address]] S s;
> char c;
> };
> static_assert(sizeof(T) == 8);
>
>
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH 1/3] AIX Changes for MainLoop
---
lldb/source/Host/
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/120971
Add the Data Inspection Language (DIL) implementation pieces for handling plain
local and global variable names.
See https://discourse.llvm.org/t/rfc-data-inspection-language/69893 for
information about DIL.
T
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Add the Data Inspection Language (DIL) implementation pieces for handling plain
local and global variable names.
See https://discourse.llvm.org/t/rfc-data-inspection-language/69893 for
information about DIL.
This ch
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
23a239267e8a1d20ed10d3545feaf2a2bb70b085...c14a0e3f80c1cc49a6717b41c8b90e2258168399
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 23a239267e8a1d20ed10d3545feaf2a2bb70b085
c14a0e3f80c1cc49a6717b41c8b90e2258168399 --e
@@ -138,15 +140,20 @@ struct SendEventRequestHandler : public
lldb::SBCommandPluginInterface {
struct DAP {
llvm::StringRef debug_adaptor_path;
+ std::ofstream *log;
InputStream input;
OutputStream output;
+ lldb::SBFile in;
+ OutputRedirector out;
+ OutputRedirec
@@ -17,47 +19,59 @@
#include "OutputRedirector.h"
#include "llvm/ADT/StringRef.h"
-using namespace llvm;
+using lldb_private::Pipe;
+using lldb_private::Status;
+using llvm::createStringError;
+using llvm::Error;
+using llvm::Expected;
+using llvm::StringRef;
namespace lldb
@@ -62,6 +65,9 @@ struct InputStream {
struct OutputStream {
StreamDescriptor descriptor;
+ explicit OutputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/120
@@ -52,6 +52,9 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
+ explicit InputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
ashgti wrote:
Done
https://github.com/llvm/llvm-project/pull/1
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From 4131b8c5af83a219efb2513a1ac90e8b9877d2ef Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/7] [lldb-dap] Ensure the IO forwarding threads are managed
by t
@@ -9,17 +9,38 @@
#ifndef LLDB_TOOLS_LLDB_DAP_OUTPUT_REDIRECTOR_H
#define LLDB_TOOLS_LLDB_DAP_OUTPUT_REDIRECTOR_H
+#include "lldb/Host/Pipe.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
+#include
+#include
+#include
namespace lldb_dap {
-/// Redi
@@ -17,47 +19,59 @@
#include "OutputRedirector.h"
#include "llvm/ADT/StringRef.h"
-using namespace llvm;
+using lldb_private::Pipe;
+using lldb_private::Status;
+using llvm::createStringError;
+using llvm::Error;
+using llvm::Expected;
+using llvm::StringRef;
namespace lldb
@@ -173,6 +179,55 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::FILE *overrideOut, std::FILE *overrideErr) {
+ auto *inull = lldb_private::FileSystem::Instance().Fopen(
+ lldb_p
@@ -5030,47 +5045,81 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::unique_ptr log = nullptr;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.reset(new std::ofstream(log_file_path));
+
// Initialize LLDB first before we do anyt
@@ -5030,47 +5045,81 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::unique_ptr log = nullptr;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.reset(new std::ofstream(log_file_path));
ashgti wrote:
Done.
https://
ashgti wrote:
I have the linux tests working by avoiding the `Host/FileSystem` API, let me
know if I should adjust the linkage though.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From 4131b8c5af83a219efb2513a1ac90e8b9877d2ef Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/6] [lldb-dap] Ensure the IO forwarding threads are managed
by t
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/4] Make workaround for the Dynamic loader issue
---
.../Minid
@@ -126,6 +129,17 @@ Status MinidumpFileBuilder::AddDirectory(StreamType type,
return error;
}
+Status MinidumpFileBuilder::AddLLDBGeneratedStream() {
+ Status error;
+ StreamType type = StreamType::LLDBGenerated;
Jlalond wrote:
Dropped the magic bytes an
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 72e8b9aeaa3f584f223bc59924812df69a09a48b
2214e6c2017a1b224d1b35f9d6d39251a9b38e74 --e
Jlalond wrote:
> I don't find the "MinidumpParser does not distinguish empty/missing streams"
> argument particularly convincing, since the underlying llvm class
> (`MinidumpFile`) does distinguish them and a
> `MinidumpParser::ContainsStream()` function would be a lot simpler than this
> mag
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/5] Make workaround for the Dynamic loader issue
---
.../Minid
ashgti wrote:
I'm running into an issue on linux with this change that is resulting in 2
instances of the `lldb_private::FileSystem::Instance` being created.
```
$ lldb lldb-dap
(lldb) break set -f FileSystem.h -l 51
...
Process 1743394 resuming
/usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../.
89 matches
Mail list logo
