[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Make workaround for the Dynamic loader issue (PR #120166)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 72e8b9aeaa3f584f223bc59924812df69a09a48b 
2214e6c2017a1b224d1b35f9d6d39251a9b38e74 --extensions cpp,h -- 
lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp 
lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h 
lldb/source/Plugins/Process/minidump/MinidumpParser.cpp 
lldb/source/Plugins/Process/minidump/MinidumpParser.h 
lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp 
lldb/source/Plugins/Process/minidump/ProcessMinidump.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp 
b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
index eff099c9ea..94c0a5f11e 100644
--- a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
+++ b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
@@ -49,7 +49,8 @@ llvm::ArrayRef<uint8_t> MinidumpParser::GetStream(StreamType 
stream_type) {
   return m_file->getRawStream(stream_type).value_or(llvm::ArrayRef<uint8_t>());
 }
 
-std::optional<llvm::ArrayRef<uint8_t>> MinidumpParser::GetRawStream(StreamType 
stream_type) {
+std::optional<llvm::ArrayRef<uint8_t>>
+MinidumpParser::GetRawStream(StreamType stream_type) {
   return m_file->getRawStream(stream_type);
 }
 
diff --git a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp 
b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
index 08c3bb3f6b..05b3bb9f54 100644
--- a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
+++ b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
@@ -360,7 +360,6 @@ bool ProcessMinidump::IsLLDBMinidump() {
   return lldb_generated_section.has_value();
 }
 
-
 DynamicLoader *ProcessMinidump::GetDynamicLoader() {
   // This is a workaround for the dynamic loader not playing nice in issue
   // #119598. The specific reason we use the dynamic loader is to get the TLS

``````````

</details>


https://github.com/llvm/llvm-project/pull/120166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits