Jlalond wrote: > I don't find the "MinidumpParser does not distinguish empty/missing streams" > argument particularly convincing, since the underlying llvm class > (`MinidumpFile`) does distinguish them and a > `MinidumpParser::ContainsStream()` function would be a lot simpler than this > magic handling code.
After looking at your review, I agree. I'm not sure why I didn't want to add more features to Minidump parser, but this is much much cleaner now. https://github.com/llvm/llvm-project/pull/120166 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
