https://github.com/labath approved this pull request.
Thank you. If you really want to keep the magic header, then I guess it's fine, but I think it adds a lot of unnecessary code and is not particularly consistent with the other stream types (I don't remember seeing empty streams, but I also don't remember seeing streams that begin with a magic value -- it's kinda pointless since the stream type already serves as a sort of a magic value). I don't find the "MinidumpParser does not distinguish empty/missing streams" argument particularly convincing, since the underlying llvm class (`MinidumpFile`) does distinguish them and a `MinidumpParser::ContainsStream()` function would be a lot simpler than this magic handling code. https://github.com/llvm/llvm-project/pull/120166 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
