[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

2024-07-17 Thread David Spickett via lldb-commits
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case): test_case.expect("register read r0", substrs=["r0 = 0x"]) elif arch in ["powerpc64le"]: test_case.expect("register read r0", substrs=["r0 = 0x"]) +elif arch in ["rv64gc"]: D

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

2024-07-17 Thread David Spickett via lldb-commits
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case): test_case.expect("register read r0", substrs=["r0 = 0x"]) elif arch in ["powerpc64le"]: test_case.expect("register read r0", substrs=["r0 = 0x"]) +elif arch in ["rv64gc"]: D

[Lldb-commits] [lldb] a751f65 - [lldb][RISCV] function prologue backtrace fix (#99043)

2024-07-17 Thread via lldb-commits
Author: dlav-sc Date: 2024-07-17T09:36:19+01:00 New Revision: a751f653b40f2021f091a2f1ebcc2d91bc4cc89d URL: https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d DIFF: https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d.diff LOG:

[Lldb-commits] [lldb] [lldb][RISCV] function prologue backtrace fix (PR #99043)

2024-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/99043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] function prologue backtrace fix (PR #99043)

2024-07-17 Thread via lldb-commits
github-actions[bot] wrote: @dlav-sc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/97273 >From d812b8067d622b84af2ee62b837b87cb4479a477 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Wed, 17 Jul 2024 02:21:21 -0700 Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

2024-07-17 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/99305 This is a preparatory step for teaching the function about anonymous namespaces. It started out as a way to remove the assumption that the pattern and target contexts must be of the same length -- that's will not

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

2024-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is a preparatory step for teaching the function about anonymous namespaces. It started out as a way to remove the assumption that the pattern and target contexts must be of the same length -- that's will

[Lldb-commits] [lldb] [lldb] Fixed the error `unable to launch a GDB server` in API tests (PR #98833)

2024-07-17 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Agreed, so silent UB would just be making things worse. So, this patch fixes that issue, right? > Perhaps I am spelling the port option differently, or you mean a lldb-server > gdbserver launched by a platform ignores the port. It seems it depends on the system. Note I'm w

[Lldb-commits] [lldb] [lldb] Fixed the error `unable to launch a GDB server` in API tests (PR #98833)

2024-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: > So, this patch fixes that issue, right? Yes I think so, give me some time to test it myself. https://github.com/llvm/llvm-project/pull/98833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/99266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB)) endif CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +else +ifneq (,$(findstring clang,$

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -80,9 +78,21 @@ endif # Also reset BUILDDIR value because "pwd" returns cygwin or msys path # which needs to be converted to windows path. #-- -ifeq "$(OS)" "Windows_NT" - SHELL = $(WINDIR)\system32\cm

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -418,11 +437,28 @@ ifeq (1, $(USE_SYSTEM_STDLIB)) endif endif +# No C++ library has been specifieed. Use libstdc++ by default. +ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB))) + # If no explicit request was made, but we have paths to a custo

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -263,9 +280,9 @@ CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS) # Use this one if you want to build one part of the result without debug information: ifeq "$(OS)" "Darwin" - CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) $(ARCH_CFLAGS) $(CFLA

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -432,18 +468,18 @@ ifeq (1,$(USE_LIBCPP)) ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" "" CXXFLAGS += -cxx-isystem $(LIBCPP_INCLUDE_TARGET_DIR) endif - LDFLAGS += -L$(LIBCPP_LIBRARY_DIR) -Wl,-rpath,$(LIBCPP

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -296,11 +313,13 @@ endif CFLAGS += $(CFLAGS_EXTRAS) CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS) LD = $(CC) -LDFLAGS ?= $(CFLAGS) +# Copy common options to the linker flags (dwarf, arch. & etc). +#Note: we get some 'garbage' options for linker here (such as -I, --isyste

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -296,11 +313,13 @@ endif CFLAGS += $(CFLAGS_EXTRAS) CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS) LD = $(CC) -LDFLAGS ?= $(CFLAGS) +# Copy common options to the linker flags (dwarf, arch. & etc). +#Note: we get some 'garbage' options for linker here (such as -I, --isyste

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: It may be better to split this into smaller patches, given the fragility of this code. (Basically, one patch for each of your bullet points). Also, can you elaborate on this part? > Paths are turned into POSIX-style since some tests and Unix utilities use

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-07-17 Thread Pavel Labath via lldb-commits
@@ -56,15 +57,12 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../ # inherited all the way down to the process spawned for make. #-- ifeq "$(HOST_OS)" "" - HOST_OS := $(shell uname -s) -endif - -ifneq (,$(f

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread Leandro Lupori via lldb-commits
https://github.com/luporl created https://github.com/llvm/llvm-project/pull/99323 verbose_trap.test, added in #80368, fails on some Windows bots. See https://lab.llvm.org/buildbot/#/builders/141/builds/808. >From f57dd945e6c2e4d4b3d5a97b2ed05418d91902ac Mon Sep 17 00:00:00 2001 From: Leandro L

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) Changes verbose_trap.test, added in #80368, fails on some Windows bots. See https://lab.llvm.org/buildbot/#/builders/141/builds/808. --- Full diff: https://github.com/llvm/llvm-project/pull/99323.diff 1 Files Affe

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Disabling this for now is fine with me. ``` # shell parser error on RUN: at line 1: c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe --target=specify-a-target-or-use-a-_host-substitution --target=aarch64-pc-windows

[Lldb-commits] [lldb] ec9d62f - [lldb] Disable verbose_trap.test on Windows (#99323)

2024-07-17 Thread via lldb-commits
Author: Leandro Lupori Date: 2024-07-17T11:45:49-03:00 New Revision: ec9d62fe84fe314370a256306c083a9e7079b80b URL: https://github.com/llvm/llvm-project/commit/ec9d62fe84fe314370a256306c083a9e7079b80b DIFF: https://github.com/llvm/llvm-project/commit/ec9d62fe84fe314370a256306c083a9e7079b80b.diff

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread Leandro Lupori via lldb-commits
https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc created https://github.com/llvm/llvm-project/pull/99336 To make function calls inside lldb expressions ABI support, JIT engine support are required. This patch augments corresponding functionality to RISCV ABI and implements RISCV relocation resolver in JIT, which al

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (dlav-sc) Changes To make function calls inside lldb expressions ABI support, JIT engine support are required. This patch augments corresponding functionality to RISCV ABI and implements RISCV relocation resolver in JIT, which allows

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ac4b6b662630cd4d3bf6929f2b39ea203c0054a1...3ad75f024eec22f2dfd0ae7cc911f6d70202932d lldb/

[Lldb-commits] [lldb] [lldb] progressive progress reporting for darwin kernel/firmware (PR #98845)

2024-07-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/98845 >From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Sun, 14 Jul 2024 16:59:51 -0700 Subject: [PATCH 1/8] [lldb] progressive progress reporting for darwin kernel

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -1222,7 +1223,19 @@ lldb::SBError SBProcess::SaveCore(const char *file_name) { lldb::SBError SBProcess::SaveCore(const char *file_name, const char *flavor, SaveCoreStyle core_style) { - LLDB_INSTRUMENT_VA(

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -1271,13 +1271,13 @@ class CommandObjectProcessSaveCore : public CommandObjectParsed { switch (short_option) { case 'p': -m_requested_plugin_name = option_arg.str(); +m_core_dump_options.SetCoreDumpPluginName(option_arg.data());

[Lldb-commits] [lldb] 86ef699 - [lldb] progressive progress reporting for darwin kernel/firmware (#98845)

2024-07-17 Thread via lldb-commits
Author: Jason Molenda Date: 2024-07-17T10:05:55-07:00 New Revision: 86ef699060394c82dcda7e86ff70d8cabeabcc2a URL: https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a DIFF: https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a.diff

[Lldb-commits] [lldb] [lldb] progressive progress reporting for darwin kernel/firmware (PR #98845)

2024-07-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/98845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,45 @@ +//===-- CoreDumpOptions.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits
https://github.com/luporl created https://github.com/llvm/llvm-project/pull/99357 libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that maps to printf on Windows. Include stdio.h to avoid linker errors on Windows. See https://lab.llvm.org/buildbot/#/builders/141/builds/853 >From 9d

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) Changes libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that maps to printf on Windows. Include stdio.h to avoid linker errors on Windows. See https://lab.llvm.org/buildbot/#/builders/141/builds/853 ---

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits
luporl wrote: Test added in #98330. https://github.com/llvm/llvm-project/pull/99357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei created https://github.com/llvm/llvm-project/pull/99362 @walter-erquinigo found the the [PR with testing and a fix for DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue when working with stripped binaries. The issue is that when you're w

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes @walter-erquinigo found the the [PR with testing and a fix for DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue when working with stripped binaries. The issue is that when you're

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits
luporl wrote: Merging to fix https://lab.llvm.org/buildbot/#/builders/141/builds/853, which has been broken for over 36 hours. https://github.com/llvm/llvm-project/pull/99357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] 93d38d7 - [lldb][test] Fix simulator test for std::unique_ptr (#99357)

2024-07-17 Thread via lldb-commits
Author: Leandro Lupori Date: 2024-07-17T14:49:22-03:00 New Revision: 93d38d7f08864397f1e751c8cecde5ea302ecced URL: https://github.com/llvm/llvm-project/commit/93d38d7f08864397f1e751c8cecde5ea302ecced DIFF: https://github.com/llvm/llvm-project/commit/93d38d7f08864397f1e751c8cecde5ea302ecced.diff

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits
https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

2024-07-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Anytime we change this code it makes me nervous. The unit tests are quite simple and not sure how they match up against real world lookups, but as far as I can tell this looks ok. https://github.com/llvm/llvm-project/pull/99305 __

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -106,12 +106,19 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); if (!dsym_fspec || IsDwpSymbolFile(module_sp, dsym_fspec)) { -// If we have a stripp

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: [Most recent commit on this](b97d59c78ac0e25e1af15608f711b0f7a3f5b1bd) on this sisyphean patch LGTM. I did leave a nit for wording on the comment but view it as optional. https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei updated https://github.com/llvm/llvm-project/pull/99362 >From 1494617c82065e44617b013c96ba51e578706d75 Mon Sep 17 00:00:00 2001 From: Kevin Frei Date: Mon, 25 Mar 2024 08:23:47 -0700 Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/ Reapply "D

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Kevin Frei via lldb-commits
@@ -106,12 +106,19 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); if (!dsym_fspec || IsDwpSymbolFile(module_sp, dsym_fspec)) { -// If we have a stripp

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: This LGTM, although I'd rather have someone like @clayborg taking a look https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

2024-07-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: To make sure I'm clear: I don't have a problem with the basic idea of the change, although we could comment what is going on more clearly, and I'm curious about that qMemoryRegionInfo packet. But it looks like you're connecting to a device which can't allocate memory throu

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-07-17 Thread Kevin Frei via lldb-commits
kevinfrei wrote: > This LGTM, although I'd rather have someone like @clayborg taking a look Yeah, I try not to bug him too much, since he's a coworker and I already get his time in a few recurring meetings. I might actually try to grab a VC with him to see if there's some other scenario I'm mi

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/98403 >From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 9 Jul 2024 13:30:46 -0700 Subject: [PATCH 1/5] Create CoreDumpOption class, and SB equivalent --- lldb/incl

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -1271,13 +1271,13 @@ class CommandObjectProcessSaveCore : public CommandObjectParsed { switch (short_option) { case 'p': -m_requested_plugin_name = option_arg.str(); +m_core_dump_options.SetPluginName(option_arg.data()); Jlalond

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -355,11 +355,9 @@ size_t ObjectFilePECOFF::GetModuleSpecifications( } bool ObjectFilePECOFF::SaveCore(const lldb::ProcessSP &process_sp, -const lldb_private::FileSpec &outfile, -lldb::SaveCoreStyle &core_style,

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/98403 >From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 9 Jul 2024 13:30:46 -0700 Subject: [PATCH 1/6] Create CoreDumpOption class, and SB equivalent --- lldb/incl

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/98403 >From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 9 Jul 2024 13:30:46 -0700 Subject: [PATCH 1/7] Create CoreDumpOption class, and SB equivalent --- lldb/incl

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Jacob Lalonde via lldb-commits
@@ -132,8 +132,13 @@ def test_save_linux_mini_dump(self): stacks_to_sp_map, ) +options = lldb.SBCoreDumpOptions() +core_sb_stack_spec = lldb.SBFileSpec(core_sb_stack) +options.SetOutputFile(core_sb_stack_spec) +

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -178,6 +178,8 @@ class PluginManager { static bool UnregisterPlugin(ObjectFileCreateInstance create_callback); + static bool IsRegisteredPluginName(const char *name); clayborg wrote: This function name needs to be more complete to say we are searching

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -639,6 +640,18 @@ static ObjectFileInstances &GetObjectFileInstances() { return g_instances; } +bool PluginManager::IsRegisteredPluginName(const char *name) { clayborg wrote: `name` will now be a `llvm::StringRef` https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -56,18 +56,20 @@ size_t ObjectFileMinidump::GetModuleSpecifications( } bool ObjectFileMinidump::SaveCore(const lldb::ProcessSP &process_sp, - const lldb_private::FileSpec &outfile, - lldb::SaveCoreStyle &core

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -1256,7 +1256,7 @@ class CommandObjectProcessSaveCore : public CommandObjectParsed { class CommandOptions : public Options { public: -CommandOptions() = default; +CommandOptions(){}; clayborg wrote: revert this to use "= default;". The code is

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,55 @@ +//===-- CoreDumpOptions.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,55 @@ +//===-- CoreDumpOptions.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,25 @@ +"""Test the SBCoreDumpOptions APIs.""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class SBCoreDumpOptionsAPICase(TestBase): +def test_plugin_name_assignment(self): +"""Test""" +options =

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -6519,14 +6519,16 @@ struct page_object { }; bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp, - const FileSpec &outfile, - lldb::SaveCoreStyle &core_style, Status &error) { - if (!process_sp) -

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,76 @@ +//===-- SBCoreDumpOptions.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,55 @@ +//===-- CoreDumpOptions.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -639,6 +640,18 @@ static ObjectFileInstances &GetObjectFileInstances() { return g_instances; } +bool PluginManager::IsRegisteredPluginName(const char *name) { + if (!name || !name[0]) clayborg wrote: Ask the `llvm::StringRef` if is it empty: ``` if (nam

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/98403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/98403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,86 @@ +//===-- SBCoreDumpOptions.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -689,30 +702,38 @@ PluginManager::GetObjectFileCreateMemoryCallbackForPluginName( } Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp, - const FileSpec &outfile, - lldb::SaveCoreStyle &core_style, -

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -6519,14 +6519,15 @@ struct page_object { }; bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp, - const FileSpec &outfile, - lldb::SaveCoreStyle &core_style, Status &error) { - if (!process_sp) -

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-17 Thread Jason Molenda via lldb-commits
@@ -229,6 +229,17 @@ bool ScriptedThread::CalculateStopInfo() { LLVM_PRETTY_FUNCTION, "Failed to get scripted thread stop info.", error, LLDBLog::Thread); + // If we're at a BreakpointSite, mark that we stopped there and jasonmolenda wrote:

[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

2024-07-17 Thread via lldb-commits
dlav-sc wrote: I connect to a riscv (rv64gv) machine, nothing special. Lldb can just allocate memory on remote target only if the target supports executing JIT-compiled code (`if (process_is_alive && process_sp->CanJIT())` on the line `68`), otherwise lldb falls through and starts finding sui

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99044 >From 2bca6288a3d7ce04191c28280d05d6255fc3019a Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 14:09:04 + Subject: [PATCH] [lldb] SHT_NOBITS sections type Sections with SHT_NOBITS type sh

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99044 >From 2b62658701e6a2c2cb651dc1a634c03bbb385f0d Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 14:09:04 + Subject: [PATCH] [lldb] SHT_NOBITS sections type Sections with SHT_NOBITS type sh

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

2024-07-17 Thread via lldb-commits
dlav-sc wrote: > I'm wondering if there's a more fundamental fix to be made here. Like perhaps > treating treating any allocatable SHT_NOBITS section as ZeroFill. > > Basically to add `case SHT_NOBITS: if (H.sh_flags & SHF_ALLOC) return > eSectionTypeZeroFill;` to `GetSectionType` (line 1716)

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99039 >From e0e8ce7f438b17bfd1931021361ff5044e6e7ced Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:08:43 + Subject: [PATCH] [lldb] add RISCV target specific info in API tests Add informati

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

2024-07-17 Thread via lldb-commits
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case): test_case.expect("register read r0", substrs=["r0 = 0x"]) elif arch in ["powerpc64le"]: test_case.expect("register read r0", substrs=["r0 = 0x"]) +elif arch in ["rv64gc"]: d

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From c35ab331df2bc76a32d36a51ecb020ea2c13ff39 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/96260 >From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 20 Jun 2024 17:53:17 -0700 Subject: [PATCH 1/7] [lldb] Change lldb's breakpoint handling behavior lldb

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

2024-07-17 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

2024-07-17 Thread via lldb-commits
dlav-sc wrote: I have also removed `.Cases(".bss", ".tbss", eSectionTypeZeroFill)`. To be honest, I'm not sure about that. .bss and .tbss have SHT_NOBITS type and SHF_ALLOC flag by [Linux Specification](https://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/specialsections

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/96260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -355,11 +355,10 @@ size_t ObjectFilePECOFF::GetModuleSpecifications( } bool ObjectFilePECOFF::SaveCore(const lldb::ProcessSP &process_sp, -const lldb_private::FileSpec &outfile, -lldb::SaveCoreStyle &core_style

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,69 @@ +//===-- SBCoreDumpOptions.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,44 @@ +//===-- CoreDumpOptions.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-17 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,52 @@ +//===-- CoreDumpOptions.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-17 Thread Lang Hames via lldb-commits
lhames wrote: > > Regarding the orc-rt test failures: I tried building one of the failing > > objects and I can't reproduce the failure. Perhaps, because the tests are > > run on Windows and I'm running on Linux? It would be very helpful if > > @Prabhuk could run the failing command on a debug