[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Comment at: lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module1.h:7 +struct ClassInMod1 { + ClassInMod3 VecInMod1; +};

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap

[Lldb-commits] [lldb] aff1f63 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T11:55:40+02:00 New Revision: aff1f6310e5f4cea92c4504853d5fd824754a74f URL: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f DIFF: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f.dif

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff1f6310e5f: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module1.h:7 +struct ClassInMod1 { + ClassInMod3 VecInMod1; +}; martong wrote: > I was wondering whether you would have the crash if you used the directly t

[Lldb-commits] [PATCH] D134029: [LLDB] Properly return errors from "memory region --all"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When I wrote the initial version I forgot that a region being unmapped is not an error. There are real errors th

[Lldb-commits] [PATCH] D134030: [LLDB] Fix "memory region --all" when there is no ABI plugin

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two conditions for the loop exit. Either we hit LLDB_INVALID_ADDRESS or the ABI tells us we are beyond

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should improve error reporting by passing the status object from the Scripted Pr

[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

Michael137 updated this revision to Diff 460717. Michael137 added a comment. - Reduce test further - Separate check on decl structure into new function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133944/new/ https://reviews.llvm.org/D133944 File

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460718. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp clang/unittests/AST/ASTImporterT

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:186 + StatusSP status_sp = std::make_shared(error); + PythonObject* sb_error = new PythonObject(ToSWIGWrapper(status_sp)); + @labath In ord

[Lldb-commits] [PATCH] D134035: [LLDB] Format lldb-server's target XML

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So that the XML isn't one giant line. Which wasn't a problem for lldb

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

mstorsjo created this revision. mstorsjo added reviewers: labath, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. If a process has multiple threads, the thread with the stop info might not be the first one in the thread list. O

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460723. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D134039: [LLDB] Make instruction emulation context type private

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the first step to being able to handle non trivial types in the union. info_type effects the lifetime o

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In future I want to extend RegisterInfo and that will likely be non

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This happens if the type is described elsewhere in target xml as a or . Also hardcode the function names into

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added reviewers: aprantl, clayborg. DavidSpickett added a comment. Note that this does not add any non trivial types but of course I did test it by adding some to RegisterInfo. This work is early parts of https://discourse.llvm.org/t/rfc-showing-register-fields-in-lldb/64676. =

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added a comment. In D133973#3793398 , @JDevlieghere wrote: > does this result in another search path or does that replace the former I did some local testing and it seems to add another path. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

tschuett added a comment. If I read your summary correctly, then `std::variant` would simplify your code. LLVM still uses `llvm::optional`. As there is no LLVM variant, I would go for `std::variant` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir, 'c++',

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. > As there is no LLVM variant, I would go for std::variant I was under the impression that we can use 17 language features but not library features, yet. Let me check that what the minimum toolchains have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e229831154: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [lldb] 67e2298 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T16:36:00+02:00 New Revision: 67e22983115451ef5512ad2813dd337762c52da3 URL: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3 DIFF: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3.dif

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir, 'c++'

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir, 'c++',

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. Variant is supported from: libstdc++ 7.1 VS 2017 15.0 libcxx 4.0 So far so good relative to https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library. https://en.cppreference.com/w/cpp/compiler_support/17#C.2B.2B17_library_featu

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e450d134755: [lldb] Use SWIG_fail in python-typemaps.swig (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133961/new/ https:

[Lldb-commits] [lldb] 6e450d1 - [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

Author: Dave Lee Date: 2022-09-16T08:25:01-07:00 New Revision: 6e450d134755c41bd4ac0ba356e31fc37ba88757 URL: https://github.com/llvm/llvm-project/commit/6e450d134755c41bd4ac0ba356e31fc37ba88757 DIFF: https://github.com/llvm/llvm-project/commit/6e450d134755c41bd4ac0ba356e31fc37ba88757.diff LOG:

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a-zA-Z0-9_]+:: JDevlieghere wrote: > rupprec

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione updated this revision to Diff 460778. kastiglione added a comment. Rename to consumeInlineNamespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 Files: lldb/source/Plugins/Language/CPlusP

[Lldb-commits] [lldb] 3004a75 - [lldb][tests][gmodules] Test for expression evaluator crash for types referencing the same template

Author: Michael Buch Date: 2022-09-16T12:38:49-04:00 New Revision: 3004a759bcdf7b0a2a3a4220ed216d20defbd081 URL: https://github.com/llvm/llvm-project/commit/3004a759bcdf7b0a2a3a4220ed216d20defbd081 DIFF: https://github.com/llvm/llvm-project/commit/3004a759bcdf7b0a2a3a4220ed216d20defbd081.diff

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGe456d2ba8bca: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] e456d2b - [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Author: Michael Buch Date: 2022-09-16T12:38:50-04:00 New Revision: e456d2ba8bcadaa63386b339a4f2abcb39505502 URL: https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502 DIFF: https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502.diff

[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types that reference same template class

This revision was automatically updated to reflect the committed changes. Closed by commit rG3004a759bcdf: [lldb][tests][gmodules] Test for expression evaluator crash for types… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] d21b417 - [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

Author: Zequan Wu Date: 2022-09-16T10:19:09-07:00 New Revision: d21b417025f8051638f467007af957f2ed9f614a URL: https://github.com/llvm/llvm-project/commit/d21b417025f8051638f467007af957f2ed9f614a DIFF: https://github.com/llvm/llvm-project/commit/d21b417025f8051638f467007af957f2ed9f614a.diff LOG

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21b417025f8: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

jingham added a comment. The more we gather up the "things you have to do before an operation starts" or after it ends, etc. into WillDoOperation methods, the less ad hoc code you have in the callers that you have to remember to copy over if you are introducing a different way of doing the same

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This version looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133858/new/ https://reviews.llvm.org/D133858 ___

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. This LGTM and it worked without issues when I ran some tests on my machine, but please let @JDevlieghere have another look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

jingham added a comment. We never made any guarantee about the order threads would be listed in the array returned by GetThreadList. I'm not sure it would be worth trying to do that, because often you don't know whether a thread's public StopInfo will be valid even if the private stop info is.

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu created this revision. zequanwu added reviewers: labath, martong, rnk. Herald added a subscriber: rnkovacs. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a record type doesn't have compl

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

mstorsjo added a comment. In D134037#3796251 , @jingham wrote: > We never made any guarantee about the order threads would be listed in the > array returned by GetThreadList. I'm not sure it would be worth trying to do > that, because often you don't k

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

mstorsjo updated this revision to Diff 460880. mstorsjo added a comment. Added a testcase. I'm not sure if this is the most accurate/correct place for the test, but the name is at least verbose enough to describe what it exercises. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } Is this what we do for DWARF? The same k

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. @Michael137, your change is causing cmake to fail on one of our bots: https://lab.llvm.org/buildbot/#/builders/217/builds/11819 CMake Error at cmake/modules/AddLLVM.cmake:1867 (add_custom_target): add_custom_target cannot create target "check-lldb-api-lang-cpp-gm

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

Michael137 added a comment. In D133876#3796847 , @dyung wrote: > @Michael137, your change is causing cmake to fail on one of our bots: > > https://lab.llvm.org/buildbot/#/builders/217/builds/11819 > > CMake Error at cmake/modules/AddLLVM.cmake:1867 (add

Re: [Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

To be more specific, the problem is that there used to be a directory in the test suite called gmodules-template and Michael moved it to gmodules/template to better organize the tests. But our rule for making a test name from subdirectories is to replace the "/" with a "-" so these two ended up

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } rnk wrote: > Is this what we do for

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu planned changes to this revision. zequanwu added a comment. It seems not correct. The dwarf test expects an error. I should figure out how to reduce that original

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. So you can use __PRETTY_FUNCTION__ in log messages if you want to get a demangled name for a C++ function, but that includes args, so it might be too verbose in a log message. Reposit

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. In D133876#3796923 , @Michael137 wrote: > In D133876#3796847 , @dyung wrote: > >> @Michael137, your change is causing cmake to fail on one of our bots: >> >> https://lab.llvm.org/buildbot/#

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

Michael137 added a comment. In D133876#3797098 , @dyung wrote: > In D133876#3796923 , @Michael137 > wrote: > >> In D133876#3796847 , @dyung wrote: >> >>> @Michael137, you

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. In D133876#3797145 , @Michael137 wrote: > In D133876#3797098 , @dyung wrote: > >> In D133876#3796923 , @Michael137 >> wrote: >> >>> In D133876#379

[Lldb-commits] [lldb] edc1c9f - [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-09-17T12:19:09+08:00 New Revision: edc1c9f6108a4eae24990928f914fe5a39f57ca6 URL: https://github.com/llvm/llvm-project/commit/edc1c9f6108a4eae24990928f914fe5a39f57ca6 DIFF: https://github.com/llvm/llvm-project/commit/edc1c9f6108a4eae24990928f914fe5a39f57ca6.diff LOG: [

[Lldb-commits] [PATCH] D133670: [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rGedc1c9f6108a: [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added a comment. Just one nit about double checking if auto deducing is enabled. Fix that and this is good to go. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:305 + if (GetBreakpoint()->GetTarget().GetAutoSourceMapRelative()) +DeduceSourceM

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460973. yinghuitan added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h ll