jingham added a comment. The more we gather up the "things you have to do before an operation starts" or after it ends, etc. into WillDoOperation methods, the less ad hoc code you have in the callers that you have to remember to copy over if you are introducing a different way of doing the same operation. It also expresses when the operation needs to be done, which if you just had a call out in Process::Attach or whatever you would not know. Either way will work, but I think packaging these "do before" and "do after" tasks into methods makes everything clearer and easier to maintain.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133858/new/ https://reviews.llvm.org/D133858 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
