martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: 
lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module1.h:7
+struct ClassInMod1 {
+  ClassInMod3<float> VecInMod1;
+};
----------------
I was wondering whether you would have the crash if you used the directly the 
base class? I.e. if you had the `ClassInMod3Base<int> VecInMod1` here and 
`ClassInMod3Base<int> VecInMod2` in the other module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133944/new/

https://reviews.llvm.org/D133944

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to