mstorsjo added a comment. In D134037#3796251 <https://reviews.llvm.org/D134037#3796251>, @jingham wrote:
> We never made any guarantee about the order threads would be listed in the > array returned by GetThreadList. I'm not sure it would be worth trying to do > that, because often you don't know whether a thread's public StopInfo will be > valid even if the private stop info is. For instance, if a thread hits a > thread specific breakpoint for a thread that isn't in the breakpoint's thread > specifier, then we reset the stop info back to an empty one because formally > that thread didn't hit our breakpoint... So this change is clearly right. > > I don't suppose there's a way to write a test for this? Actually, yes, it is testable fairly easily - by firing up a test example with 2 threads and hitting a crash or breakpoint in either of them, and running it with a `-k` option. Before this fix, the test would still pass maybe half of the time, but now it should pass reliably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134037/new/ https://reviews.llvm.org/D134037 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
