[Lldb-commits] [lldb] 71cfce8 - [lldb] Fix TestCompressedVectors after array type name change

Author: Raphael Isemann Date: 2021-10-22T10:15:53+02:00 New Revision: 71cfce832054dfea8e79769f15a3fdc05d23b733 URL: https://github.com/llvm/llvm-project/commit/71cfce832054dfea8e79769f15a3fdc05d23b733 DIFF: https://github.com/llvm/llvm-project/commit/71cfce832054dfea8e79769f15a3fdc05d23b733.dif

[Lldb-commits] [lldb] b5e9f83 - [lldb] Remove ConstString from ABI, Architecture and Disassembler plugin names

Author: Pavel Labath Date: 2021-10-22T10:29:19+02:00 New Revision: b5e9f83ea48e29f0fe6d03354303179e5daaec1e URL: https://github.com/llvm/llvm-project/commit/b5e9f83ea48e29f0fe6d03354303179e5daaec1e DIFF: https://github.com/llvm/llvm-project/commit/b5e9f83ea48e29f0fe6d03354303179e5daaec1e.diff

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

labath accepted this revision. labath added a comment. It makes things a bit more complicated, which then makes the case for dropping char slightly stronger, but I still don't think it's worth making a fuss of it. Comment at: llvm/unittests/ADT/StringExtrasTest.cpp:327 + + EX

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath updated this revision to Diff 381500. labath added a comment. - support single command only - add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212 Files: lldb/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] 66e06cc - [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

Author: Michał Górny Date: 2021-10-22T12:27:46+02:00 New Revision: 66e06cc8cba3c39c760082a8ed469b5292f9ee67 URL: https://github.com/llvm/llvm-project/commit/66e06cc8cba3c39c760082a8ed469b5292f9ee67 DIFF: https://github.com/llvm/llvm-project/commit/66e06cc8cba3c39c760082a8ed469b5292f9ee67.diff

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e06cc8cba3: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added a comment. I agree with what Raphael said. Here's my attempt at a test case. Let me know what you think. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422 +def runBuildCommands(self, commands): +for cmd in commands: +self.tra

[Lldb-commits] [lldb] 8b8070e - Host::GetOSBuildString

Author: Pavel Labath Date: 2021-10-22T12:59:58+02:00 New Revision: 8b8070e23442351ae153e36a4d05790252c6ad96 URL: https://github.com/llvm/llvm-project/commit/8b8070e23442351ae153e36a4d05790252c6ad96 DIFF: https://github.com/llvm/llvm-project/commit/8b8070e23442351ae153e36a4d05790252c6ad96.diff

Re: [Lldb-commits] [lldb] 8b8070e - Host::GetOSBuildString

For posterity, this was meant to have a slightly better commit message: "Modernize Host::GetOSBuildString" Oops. On 22/10/2021 13:00, Pavel Labath via lldb-commits wrote: Author: Pavel Labath Date: 2021-10-22T12:59:58+02:00 New Revision: 8b8070e23442351ae153e36a4d05790252c6ad96 URL: https:/

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

labath added a comment. I'm sorry for terse response. I wanted to ensure this gets more attention, but I wasn't able to look at this straight away. Let me try to elaborate. We generally try to avoid platform-specific code in the core libraries. The unwind code is one of the biggest offenders he

[Lldb-commits] [PATCH] D112309: [lldb] [Utility/UriParser] Replace port==-1 with llvm::None

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Use llvm::Optional instead of int for port number in UriParser::Parse(), and use llvm::None to indicate missing port instead of a magic value of -1. https://rev

[Lldb-commits] [PATCH] D112309: [lldb] [Utility/UriParser] Replace port==-1 with llvm::None

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems like a (slight) improvement. You don't have to do this, but what I think would best help here is if we made a struct for these parsed results: struct URI { static Optional parse(St

[Lldb-commits] [PATCH] D112310: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

labath created this revision. labath added reviewers: clayborg, teemperor, shafik. labath requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: LLDB. Front-load the first_valid_code_address check, so that we avoid creati

[Lldb-commits] [lldb] 43f8845 - [lldb] Fix build errors from 8b8070e23

Author: Pavel Labath Date: 2021-10-22T14:28:52+02:00 New Revision: 43f8845dd371a842841a19aad063b735ff0c9ec2 URL: https://github.com/llvm/llvm-project/commit/43f8845dd371a842841a19aad063b735ff0c9ec2 DIFF: https://github.com/llvm/llvm-project/commit/43f8845dd371a842841a19aad063b735ff0c9ec2.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > Creating a new Platform entry point to provide the unwind plan (or somehow > refactoring the GetTrapHandlerSymbolNames so that it can also provide an > unwind plan) Makes sense, I'll try that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ff569ed - [lldb] [Utility/UriParser] Replace port==-1 with llvm::None

Author: Michał Górny Date: 2021-10-22T14:39:18+02:00 New Revision: ff569ed03092dba39effcc45e81d64beff800bb5 URL: https://github.com/llvm/llvm-project/commit/ff569ed03092dba39effcc45e81d64beff800bb5 DIFF: https://github.com/llvm/llvm-project/commit/ff569ed03092dba39effcc45e81d64beff800bb5.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/source/Symbol/AArch64UnwindInfo.cpp:58 + unwind_plan_sp->SetSourcedFromCompiler(eLazyBoolYes); + unwind_plan_sp->SetUnwindPlanValidAtAllInstructions(eLazyBoolNo); + unwind_plan_sp->SetUnwindPlanForSignalTrap(eLazyBoolYes);

[Lldb-commits] [PATCH] D112309: [lldb] [Utility/UriParser] Replace port==-1 with llvm::None

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff569ed03092: [lldb] [Utility/UriParser] Replace port==-1 with llvm::None (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. This looks reasonable to me. @teemperor any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112147/new/ https://reviews.llvm.org/D112147

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think there is a good Py2 replacement. I think we're just in time for the Py2->3 migration according to the timeline Jonas posted last year

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

teemperor added reviewers: clayborg, jankratochvil. teemperor added a comment. LGTM, but I have never touched this function so +Greg and Jan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112147/new/ https://reviews.llvm.org/D112147 __

[Lldb-commits] [lldb] f37463b - [lldb] Another build fix for 8b8070e23

Author: Pavel Labath Date: 2021-10-22T15:29:38+02:00 New Revision: f37463b2eef66dfae3ed669d1cbb2a34b643d071 URL: https://github.com/llvm/llvm-project/commit/f37463b2eef66dfae3ed669d1cbb2a34b643d071 DIFF: https://github.com/llvm/llvm-project/commit/f37463b2eef66dfae3ed669d1cbb2a34b643d071.diff

[Lldb-commits] [PATCH] D112314: [lldb] [Utility/UriParser] Return results as 'struct URI'

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Return results of URI parsing as 'struct URI' instead of assigning them via output parameters. https://reviews.llvm.org/D112314 Files: lldb/include/lldb/Util

[Lldb-commits] [PATCH] D112314: [lldb] [Utility/UriParser] Return results as 'struct URI'

labath added a comment. nice Comment at: lldb/include/lldb/Utility/UriParser.h:31-34 class UriParser { public: - // Parses - // RETURN VALUE - // if url is valid, function returns true and - // scheme/hostname/port/path are set to the parsed values - // port it set

[Lldb-commits] [PATCH] D112314: [lldb] [Utility/UriParser] Return results as 'struct URI'

mgorny updated this revision to Diff 381535. mgorny added a comment. Replace `UriParser::Parse()` with `URI::Parse()`. Simplify tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112314/new/ https://reviews.llvm.org/D112314 Files: lldb/include/lldb/Utility/UriParser.h lldb/source

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added inline comments. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(StringRef(LLVM_INSTALL_INCLUDEDIR)); + sys::fs::make_absolute(ActivePrefix, Path); Ericson2314 wrote: > Ericson2314 wrote: > > compn

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith added a comment. Seems like a reasonable move to me. Comment at: llvm/include/llvm/MC/TargetRegistry.h:18-19 #ifndef LLVM_SUPPORT_TARGETREGISTRY_H #define LLVM_SUPPORT_TARGETREGISTRY_H Should be `LLVM_MC_TARGETREGISTRY_H` now. ===

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

MaskRay accepted this revision. MaskRay added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 __

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

rnk added a comment. Thanks for the review! I uploaded it a bit quickly because I wanted to kick off Bazel presubmit testing, since I haven't replicated that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

lhames added a comment. Yeah -- this seems like a good idea to me. Thanks Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 378392. Ericson2314 added a comment. Herald added a project: Flang. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 378391. Ericson2314 added a comment. Rebase, avoid extra string ref conversions in llvm-config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tool

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Removed extraneous StringRef conversion after previous D111322 was landed. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(S

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 379975. Ericson2314 added a comment. Skip ${project} change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libcl

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 379976. Ericson2314 added a comment. Rebase again because previous diff changed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Respond to last open thing Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html"

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, vsk. JDevlieghere requested review of this revision. When targeting iOS, the default dwarf version is 2 and not 4. Currently, the test suite does not pick up on that because it invokes the test compiler without

[Lldb-commits] [PATCH] D112310: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for getting to this, this will be nice to avoid creating extra DWARF! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112310/new/ https

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some nits but otherwise LGTM Comment at: lldb/packages/Python/lldbsuite/test/builders/builder.py:26 +"""Returns the triple for the given architecture or an empt

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

vsk added a comment. Thanks! Lgtm as well, but with the same nits as Raphael. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112325/new/ https://reviews.llvm.org/D112325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] 0f12cf7 - [lldb] Pass the target triple when determining the DWARF version

Author: Jonas Devlieghere Date: 2021-10-22T10:13:24-07:00 New Revision: 0f12cf7ebaaf9f2a52be3baef7d25562a5ac15cb URL: https://github.com/llvm/llvm-project/commit/0f12cf7ebaaf9f2a52be3baef7d25562a5ac15cb DIFF: https://github.com/llvm/llvm-project/commit/0f12cf7ebaaf9f2a52be3baef7d25562a5ac15cb.d

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f12cf7ebaaf: [lldb] Pass the target triple when determining the DWARF version (authored by JDevlieghere). Herald added a project: LLDB. Changed pri

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282 if ((parent_tag == DW_TAG_compile_unit || - parent_tag == DW_TAG

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

mib created this revision. mib added a reviewer: dblaikie. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the string summaries for vector types by removing the space between the

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Please also remove the FIXME, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112340/new/ https://reviews.llvm.org/D112340 __

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

mib updated this revision to Diff 381629. mib added a comment. Remove FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112340/new/ https://reviews.llvm.org/D112340 Files: lldb/source/DataFormatters/FormatManager.cpp Index: lldb/source/DataF

[Lldb-commits] [lldb] 42e4959 - [lldb/Formatters] Remove space from vector type string summaries (NFCI)

Author: Med Ismail Bennani Date: 2021-10-22T21:18:54+02:00 New Revision: 42e4959253e0045a70ff9d8dcb664ce38434e302 URL: https://github.com/llvm/llvm-project/commit/42e4959253e0045a70ff9d8dcb664ce38434e302 DIFF: https://github.com/llvm/llvm-project/commit/42e4959253e0045a70ff9d8dcb664ce38434e302.

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42e4959253e0: [lldb/Formatters] Remove space from vector type string summaries (NFCI) (authored by mib). Repository: rG LLVM Github Monorepo CHAN

Re: [Lldb-commits] [lldb] 71cfce8 - [lldb] Fix TestCompressedVectors after array type name change

Thanks for the fix! (is there a buildbot email I should've got (or did and failed to understand) about this?) On Fri, Oct 22, 2021 at 1:16 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Raphael Isemann > Date: 2021-10-22T10:15:53+02:00 > New Revision: 71cfce

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

dblaikie added a comment. Sorry I missed this - are these tested anywhere/should I have been able to discover if these needed to be changed before I made the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112340/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D112109: [lldb/Plugins] Serialize ProcessLaunchInfo ScriptedProcess Dictionary

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'd like to understand what the actual problem is and whether it can be avoided before we use a workaround like this. We have different places where we use structured dat

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

teemperor added a comment. In D112340#3081532 , @dblaikie wrote: > Sorry I missed this - are these tested anywhere/should I have been able to > discover if these needed to be changed before I made the change? TestCompactVectors tests this but its unfort

[Lldb-commits] [lldb] e4235bd - Fix locals naming in DNBArchMachARM64::GetGPRState for 32-bit builds

Author: Jason Molenda Date: 2021-10-22T13:24:25-07:00 New Revision: e4235bdf26a2dd3b678daad4581d8e8edbc1aa7b URL: https://github.com/llvm/llvm-project/commit/e4235bdf26a2dd3b678daad4581d8e8edbc1aa7b DIFF: https://github.com/llvm/llvm-project/commit/e4235bdf26a2dd3b678daad4581d8e8edbc1aa7b.diff

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

JDevlieghere added a comment. Given that there's a 1:1 mapping between the target and the process, why did you change the interface as opposed to say extracting the process from the target? Comment at: lldb/examples/python/scripted_process/my_scripted_process.py:137

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny updated this revision to Diff 381645. mgorny retitled this revision from "[lldb] [lldb-server] Allow any protocol supported by lldb" to "[lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor". mgorny edited the summary of this revision. mgorny added a comment.

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib added a comment. In D112046#3081547 , @JDevlieghere wrote: > Given that there's a 1:1 mapping between the target and the process, why did > you change the interface as opposed to say extracting the process from the > target? A process is guarantee

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib added a comment. In D112046#3081556 , @mib wrote: > In D112046#3081547 , @JDevlieghere > wrote: > >> Given that there's a 1:1 mapping between the target and the process, why did >> you change the interface a

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + This should live next to the test. I don't see a point of shipping this to users. Comment at:

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/ https://reviews.llvm.org/D112046 __

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. looks good, does anyone else have any objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/D112279

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace updated this revision to Diff 381653. wallace added a comment. addressed all comments. I was able to dedup all the implementation files and the tests, and indeed passing the make flags to the build method was a good trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace updated this revision to Diff 381655. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt lldb/source/Plug

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Statistics.h:106 StatsSuccessFail m_frame_var{"frameVariable"}; + std::vector m_modules; + As modules can span (and survive) targets, I'm confused this is part of the target stats? R

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

JDevlieghere added a comment. In D112212#3080491 , @teemperor wrote: > This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think there > is a good Py2 replacement. I think we're just in time for the Py2->3 > migration according to the time

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Statistics.h:106 StatsSuccessFail m_frame_var{"frameVariable"}; + std::vector m_modules; + JDevlieghere wrote: > As modules can span (and survive) targets, I'm confused this is part of the

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

clayborg added a comment. After reading Jonas' comment about the module information being at the wrong level, I came up with a solution I think will work well. Instead of "statistics dump" emitting a dictionary for a single target when --all isn't specified, and then emitting a dictionary with

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

clayborg updated this revision to Diff 381693. clayborg added a comment. Updated "statistics dump" command to always outout a dictionary that represents DebuggerStats. This means a top level dictionary will contain "modules", a list of all modules from the global module list, and "targets" which

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

clayborg added a comment. Jonas, let me know if this new layout works for you! I updated the tests for the new output format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/D112279 _

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

wallace added a comment. this seems like a better solution. I like it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/D112279 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

dblaikie added a comment. In D112212#3081828 , @JDevlieghere wrote: > In D112212#3080491 , @teemperor > wrote: > >> This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think >> there is a good Py2