labath accepted this revision.
labath added a comment.
It makes things a bit more complicated, which then makes the case for dropping
char slightly stronger, but I still don't think it's worth making a fuss of it.
================
Comment at: llvm/unittests/ADT/StringExtrasTest.cpp:327
+
+ EXPECT_EQ(ArrayRef<StringRef>(Result), ArrayRef<StringRef>(Expected));
+}
----------------
maybe `EXPECT_THAT(Result, testing::ElementsAre("foo", "bar", "", "baz"));`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110535/new/
https://reviews.llvm.org/D110535
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
