[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99941/new/ https://reviews.llvm.org/D99941 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

DavidSpickett added a comment. Did the changes in `GDBRemoteRegisterContext.cpp` (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to another diff? Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py:41 +

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 340774. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h ll

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 340776. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Target/Process.h lldb/source

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 340778. DavidSpickett added a comment. Rebase onto main. (switch to m_current_process) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 340779. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/inc

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 340780. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

labath added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:138 +NativeProcessNetBSD::Factory::GetSupportedExtensions() const { + return Extension::multiprocess | Extension::fork | Extension::vfork

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like this, though I am still unsure about the reason for existence of the "multiprocess" extension. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:28

[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:138 +NativeProcessNetBSD::Factory::GetSupportedExtensions() const { + return Extension::multiprocess | Extension::fork | Extension::vfork; +} labath wrote: > Why

[Lldb-commits] [PATCH] D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

labath added a comment. Herald added a subscriber: JDevlieghere. In D100196#2713684 , @mgorny wrote: > Add an assert to make sure that process doesn't report fork/vfork stop reason > without multiprocess support. I guess this is the reason for that.. W

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:287 + return Extension::multiprocess | Extension::fork | Extension::vfork | + Extension::pass_signals | Extension::auxv | Extension::libraries_svr4; } lab

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid added a comment. In D99947#2718954 , @DavidSpickett wrote: > Did the changes in `GDBRemoteRegisterContext.cpp` > (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to > another diff? We no longer need to configure Address bit

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:287 + return Extension::multiprocess | Extension::fork | Extension::vfork | + Extension::pass_signals | Extension::auxv | Extension::libraries_svr4; } mgo

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. AArch64 architecture support virtual addresses with some of the top bits ignored. These ignored bits can host memory ta

[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

labath added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:138 +NativeProcessNetBSD::Factory::GetSupportedExtensions() const { + return Extension::multiprocess | Extension::fork | Extension::vfork; +} mgorny wrote: > lab

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

DavidSpickett added a comment. In D99947#2719403 , @omjavaid wrote: > In D99947#2718954 , @DavidSpickett > wrote: > >> Did the changes in `GDBRemoteRegisterContext.cpp` >> (https://reviews.llvm.org/D99947?id=33548

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:888 + // consolidated data address mask after ignoring the top byte. + if (!ReadPAuthMask().Fail()) +mask |= m_pac_mask.data_mask; I'm g

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.h:77 +return hit_addr; + } }; This is going to be used by FreeBSD, have you checked if it enables top byte ignore at all? CHANGES SINCE

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

JDevlieghere added inline comments. Comment at: lldb/docs/resources/test.rst:229 +and makes the test much harder to debug and maintain. The test programs +should always be deterministic (i.e., do not generate and check against +random test values). ja

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

mgorny added a comment. Thanks for the review. I'm going to update the tests as you suggested before pushing. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:287 + return Extension::multiprocess | Extension::fork | Extension::vfork | + Extension::

[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:138 +NativeProcessNetBSD::Factory::GetSupportedExtensions() const { + return Extension::multiprocess | Extension::fork | Extension::vfork; +} labath wrote: > mgo

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

teemperor updated this revision to Diff 340897. teemperor added a comment. - Americanized the commas (Her Majesty the Queen won't be pleased, won't she?). - Just removed some justs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153 Files: lldb

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

jingham added a comment. In D100965#2716239 , @teemperor wrote: > I am wondering how SourceLocationSpec is related to lldb's Declaration class > (which is FileSpec + line + column and describes a location in source code)? > It seems like the current Sou

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/source/Expression/UserExpression.cpp:309 +os << "expression failed to parse:\n"; +if (diagnostic_manager.Diagnostics().si

[Lldb-commits] [lldb] ca7824c - [lldb] [gdb-remote] Report QPassSignals and qXfer via extensions API

Author: Michał Górny Date: 2021-04-27T19:34:00+02:00 New Revision: ca7824c2a8dbf3e37734e10e77003acd34d0868a URL: https://github.com/llvm/llvm-project/commit/ca7824c2a8dbf3e37734e10e77003acd34d0868a DIFF: https://github.com/llvm/llvm-project/commit/ca7824c2a8dbf3e37734e10e77003acd34d0868a.diff

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca7824c2a8db: [lldb] [gdb-remote] Report QPassSignals and qXfer via extensions API (authored by mgorny). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] 25bf137 - Also display the underlying error message when displaying a fixit

Author: Adrian Prantl Date: 2021-04-27T10:40:42-07:00 New Revision: 25bf137b1ea33ff9c76834f44b10f4e1ae677d5e URL: https://github.com/llvm/llvm-project/commit/25bf137b1ea33ff9c76834f44b10f4e1ae677d5e DIFF: https://github.com/llvm/llvm-project/commit/25bf137b1ea33ff9c76834f44b10f4e1ae677d5e.diff

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25bf137b1ea3: Also display the underlying error message when displaying a fixit (authored by aprantl). Herald added a project: LLDB. Changed prior t

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, jingham. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change ensures that if for whatever reason we read less bytes than expected (for exampl

[Lldb-commits] [lldb] 711a473 - Update testcase for D101333.

Author: Adrian Prantl Date: 2021-04-27T13:24:24-07:00 New Revision: 711a473cd9e3c8e63ad3460d49fdab1545634dd2 URL: https://github.com/llvm/llvm-project/commit/711a473cd9e3c8e63ad3460d49fdab1545634dd2 DIFF: https://github.com/llvm/llvm-project/commit/711a473cd9e3c8e63ad3460d49fdab1545634dd2.diff

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. It looks like this broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101333/new/ https://rev

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

aprantl created this revision. aprantl added reviewers: JDevlieghere, labath, jasonmolenda, jingham, clayborg. Herald added subscribers: atanasyan, arichardson, sdardis. aprantl requested review of this revision. The Mips in DW_LANG_Mips_Assembler is a vendor name not an architecture name and in

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace updated this revision to Diff 341017. wallace added a comment. now checking if the strings gotten from the API are null or not CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101131/new/ https://reviews.llvm.org/D101131 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/l

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:239 + const uint32_t line = m_location_spec.GetLine(); + auto optional_column =

[Lldb-commits] [lldb] 44e2247 - [lldb] Fix DataLayout reference after 0f1137ba79c0

Author: Jordan Rupprecht Date: 2021-04-27T20:07:09-07:00 New Revision: 44e2247dcd04f3421164b085094eb575270564ba URL: https://github.com/llvm/llvm-project/commit/44e2247dcd04f3421164b085094eb575270564ba DIFF: https://github.com/llvm/llvm-project/commit/44e2247dcd04f3421164b085094eb575270564ba.di

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925 lldb::SBDeclaration declaration = v.GetDeclaration(); -std::string file_name(declaration.GetFileSpec().GetFilename()); const uint32_t line = declaration.GetLine(); i