JDevlieghere added inline comments.
================ Comment at: lldb/docs/resources/test.rst:229 + and makes the test much harder to debug and maintain. The test programs + should always be deterministic (i.e., do not generate and check against + random test values). ---------------- jasonmolenda wrote: > teemperor wrote: > > JDevlieghere wrote: > > > > > Done. I actually believe the comma is correct (at least the internet says > > it is and if that's not a reliable source than what is). > two cents - if it were english, like "(that is, do not generate", I'd use a > comma. I've never thought about which is correct with "i.e." but if I were > thinking about it, I'd go with a comma. Interesting, so this is a British/American English thing, where the former generally does not use a comma while the latter does. I learned something new today :-) Anyway, well free to add the comma again as the docs are all using American English. (sorry for the churn!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
