teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: lldb/source/Expression/UserExpression.cpp:309 + os << "expression failed to parse:\n"; + if (diagnostic_manager.Diagnostics().size()) + os << diagnostic_manager.GetString(); ---------------- Nit: `if (!diagnostic_manager.Diagnostics().empty()) {` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101333/new/ https://reviews.llvm.org/D101333 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits