[Lldb-commits] [lldb] 801c786 - [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA

Author: David Spickett Date: 2021-01-07T10:51:47Z New Revision: 801c7866e6d4fba81c97d27ca56c9e05ba7b157a URL: https://github.com/llvm/llvm-project/commit/801c7866e6d4fba81c97d27ca56c9e05ba7b157a DIFF: https://github.com/llvm/llvm-project/commit/801c7866e6d4fba81c97d27ca56c9e05ba7b157a.diff LOG

[Lldb-commits] [PATCH] D94084: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG801c7866e6d4: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. I'll follow your recommendations. Regarding Windows, mkfifo can be replaced with CreateNamedPipe and should lead to the same behavior. Sadly, I don't have a Windows machine where I could even compile it... So this should be left for someone else or for when I can get my

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace marked an inline comment as done. wallace added a comment. I'll think about just writing this as tcp sockets. That would for sure be cross platform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 _

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace marked 5 inline comments as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2994 + // signal to prevent being paused forever. + const char *timeout_env_var = getenv("LLDB_VSCODE_RIT_TIMEOUT_IN_MS"); + int timeout_in_ms =

[Lldb-commits] [PATCH] D94244: [lldb] Bump the required SWIG version to 3

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Bump the required SWIG version to 3. If my memory serves me well we last bumped the required SWIG version to 2 for Python 3. At that time SWI

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

JDevlieghere added a comment. In D93926#2481929 , @labath wrote: > In D93926#2479749 , @JDevlieghere > wrote: > >> Your argument is correct because the interactive script interpreter always >> belongs to a single

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

labath added a comment. In D94064#2483578 , @dblaikie wrote: > In D94064#2481925 , @labath wrote: > >> I don't think that simply setting func_lo_pc to zero will be sufficient to >> make this work. I would expect th

[Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D94063#2483546 , @dblaikie wrote: > If it's better to write it using C++ source and custom clang flags I can do > that instead (it'll be an -mllvm f

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

nickdesaulniers added a comment. This causes: $ clang -E -fno-integrated-cc1 x.c | tee foo.txt |head to crash. If I revert 9a3f892d018238dce5181e458905311db8e682f5 and 4624e83ce7b124545b55e45ba13f2d900ed65654

[Lldb-commits] [lldb] 274afac - lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

Author: David Blaikie Date: 2021-01-07T14:28:03-08:00 New Revision: 274afac9a17f43e5396a0d6c7a0741702596a7bd URL: https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd DIFF: https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd.diff

[Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG274afac9a17f: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

dblaikie added a comment. In D94063#2485271 , @labath wrote: > In D94063#2483546 , @dblaikie wrote: > >> If it's better to write it using C++ source and custom clang flags I can do >> that instead (it'll be an -mll

[Lldb-commits] [lldb] 15f5971 - [LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection

Author: Luís Marques Date: 2021-01-07T23:02:55Z New Revision: 15f5971150684b656005cfd5b744c1a34477ff60 URL: https://github.com/llvm/llvm-project/commit/15f5971150684b656005cfd5b744c1a34477ff60 DIFF: https://github.com/llvm/llvm-project/commit/15f5971150684b656005cfd5b744c1a34477ff60.diff LOG:

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits > wrote: > > dblaikie added a comment. > > In D94063#2485271 , @labath wrote: > >> In D94063#2483546 , @dblaikie wrote: >> >>> If it

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, mib. Herald added a subscriber: arphaman. JDevlieghere requested review of this revision. Replace uses of `GetModuleAtIndexUnlocked` and `GetModulePointerAtIndexUnlocked` with the `ModuleIterable` and `ModuleIterableNoLoc

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this in favor of using the ModuleIterable everywhere: https://reviews.llvm.org/D94271 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94136/new/ https://reviews.llvm.org/D94136 ___

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Thu, Jan 7, 2021 at 3:37 PM Jim Ingham via lldb-commits wrote: > > > > > On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits > > wrote: > > > > dblaikie added a comment. > > > > In D94063#2485271 , @labath wrote: > > > >> In D940

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM apart from few nits. Comment at: lldb/include/lldb/Core/ModuleList.h:485-486 typedef AdaptedIterable ModuleIterableNoLocking; - ModuleIterableNoLocking ModulesNoLoc

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

JDevlieghere updated this revision to Diff 315276. JDevlieghere marked 5 inline comments as done. JDevlieghere added a comment. Address @mib's code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94271/new/ https://reviews.llvm.org/D94271 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:485-486 typedef AdaptedIterable ModuleIterableNoLocking; - ModuleIterableNoLocking ModulesNoLocking() { + ModuleIterableNoLocking ModulesNoLocking() const { return ModuleIterableN

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

mib added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:485-486 typedef AdaptedIterable ModuleIterableNoLocking; - ModuleIterableNoLocking ModulesNoLocking() { + ModuleIterableNoLocking ModulesNoLocking() const { return ModuleIterableNoLocking(

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1404 std::lock_guard guard(module_list.GetMutex()); const size_t num_modules = module_list.GetSize(); if (num_modules > 0) { JDevlieghere wrote: > mib wrote: > > Same her

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 7, 2021, at 3:57 PM, David Blaikie wrote: > > On Thu, Jan 7, 2021 at 3:37 PM Jim Ingham via lldb-commits > wrote: >> >> >> >>> On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits >>> wrote: >>> >>> dblaikie added a comment. >>> >>> In D94063#2485271

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

vsk added a comment. Unfortunately I can’t get to this right now, but will take a look first thing tomorrow morning. A shot in the dark: looks like your workflow causes a clang process to be sent SIGPIPE more than once. The second time, it exits with ioerr. I expected this to be the pre-patch

[Lldb-commits] [lldb] 696775d - Fix subprogram_ranges.test by explicitly using lld

Author: David Blaikie Date: 2021-01-07T19:53:17-08:00 New Revision: 696775d96ecd20aacb7935541995a5554bb32ba8 URL: https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8 DIFF: https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8.diff

[Lldb-commits] [lldb] 2ff36e7 - lldb subprogram_ranges.test - remove dependence on temp file name

Author: David Blaikie Date: 2021-01-07T20:04:22-08:00 New Revision: 2ff36e79291486b489ae26418daa1b123473b405 URL: https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405 DIFF: https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405.diff

[Lldb-commits] [PATCH] D94284: [lldb] Make DoReadMemory a protected method.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere requested review of this revision. DoReadMemory is LLDB's internal implementation and shouldn't be called directly. https://reviews.llvm.org/D94284 Files: lldb/include/lldb/Target/Process.h lldb/source/Plu

[Lldb-commits] [PATCH] D94271: [lldb] Replace GetModuleAtIndexUnlocked and GetModulePointerAtIndexUnlocked with iterators (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2e05855deb3: [lldb] Access the ModuleList through iterators where possible (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f2e0585 - [lldb] Access the ModuleList through iterators where possible (NFC)

Author: Jonas Devlieghere Date: 2021-01-07T21:06:36-08:00 New Revision: f2e05855deb39125a30a67b63a5e524792805768 URL: https://github.com/llvm/llvm-project/commit/f2e05855deb39125a30a67b63a5e524792805768 DIFF: https://github.com/llvm/llvm-project/commit/f2e05855deb39125a30a67b63a5e524792805768.d

[Lldb-commits] [PATCH] D94284: [lldb] Make DoReadMemory a protected method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG57e0cd356287: [lldb] Make DoReadMemory a protected method. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 57e0cd3 - [lldb] Make DoReadMemory a protected method.

Author: Jonas Devlieghere Date: 2021-01-07T21:06:36-08:00 New Revision: 57e0cd356287321c4847a9e0a9177516dae0cbc1 URL: https://github.com/llvm/llvm-project/commit/57e0cd356287321c4847a9e0a9177516dae0cbc1 DIFF: https://github.com/llvm/llvm-project/commit/57e0cd356287321c4847a9e0a9177516dae0cbc1.d

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza added a comment. What's the boundaries of the stable API, then? This was a public API that was removed and broke a plugin I used for vim (and I'll be this isn't the only case, just I'm maybe the only one who has worked on lldb before whose tool broke). The author used `threading.Thread(so

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

JDevlieghere added a comment. In D93926#2486013 , @lanza wrote: > What's the boundaries of the stable API, then? This was a public API that was > removed and broke a plugin I used for vim. The author used > `threading.Thread(someFunc, (debugger,))` to li

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza added a comment. I guess if the intention of that is maintain the debugger instance around it should work, but at the moment it segfaults pretty quick with Xcode's lldb using: import threading import lldb import time def background(debugger: lldb.SBDebugger): while True:

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

JDevlieghere added a comment. In D93926#2486038 , @lanza wrote: > I guess if the intention of that is maintain the debugger instance around it > should work, but at the moment it segfaults pretty quick with Xcode's lldb > using: Hmm, the debugger someho

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza abandoned this revision. lanza added a comment. Great, that does indeed seem to work properly. Thanks, Jonas! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93926/new/ https://reviews.llvm.org/D93926 __